From 0cb181b13860b5951aa6801eca7578b9c2bb16c3 Mon Sep 17 00:00:00 2001 From: Thomas SharedInbox Date: Wed, 20 May 2026 21:09:24 +0200 Subject: [PATCH] fix(ci): remove wait from otelrecv cleanup; add pkill by name as fallback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit wait "$RECV_PID" was blocking despite kill -9 (possibly because $RECV_PID was garbled by ANSI escape codes from dagger output, making kill target the wrong PID). Fix: - Remove wait entirely — zombie is reaped when the shell exits - Add pkill -9 -f otelrecv.py as fallback in case kill-by-PID misses - Log PID at capture time to verify correctness in CI logs Co-Authored-By: Claude Sonnet 4.6 --- Taskfile.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Taskfile.yml b/Taskfile.yml index 2831d60..23120a2 100644 --- a/Taskfile.yml +++ b/Taskfile.yml @@ -290,10 +290,11 @@ tasks: PORTFILE=$(mktemp) python3 ci/otelrecv.py --port-file="$PORTFILE" & RECV_PID=$! + echo "$(_ts) otelrecv started pid=$RECV_PID" >&2 cleanup() { - echo "$(_ts) cleanup: killing otelrecv pid=$RECV_PID" >&2 + echo "$(_ts) cleanup: killing otelrecv (pid=$RECV_PID)" >&2 kill -9 "$RECV_PID" 2>/dev/null - wait "$RECV_PID" 2>/dev/null + pkill -9 -f "otelrecv.py" 2>/dev/null || true echo "$(_ts) cleanup: done" >&2 rm -f "$PORTFILE" "$DAGGER_OUT" "$RC_FILE" }