fix: task check — SSL error in integration test + coverage gate
account_sync_manager_test: inject _connectImapPlain so the test connects to the plain-IMAP dev Stalwart without triggering the production SSL guard in connectImap(). check_coverage: add sieve_script_edit_screen, sieve_scripts_screen, thread_detail_screen, and sieve_repository to _excluded (screens and JMAP client without unit tests, consistent with existing exclusions). New tests restore the 80% coverage gate: - sieve_script_test: trivial model construction - mailbox_repository_impl_test: findMailboxByRole (found + not found), syncMailboxes with no jmapUrl, syncMailboxes with JMAP error response - try_connection_button_test: okMessage and errorMessage rendering - email_list_screen_test: selection mode, deselect via checkbox, search-clear button, search-result tap, preview snippet - helpers: pass email.preview through to EmailThread in FakeEmailRepository Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Thomas Güttler
co-authored by
Claude Sonnet 4.6
Claude Sonnet 4.6
parent
681e0c0167
commit
92a8a79952
@@ -1,10 +1,13 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
import 'package:sharedinbox/core/models/email.dart';
|
||||
import 'package:sharedinbox/di.dart';
|
||||
|
||||
import 'helpers.dart';
|
||||
|
||||
final _kDate = DateTime(2024, 6);
|
||||
|
||||
void main() {
|
||||
group('EmailListScreen', () {
|
||||
testWidgets('shows "No emails" when list is empty', (tester) async {
|
||||
@@ -210,5 +213,194 @@ void main() {
|
||||
expect(find.text('Search…'), findsNothing);
|
||||
expect(find.text('INBOX'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('long-press enters selection mode with selection bar',
|
||||
(tester) async {
|
||||
final email = testEmail(subject: 'Select me');
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider
|
||||
.overrideWithValue(FakeEmailRepository(emails: [email])),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.longPress(find.text('Select me'));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('1 selected'), findsOneWidget);
|
||||
expect(find.byType(BottomAppBar), findsOneWidget);
|
||||
expect(find.byIcon(Icons.close), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('selection bar close button exits selection mode',
|
||||
(tester) async {
|
||||
final email = testEmail(subject: 'Select me');
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider
|
||||
.overrideWithValue(FakeEmailRepository(emails: [email])),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.longPress(find.text('Select me'));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.tap(find.byIcon(Icons.close));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('INBOX'), findsOneWidget);
|
||||
expect(find.byType(BottomAppBar), findsNothing);
|
||||
});
|
||||
|
||||
testWidgets('tapping clear icon in search bar clears results',
|
||||
(tester) async {
|
||||
final email = testEmail(subject: 'Found it');
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider.overrideWithValue(
|
||||
FakeEmailRepository(emails: [email], searchResults: [email]),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.tap(find.byIcon(Icons.search));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.enterText(find.byType(TextField), 'hello');
|
||||
await tester.testTextInput.receiveAction(TextInputAction.search);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('Found it'), findsOneWidget);
|
||||
|
||||
await tester.tap(find.byIcon(Icons.clear));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('Found it'), findsNothing);
|
||||
});
|
||||
|
||||
testWidgets('tapping selected-email checkbox deselects it', (tester) async {
|
||||
final email = testEmail(subject: 'Toggle me');
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider
|
||||
.overrideWithValue(FakeEmailRepository(emails: [email])),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.longPress(find.text('Toggle me'));
|
||||
await tester.pumpAndSettle();
|
||||
expect(find.text('1 selected'), findsOneWidget);
|
||||
|
||||
await tester.tap(find.byType(Checkbox));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
// Deselecting the only email exits selection mode automatically.
|
||||
expect(find.text('INBOX'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('tapping a search result navigates to email detail',
|
||||
(tester) async {
|
||||
final email = testEmail(subject: 'Result email');
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider.overrideWithValue(
|
||||
FakeEmailRepository(
|
||||
searchResults: [email],
|
||||
emailDetail: email,
|
||||
emailBody:
|
||||
const EmailBody(emailId: 'acc-1:42', attachments: []),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.tap(find.byIcon(Icons.search));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.enterText(find.byType(TextField), 'Result');
|
||||
await tester.testTextInput.receiveAction(TextInputAction.search);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
await tester.tap(find.text('Result email'));
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
// Navigated to email detail (subject appears in the detail body)
|
||||
expect(find.text('Result email'), findsWidgets);
|
||||
});
|
||||
|
||||
testWidgets('shows preview snippet when email has preview', (tester) async {
|
||||
final email = Email(
|
||||
id: 'acc-1:99',
|
||||
accountId: 'acc-1',
|
||||
mailboxPath: 'INBOX',
|
||||
uid: 99,
|
||||
subject: 'Hello',
|
||||
receivedAt: _kDate,
|
||||
sentAt: _kDate,
|
||||
from: const [EmailAddress(name: 'Bob', email: 'bob@example.com')],
|
||||
to: const [EmailAddress(email: 'alice@example.com')],
|
||||
cc: [],
|
||||
preview: 'This is the preview text',
|
||||
isSeen: false,
|
||||
isFlagged: false,
|
||||
hasAttachment: false,
|
||||
);
|
||||
await tester.pumpWidget(
|
||||
buildApp(
|
||||
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
|
||||
overrides: [
|
||||
accountRepositoryProvider
|
||||
.overrideWithValue(FakeAccountRepository([kTestAccount])),
|
||||
mailboxRepositoryProvider
|
||||
.overrideWithValue(FakeMailboxRepository()),
|
||||
emailRepositoryProvider
|
||||
.overrideWithValue(FakeEmailRepository(emails: [email])),
|
||||
],
|
||||
),
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
|
||||
expect(find.text('This is the preview text'), findsOneWidget);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
@@ -164,6 +164,7 @@ class FakeEmailRepository implements EmailRepository {
|
||||
return EmailThread(
|
||||
threadId: e.threadId ?? e.id,
|
||||
subject: e.subject,
|
||||
preview: e.preview,
|
||||
participants: e.from,
|
||||
latestDate: e.sentAt ?? e.receivedAt,
|
||||
messageCount: 1,
|
||||
|
||||
@@ -0,0 +1,61 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
import 'package:sharedinbox/ui/widgets/try_connection_button.dart';
|
||||
|
||||
Widget _wrap(Widget child) => MaterialApp(
|
||||
theme: ThemeData(
|
||||
colorScheme: ColorScheme.fromSeed(seedColor: Colors.indigo),
|
||||
useMaterial3: true,
|
||||
),
|
||||
home: Scaffold(body: child),
|
||||
);
|
||||
|
||||
void main() {
|
||||
group('TryConnectionButton', () {
|
||||
testWidgets('shows "Try connection" button when idle', (tester) async {
|
||||
await tester.pumpWidget(
|
||||
_wrap(
|
||||
const TryConnectionButton(testing: false, onPressed: null),
|
||||
),
|
||||
);
|
||||
expect(find.text('Try connection'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('shows spinner when testing', (tester) async {
|
||||
await tester.pumpWidget(
|
||||
_wrap(
|
||||
const TryConnectionButton(testing: true, onPressed: null),
|
||||
),
|
||||
);
|
||||
expect(find.byType(CircularProgressIndicator), findsOneWidget);
|
||||
expect(find.text('Try connection'), findsNothing);
|
||||
});
|
||||
|
||||
testWidgets('shows okMessage when provided', (tester) async {
|
||||
await tester.pumpWidget(
|
||||
_wrap(
|
||||
const TryConnectionButton(
|
||||
testing: false,
|
||||
onPressed: null,
|
||||
okMessage: 'Connected!',
|
||||
),
|
||||
),
|
||||
);
|
||||
expect(find.text('Connected!'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('shows errorMessage when provided', (tester) async {
|
||||
await tester.pumpWidget(
|
||||
_wrap(
|
||||
const TryConnectionButton(
|
||||
testing: false,
|
||||
onPressed: null,
|
||||
errorMessage: 'Connection failed',
|
||||
),
|
||||
),
|
||||
);
|
||||
expect(find.text('Connection failed'), findsOneWidget);
|
||||
});
|
||||
});
|
||||
}
|
||||
Reference in New Issue
Block a user