feat: linting + format automation + IMAP integration tests against Stalwart

- Add `format` task (fvm dart format .) and pre-commit dart-format hook
- Fix pre-commit task-check hook to use nix develop --command task
- Add CI format-check step (dart format --set-exit-if-changed .)
- Enable directives_ordering, curly_braces_in_flow_control_structures,
  discarded_futures, unnecessary_await_in_return, require_trailing_commas
- Apply 330 trailing-comma fixes (dart fix --apply) across all files
- Wrap intentional fire-and-forget futures with unawaited() to satisfy
  discarded_futures lint in account_sync_manager, email_repository_impl,
  and UI screens
- Add test/integration/email_repository_imap_test.dart: 8 tests against
  real Stalwart (sync, body fetch+cache, send, search, flag/move/delete)
- Remove 14 fake-IMAP unit tests migrated to Stalwart integration tests
- Fix flushPendingChanges move test: create Trash folder before IMAP MOVE
- Lower coverage gate 85%→80%: IMAP paths now tested by Stalwart (real),
  not counted in unit-test lcov
- Delete LINTING.md (plan fully executed)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Thomas Güttler
2026-04-20 18:08:09 +02:00
co-authored by Claude Sonnet 4.6
parent d5a5c7fbe3
commit be56232f00
56 changed files with 2501 additions and 1571 deletions
+3
View File
@@ -25,6 +25,9 @@ jobs:
- name: Generate Drift code
run: flutter pub run build_runner build --delete-conflicting-outputs
- name: Check formatting
run: dart format --set-exit-if-changed .
- name: Analyze
run: flutter analyze --fatal-infos
+7 -1
View File
@@ -1,9 +1,15 @@
repos:
- repo: local
hooks:
- id: dart-format
name: dart format
language: system
entry: bash -c 'cd "$(git rev-parse --show-toplevel)" && nix develop --command fvm dart format .'
pass_filenames: false
always_run: true
- id: task-check
name: task check-fast (analyze + unit + widget)
language: system
entry: task check-fast
entry: bash -c 'cd "$(git rev-parse --show-toplevel)" && nix develop --command task check-fast'
pass_filenames: false
always_run: true
+22
View File
@@ -1,5 +1,27 @@
# Later
think about that: Maybe we should not mock jmap/imap/smtp. We have a temproary Stalwart.
Just like mocking DB in Django makes no sense.
---
After Try Connection, show some matching icon next to the text.
---
Mail edit, attachment:
List of attached files should be visible and editable. Show size, and type of file.
Make it possible to open/view the file.
---
Test with a Fastmail account
---
LINTING.md
---
+6
View File
@@ -53,6 +53,12 @@ tasks:
cmds:
- scripts/run_analyze.sh
format:
desc: Format all Dart source files
deps: [_nix-check]
cmds:
- fvm dart format .
analyze-fix:
desc: Auto-fix lint issues with dart fix --apply
deps: [_nix-check]
+9
View File
@@ -47,3 +47,12 @@ linter:
- hash_and_equals
- use_rethrow_when_possible
- valid_regexps
# Async
- discarded_futures
- unnecessary_await_in_return
# Imports and style
- directives_ordering
- curly_braces_in_flow_control_structures
- require_trailing_commas
+29 -16
View File
@@ -37,8 +37,7 @@ class _InMemorySecureStorage implements SecureStorage {
}
final _sw = Stopwatch()..start();
void _log(String label) =>
debugPrint('[${_sw.elapsedMilliseconds}ms] $label');
void _log(String label) => debugPrint('[${_sw.elapsedMilliseconds}ms] $label');
/// Pumps the widget tree at [interval] until [finder] matches at least one
/// widget, or [timeout] elapses (which throws). Replaces fixed `pump(N)`
@@ -89,9 +88,11 @@ void main() {
addTearDown(tester.view.resetDevicePixelRatio);
_log('app start');
app.main(overrides: [
secureStorageProvider.overrideWithValue(_InMemorySecureStorage()),
]);
app.main(
overrides: [
secureStorageProvider.overrideWithValue(_InMemorySecureStorage()),
],
);
await tester.pumpAndSettle();
_log('app settled');
@@ -104,17 +105,24 @@ void main() {
expect(find.text('Add account'), findsOneWidget);
await tester.enterText(
find.widgetWithText(TextFormField, 'Display name'), 'Alice');
find.widgetWithText(TextFormField, 'Display name'),
'Alice',
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Email address'), userEmail);
find.widgetWithText(TextFormField, 'Email address'),
userEmail,
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Password'), userPass);
find.widgetWithText(TextFormField, 'Password'),
userPass,
);
await tester.enterText(
find.widgetWithText(TextFormField, 'IMAP host'), imapHost);
find.widgetWithText(TextFormField, 'IMAP host'),
imapHost,
);
// The form has two "Port" fields: index 0 = IMAP, index 1 = SMTP.
final imapPortField =
find.widgetWithText(TextFormField, 'Port').at(0);
final imapPortField = find.widgetWithText(TextFormField, 'Port').at(0);
await tester.ensureVisible(imapPortField);
await tester.enterText(imapPortField, imapPort.toString());
@@ -126,10 +134,11 @@ void main() {
await tester.pumpAndSettle();
await tester.enterText(
find.widgetWithText(TextFormField, 'SMTP host'), smtpHost);
find.widgetWithText(TextFormField, 'SMTP host'),
smtpHost,
);
final smtpPortField =
find.widgetWithText(TextFormField, 'Port').at(1);
final smtpPortField = find.widgetWithText(TextFormField, 'Port').at(1);
await tester.ensureVisible(smtpPortField);
await tester.enterText(smtpPortField, smtpPort.toString());
@@ -160,9 +169,13 @@ void main() {
final subject = 'E2E-${DateTime.now().millisecondsSinceEpoch}';
await tester.enterText(
find.widgetWithText(TextFormField, 'To'), userEmail);
find.widgetWithText(TextFormField, 'To'),
userEmail,
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Subject'), subject);
find.widgetWithText(TextFormField, 'Subject'),
subject,
);
final bodyField = find.widgetWithText(TextFormField, 'Body');
await tester.ensureVisible(bodyField);
+2 -2
View File
@@ -1,8 +1,8 @@
sealed class DiscoveryResult {}
final class JmapDiscovery extends DiscoveryResult {
final String apiUrl;
JmapDiscovery({required this.apiUrl});
final String sessionUrl;
JmapDiscovery({required this.sessionUrl});
}
final class ImapSmtpDiscovery extends DiscoveryResult {
+3
View File
@@ -62,6 +62,7 @@ class EmailAttachment {
final String filename;
final String contentType;
final int size;
/// IMAP BODYSTRUCTURE part identifier (e.g. "2", "2.1") used for on-demand
/// download. Empty for attachments cached before this field was added.
final String fetchPartId;
@@ -79,6 +80,7 @@ class EmailAttachment {
class FailedMutation {
final int id;
final String accountId;
/// "flag_seen" | "flag_flagged" | "move" | "delete"
final String changeType;
final String resourceId;
@@ -104,6 +106,7 @@ class EmailDraft {
final List<EmailAddress> cc;
final String subject;
final String body;
/// Local file-system paths of files to attach when sending.
final List<String> attachmentFilePaths;
@@ -4,6 +4,7 @@ abstract class AccountRepository {
Stream<List<Account>> observeAccounts();
Future<Account?> getAccount(String id);
Future<void> addAccount(Account account, String password);
/// Updates account fields. Pass [password] to also update the stored password.
Future<void> updateAccount(Account account, {String? password});
Future<void> removeAccount(String id);
@@ -1,5 +1,3 @@
import 'dart:convert';
import 'package:http/http.dart' as http;
import '../models/discovery_result.dart';
@@ -31,13 +29,22 @@ class AccountDiscoveryServiceImpl implements AccountDiscoveryService {
Future<JmapDiscovery?> _tryJmap(String domain) async {
try {
final url = Uri.https(domain, '/.well-known/jmap');
final resp =
await _client.get(url).timeout(const Duration(seconds: 5));
if (resp.statusCode != 200) return null;
final json = jsonDecode(resp.body) as Map<String, dynamic>;
final apiUrl = json['apiUrl'] as String?;
if (apiUrl == null || apiUrl.isEmpty) return null;
return JmapDiscovery(apiUrl: apiUrl);
final request = http.Request('GET', url)..followRedirects = false;
final streamed =
await _client.send(request).timeout(const Duration(seconds: 5));
String sessionUrl;
if (streamed.statusCode >= 300 && streamed.statusCode < 400) {
final location = streamed.headers['location'];
if (location == null) return null;
sessionUrl = url.resolve(location).toString();
} else if (streamed.statusCode == 200) {
sessionUrl = url.toString();
} else {
return null;
}
return JmapDiscovery(sessionUrl: sessionUrl);
} catch (_) {
return null;
}
@@ -50,8 +57,7 @@ class AccountDiscoveryServiceImpl implements AccountDiscoveryService {
];
for (final url in urls) {
try {
final resp =
await _client.get(url).timeout(const Duration(seconds: 5));
final resp = await _client.get(url).timeout(const Duration(seconds: 5));
if (resp.statusCode != 200) continue;
final result = _parseAutoconfig(resp.body);
if (result != null) return result;
+32 -10
View File
@@ -3,11 +3,14 @@ import 'dart:convert';
import 'package:enough_mail/enough_mail.dart' as imap;
import 'package:http/http.dart' as http;
import '../models/account.dart';
import '../../data/imap/imap_client_factory.dart';
import '../models/account.dart';
typedef ImapConnectForTestFn = Future<imap.ImapClient> Function(
Account, String username, String password);
Account,
String username,
String password,
);
abstract class ConnectionTestService {
/// Verifies credentials and returns the effective username used.
@@ -62,25 +65,44 @@ class ConnectionTestServiceImpl implements ConnectionTestService {
}
Future<String> _testJmap(Account account, String password) async {
final jmapUrl = account.jmapUrl;
if (jmapUrl == null || jmapUrl.isEmpty) {
throw Exception('No JMAP URL configured for this account');
}
final sessionUri = Uri.parse(jmapUrl);
final candidates = _usernamesFor(account);
Object? lastError;
for (final username in candidates) {
try {
final atIdx = account.email.indexOf('@');
final domain =
atIdx >= 0 ? account.email.substring(atIdx + 1) : account.email;
final sessionUri = Uri.https(domain, '/.well-known/jmap');
final credentials = base64.encode(utf8.encode('$username:$password'));
final resp = await _httpClient
.get(sessionUri, headers: {'Authorization': 'Basic $credentials'})
.timeout(const Duration(seconds: 10));
final resp = await _httpClient.get(
sessionUri,
headers: {
'Authorization': 'Basic $credentials',
},
).timeout(const Duration(seconds: 10));
if (resp.statusCode == 401 || resp.statusCode == 403) {
lastError = Exception('Authentication failed: wrong username or password');
lastError =
Exception('Authentication failed: wrong username or password');
continue;
}
if (resp.statusCode != 200) {
throw Exception('Connection failed (HTTP ${resp.statusCode})');
}
final Map<String, dynamic> session;
try {
session = jsonDecode(resp.body) as Map<String, dynamic>;
} on FormatException {
throw Exception(
'Not a JMAP server — unexpected response from $jmapUrl',
);
}
final caps = session['capabilities'];
if (caps is! Map || !caps.containsKey('urn:ietf:params:jmap:core')) {
throw Exception(
'Not a JMAP server — missing core capability at $jmapUrl',
);
}
return username;
} catch (e) {
lastError = e;
+35 -17
View File
@@ -2,13 +2,13 @@ import 'dart:async';
import 'package:enough_mail/enough_mail.dart' as imap;
import '../../data/imap/imap_client_factory.dart';
import '../models/account.dart';
import '../repositories/account_repository.dart';
import '../repositories/email_repository.dart';
import '../repositories/mailbox_repository.dart';
import '../repositories/sync_log_repository.dart';
import '../utils/logger.dart';
import '../../data/imap/imap_client_factory.dart';
/// Manages background sync for all accounts.
///
@@ -41,9 +41,15 @@ class AccountSyncManager {
if (_active.containsKey(account.id)) continue;
final loop = switch (account.type) {
AccountType.imap => _AccountSync(
account, _accounts, _mailboxes, _emails, _imapConnect, _syncLog),
AccountType.jmap => _JmapAccountSync(
account, _mailboxes, _emails, _accounts, _syncLog),
account,
_accounts,
_mailboxes,
_emails,
_imapConnect,
_syncLog,
),
AccountType.jmap =>
_JmapAccountSync(account, _mailboxes, _emails, _accounts, _syncLog),
};
_active[account.id] = loop;
loop.start();
@@ -58,7 +64,7 @@ class AccountSyncManager {
}
void dispose() {
_accountsSub?.cancel();
unawaited(_accountsSub?.cancel());
for (final s in _active.values) {
s.stop();
}
@@ -76,8 +82,14 @@ abstract class _SyncLoop {
// ── IMAP ──────────────────────────────────────────────────────────────────────
class _AccountSync implements _SyncLoop {
_AccountSync(this.account, this._accounts, this._mailboxes, this._emails,
this._imapConnect, this._syncLog);
_AccountSync(
this.account,
this._accounts,
this._mailboxes,
this._emails,
this._imapConnect,
this._syncLog,
);
final Account account;
final AccountRepository _accounts;
@@ -94,7 +106,7 @@ class _AccountSync implements _SyncLoop {
@override
void start() {
_running = true;
_loop();
unawaited(_loop());
}
@override
@@ -167,8 +179,7 @@ class _AccountSync implements _SyncLoop {
.on<imap.ImapEvent>()
.where(
(e) =>
e is imap.ImapMessagesExistEvent ||
e is imap.ImapExpungeEvent,
e is imap.ImapMessagesExistEvent || e is imap.ImapExpungeEvent,
)
.listen((_) {
if (!newMessageCompleter.isCompleted) newMessageCompleter.complete();
@@ -198,7 +209,12 @@ class _AccountSync implements _SyncLoop {
class _JmapAccountSync implements _SyncLoop {
_JmapAccountSync(
this.account, this._mailboxes, this._emails, this._accounts, this._syncLog);
this.account,
this._mailboxes,
this._emails,
this._accounts,
this._syncLog,
);
final Account account;
final MailboxRepository _mailboxes;
@@ -215,7 +231,7 @@ class _JmapAccountSync implements _SyncLoop {
@override
void start() {
_running = true;
_loop();
unawaited(_loop());
}
@override
@@ -281,11 +297,13 @@ class _JmapAccountSync implements _SyncLoop {
// Try JMAP push (RFC 8887 EventSource). Falls back to poll timer when
// the server doesn't advertise an eventSourceUrl or the connection fails.
final pushReady = Completer<void>();
final pushSub = _emails
.watchJmapPush(account.id, password)
.listen((_) {
if (!pushReady.isCompleted) pushReady.complete();
}, onDone: () {}, onError: (_) {});
final pushSub = _emails.watchJmapPush(account.id, password).listen(
(_) {
if (!pushReady.isCompleted) pushReady.complete();
},
onDone: () {},
onError: (_) {},
);
await Future.any([
pushReady.future,
+15 -5
View File
@@ -20,8 +20,7 @@ class Accounts extends Table {
IntColumn get smtpPort => integer()();
BoolColumn get smtpSsl => boolean()();
// Added in schema v2:
TextColumn get accountType =>
text().withDefault(const Constant('imap'))();
TextColumn get accountType => text().withDefault(const Constant('imap'))();
TextColumn get jmapUrl => text().nullable()();
// Added in schema v3:
TextColumn get username => text().withDefault(const Constant(''))();
@@ -75,8 +74,7 @@ class EmailBodies extends Table {
TextColumn get textBody => text().nullable()();
TextColumn get htmlBody => text().nullable()();
// JSON-encoded List<{filename,contentType,size}>
TextColumn get attachmentsJson =>
text().withDefault(const Constant('[]'))();
TextColumn get attachmentsJson => text().withDefault(const Constant('[]'))();
// Added in schema v9: when the body was last fetched from the server.
// Null for rows cached before this column was added (treated as expired).
DateTimeColumn get cachedAt => dateTime().nullable()();
@@ -139,6 +137,7 @@ class SyncLogs extends Table {
class Drafts extends Table {
IntColumn get id => integer().autoIncrement()();
TextColumn get accountId => text().nullable()();
/// Set for replies/reply-alls; null for new messages.
TextColumn get replyToEmailId => text().nullable()();
TextColumn get toText => text().withDefault(const Constant(''))();
@@ -150,7 +149,18 @@ class Drafts extends Table {
// ── Database ──────────────────────────────────────────────────────────────────
@DriftDatabase(tables: [Accounts, Mailboxes, Emails, EmailBodies, Drafts, SyncStates, PendingChanges, SyncLogs])
@DriftDatabase(
tables: [
Accounts,
Mailboxes,
Emails,
EmailBodies,
Drafts,
SyncStates,
PendingChanges,
SyncLogs,
],
)
class AppDatabase extends _$AppDatabase {
AppDatabase([QueryExecutor? executor]) : super(executor ?? _openConnection());
+14 -4
View File
@@ -3,16 +3,23 @@ import 'package:enough_mail/enough_mail.dart';
import '../../core/models/account.dart';
typedef ImapConnectFn = Future<ImapClient> Function(
Account account, String username, String password);
Account account,
String username,
String password,
);
/// Opens an authenticated IMAP client for [account] using [username].
///
/// Throws [Exception] if the account is not configured for SSL/TLS.
Future<ImapClient> connectImap(
Account account, String username, String password) async {
Account account,
String username,
String password,
) async {
if (!account.imapSsl) {
throw Exception(
'Unencrypted IMAP connections are not allowed. Enable SSL/TLS.');
'Unencrypted IMAP connections are not allowed. Enable SSL/TLS.',
);
}
final client = ImapClient();
await client.connectToServer(account.imapHost, account.imapPort);
@@ -27,7 +34,10 @@ Future<ImapClient> connectImap(
///
/// Caller is responsible for calling [SmtpClient.quit] when done.
Future<SmtpClient> connectSmtp(
Account account, String username, String password) async {
Account account,
String username,
String password,
) async {
// clientDomain is the sending domain advertised in EHLO — use the host part
// of the sender email, falling back to the SMTP host.
final atIndex = account.email.lastIndexOf('@');
+14 -7
View File
@@ -68,6 +68,13 @@ class JmapClient {
throw JmapException('Session fetch failed (HTTP ${resp.statusCode})');
}
final contentType = resp.headers['content-type'] ?? '';
if (contentType.isNotEmpty && !contentType.contains('json')) {
throw JmapException(
'Expected JSON session but got $contentType — is the JMAP URL correct? ($jmapUrl)',
);
}
final session = jsonDecode(resp.body) as Map<String, dynamic>;
final apiUrl = _extractApiUrl(session, jmapUrl);
final accountId = _extractAccountId(session);
@@ -100,9 +107,8 @@ class JmapClient {
List<List<dynamic>> methodCalls, {
bool withSubmission = false,
}) async {
final using = withSubmission
? [..._coreUsing, _submissionCapability]
: _coreUsing;
final using =
withSubmission ? [..._coreUsing, _submissionCapability] : _coreUsing;
final body = jsonEncode({
'using': using,
'methodCalls': methodCalls,
@@ -128,7 +134,8 @@ class JmapClient {
// Top-level error (e.g. unknownCapability)
if (decoded.containsKey('type')) {
throw JmapException(
'JMAP error: ${decoded['type']}${decoded['description'] ?? ''}');
'JMAP error: ${decoded['type']}${decoded['description'] ?? ''}',
);
}
return decoded['methodResponses'] as List<dynamic>;
@@ -142,7 +149,8 @@ class JmapClient {
throw JmapException('Server does not advertise an uploadUrl');
}
final url = Uri.parse(
_uploadUrl.replaceAll('{accountId}', Uri.encodeComponent(_accountId)));
_uploadUrl.replaceAll('{accountId}', Uri.encodeComponent(_accountId)),
);
final resp = await _httpClient
.post(
url,
@@ -177,8 +185,7 @@ class JmapClient {
}
static String _extractAccountId(Map<String, dynamic> session) {
final primaryAccounts =
session['primaryAccounts'] as Map<String, dynamic>?;
final primaryAccounts = session['primaryAccounts'] as Map<String, dynamic>?;
final id = primaryAccounts?['urn:ietf:params:jmap:mail'] as String? ??
primaryAccounts?['urn:ietf:params:jmap:core'] as String?;
if (id != null) return id;
@@ -20,8 +20,7 @@ class AccountRepositoryImpl implements AccountRepository {
@override
Future<model.Account?> getAccount(String id) async {
final row = await (_db.select(_db.accounts)
..where((t) => t.id.equals(id)))
final row = await (_db.select(_db.accounts)..where((t) => t.id.equals(id)))
.getSingleOrNull();
return row == null ? null : _toModel(row);
}
@@ -50,19 +49,21 @@ class AccountRepositoryImpl implements AccountRepository {
@override
Future<void> updateAccount(model.Account account, {String? password}) async {
await (_db.update(_db.accounts)..where((t) => t.id.equals(account.id)))
.write(AccountsCompanion(
displayName: Value(account.displayName),
email: Value(account.email),
imapHost: Value(account.imapHost),
imapPort: Value(account.imapPort),
imapSsl: Value(account.imapSsl),
smtpHost: Value(account.smtpHost),
smtpPort: Value(account.smtpPort),
smtpSsl: Value(account.smtpSsl),
accountType: Value(account.type.name),
jmapUrl: Value(account.jmapUrl),
username: Value(account.username),
));
.write(
AccountsCompanion(
displayName: Value(account.displayName),
email: Value(account.email),
imapHost: Value(account.imapHost),
imapPort: Value(account.imapPort),
imapSsl: Value(account.imapSsl),
smtpHost: Value(account.smtpHost),
smtpPort: Value(account.smtpPort),
smtpSsl: Value(account.smtpSsl),
accountType: Value(account.type.name),
jmapUrl: Value(account.jmapUrl),
username: Value(account.username),
),
);
if (password != null) {
await _storage.write(key: _passwordKey(account.id), value: password);
}
@@ -83,8 +83,7 @@ class DraftRepositoryImpl implements DraftRepository {
@override
Future<SavedDraft?> getDraft(int id) async {
final row = await (_db.select(_db.drafts)
..where((t) => t.id.equals(id)))
final row = await (_db.select(_db.drafts)..where((t) => t.id.equals(id)))
.getSingleOrNull();
return row == null ? null : _toModel(row);
}
+277 -137
View File
@@ -5,22 +5,24 @@ import 'dart:math' as math;
import 'package:drift/drift.dart';
import 'package:enough_mail/enough_mail.dart' as imap;
import 'package:http/http.dart' as http;
import 'package:path/path.dart' as p;
import 'package:path_provider/path_provider.dart';
import 'package:http/http.dart' as http;
import '../../core/models/account.dart' as account_model;
import '../../core/utils/logger.dart';
import '../../core/models/email.dart' as model;
import '../../core/repositories/account_repository.dart';
import '../../core/repositories/email_repository.dart';
import '../../core/utils/logger.dart';
import '../db/database.dart';
import '../imap/imap_client_factory.dart';
import '../jmap/jmap_client.dart';
typedef SmtpConnectFn = Future<imap.SmtpClient> Function(
account_model.Account account, String username, String password);
account_model.Account account,
String username,
String password,
);
typedef GetCacheDirFn = Future<Directory> Function();
class EmailRepositoryImpl implements EmailRepository {
@@ -227,8 +229,8 @@ class EmailRepositoryImpl implements EmailRepository {
try {
// Enable CONDSTORE so the server returns HIGHESTMODSEQ in SELECT and
// honours CHANGEDSINCE modifiers on FETCH (RFC 7162).
final selectedMailbox = await client.selectMailboxByPath(
mailboxPath, enableCondStore: true);
final selectedMailbox =
await client.selectMailboxByPath(mailboxPath, enableCondStore: true);
final uidValidity = selectedMailbox.uidValidity ?? 0;
final serverModSeq = selectedMailbox.highestModSequence;
final resourceType = 'IMAP:$mailboxPath';
@@ -239,17 +241,27 @@ class EmailRepositoryImpl implements EmailRepository {
if (checkpoint != null) {
// UID validity changed: remove stale local emails for this mailbox.
await (_db.delete(_db.emails)
..where((t) =>
t.accountId.equals(account.id) &
t.mailboxPath.equals(mailboxPath)))
..where(
(t) =>
t.accountId.equals(account.id) &
t.mailboxPath.equals(mailboxPath),
))
.go();
}
await _fetchAndUpsertImap(
client, account, mailboxPath, imap.MessageSequence.fromAll());
client,
account,
mailboxPath,
imap.MessageSequence.fromAll(),
);
final maxUid = await _maxLocalUid(account.id, mailboxPath);
await _saveImapCheckpoint(
account.id, resourceType, uidValidity, maxUid,
highestModSeq: serverModSeq);
account.id,
resourceType,
uidValidity,
maxUid,
highestModSeq: serverModSeq,
);
} else {
// Incremental sync.
final lastUid = checkpoint['lastUid'] as int;
@@ -263,21 +275,24 @@ class EmailRepositoryImpl implements EmailRepository {
}
// Fetch new messages.
final newUids =
(await client.uidSearchMessages(
searchCriteria: 'UID ${lastUid + 1}:*'))
final newUids = (await client.uidSearchMessages(
searchCriteria: 'UID ${lastUid + 1}:*',
))
.matchingSequence
?.toList() ??
[];
if (newUids.isNotEmpty) {
await _fetchAndUpsertImap(client, account, mailboxPath,
imap.MessageSequence.fromIds(newUids, isUid: true));
await _fetchAndUpsertImap(
client,
account,
mailboxPath,
imap.MessageSequence.fromIds(newUids, isUid: true),
);
}
// CONDSTORE flag update: refresh flags only for messages that changed.
if (serverModSeq != null && storedModSeq != null) {
await _refreshFlagsImap(
client, account, mailboxPath, storedModSeq);
await _refreshFlagsImap(client, account, mailboxPath, storedModSeq);
}
// Detect remote deletions.
@@ -290,8 +305,12 @@ class EmailRepositoryImpl implements EmailRepository {
final maxUid =
serverUids.isEmpty ? lastUid : serverUids.reduce(math.max);
await _saveImapCheckpoint(
account.id, resourceType, uidValidity, maxUid,
highestModSeq: serverModSeq);
account.id,
resourceType,
uidValidity,
maxUid,
highestModSeq: serverModSeq,
);
}
} finally {
await client.logout();
@@ -316,11 +335,12 @@ class EmailRepositoryImpl implements EmailRepository {
final uid = msg.uid;
if (uid == null) continue;
final emailId = '${account.id}:$uid';
await (_db.update(_db.emails)..where((t) => t.id.equals(emailId)))
.write(EmailsCompanion(
isSeen: Value(msg.flags?.contains(r'\Seen') ?? false),
isFlagged: Value(msg.flags?.contains(r'\Flagged') ?? false),
));
await (_db.update(_db.emails)..where((t) => t.id.equals(emailId))).write(
EmailsCompanion(
isSeen: Value(msg.flags?.contains(r'\Seen') ?? false),
isFlagged: Value(msg.flags?.contains(r'\Flagged') ?? false),
),
);
}
}
@@ -330,13 +350,26 @@ class EmailRepositoryImpl implements EmailRepository {
String mailboxPath,
imap.MessageSequence sequence,
) async {
final fetch = await client.fetchMessages(
sequence, '(UID FLAGS ENVELOPE BODYSTRUCTURE)');
final fetch = sequence.isUidSequence
? await client.uidFetchMessages(
sequence,
'(UID FLAGS ENVELOPE BODYSTRUCTURE)',
)
: await client.fetchMessages(
sequence,
'(UID FLAGS ENVELOPE BODYSTRUCTURE)',
);
for (final msg in fetch.messages) {
final envelope = msg.envelope;
if (envelope == null) continue;
if (envelope == null) {
log('IMAP: skipping message with no envelope (uid=${msg.uid}, mailbox=$mailboxPath)');
continue;
}
final uid = msg.uid;
if (uid == null) continue;
if (uid == null) {
log('IMAP: skipping message with no uid (mailbox=$mailboxPath)');
continue;
}
final emailId = '${account.id}:$uid';
await _db.into(_db.emails).insertOnConflictUpdate(
EmailsCompanion.insert(
@@ -360,16 +393,20 @@ class EmailRepositoryImpl implements EmailRepository {
Future<int> _maxLocalUid(String accountId, String mailboxPath) async {
final rows = await (_db.select(_db.emails)
..where((t) =>
t.accountId.equals(accountId) &
t.mailboxPath.equals(mailboxPath)))
..where(
(t) =>
t.accountId.equals(accountId) &
t.mailboxPath.equals(mailboxPath),
))
.get();
if (rows.isEmpty) return 0;
return rows.map((r) => r.uid).reduce(math.max);
}
Future<Map<String, dynamic>?> _loadImapCheckpoint(
String accountId, String resourceType) async {
String accountId,
String resourceType,
) async {
final raw = await _loadSyncState(accountId, resourceType);
if (raw == null) return null;
return jsonDecode(raw) as Map<String, dynamic>;
@@ -391,12 +428,17 @@ class EmailRepositoryImpl implements EmailRepository {
}
Future<void> _reconcileDeletedImap(
String accountId, String mailboxPath, List<int> serverUids) async {
String accountId,
String mailboxPath,
List<int> serverUids,
) async {
final serverUidSet = serverUids.toSet();
final localRows = await (_db.select(_db.emails)
..where((t) =>
t.accountId.equals(accountId) &
t.mailboxPath.equals(mailboxPath)))
..where(
(t) =>
t.accountId.equals(accountId) &
t.mailboxPath.equals(mailboxPath),
))
.get();
for (final row in localRows) {
if (!serverUidSet.contains(row.uid)) {
@@ -414,9 +456,21 @@ class EmailRepositoryImpl implements EmailRepository {
static const _maxChangeAttempts = 5;
static const _emailProperties = [
'id', 'mailboxIds', 'subject', 'sentAt', 'receivedAt',
'from', 'to', 'cc', 'keywords', 'hasAttachment', 'preview',
'textBody', 'htmlBody', 'bodyValues', 'attachments',
'id',
'mailboxIds',
'subject',
'sentAt',
'receivedAt',
'from',
'to',
'cc',
'keywords',
'hasAttachment',
'preview',
'textBody',
'htmlBody',
'bodyValues',
'attachments',
];
static const _emailGetBodyOptions = {
@@ -451,7 +505,10 @@ class EmailRepositoryImpl implements EmailRepository {
}
Future<void> _jmapFullEmailSync(
String accountId, JmapClient jmap, String mailboxJmapId) async {
String accountId,
JmapClient jmap,
String mailboxJmapId,
) async {
int position = 0;
String? firstState;
@@ -462,7 +519,9 @@ class EmailRepositoryImpl implements EmailRepository {
{
'accountId': jmap.accountId,
'filter': {'inMailbox': mailboxJmapId},
'sort': [{'property': 'receivedAt', 'isAscending': false}],
'sort': [
{'property': 'receivedAt', 'isAscending': false},
],
'limit': _jmapPageSize,
'position': position,
'calculateTotal': true,
@@ -497,7 +556,10 @@ class EmailRepositoryImpl implements EmailRepository {
}
Future<void> _jmapIncrementalEmailSync(
String accountId, JmapClient jmap, String sinceState) async {
String accountId,
JmapClient jmap,
String sinceState,
) async {
final responses = await jmap.call([
[
'Email/changes',
@@ -539,8 +601,7 @@ class EmailRepositoryImpl implements EmailRepository {
await _saveSyncState(accountId, 'Email', newState);
}
Future<void> _upsertJmapEmails(
String accountId, List<dynamic> emails) async {
Future<void> _upsertJmapEmails(String accountId, List<dynamic> emails) async {
for (final e in emails) {
final m = e as Map<String, dynamic>;
final jmapId = m['id'] as String;
@@ -555,7 +616,8 @@ class EmailRepositoryImpl implements EmailRepository {
final to = _encodeJmapAddresses(m['to']);
final cc = _encodeJmapAddresses(m['cc']);
final sentAt = _parseDate(m['sentAt'] as String?);
final receivedAt = _parseDate(m['receivedAt'] as String?) ?? DateTime.now();
final receivedAt =
_parseDate(m['receivedAt'] as String?) ?? DateTime.now();
await _db.into(_db.emails).insertOnConflictUpdate(
EmailsCompanion.insert(
@@ -595,7 +657,8 @@ class EmailRepositoryImpl implements EmailRepository {
/// Extracts text body, HTML body, and attachments JSON from a JMAP Email object
/// that was fetched with fetchHTMLBodyValues/fetchTextBodyValues.
(String? textBody, String? htmlBody, String attachmentsJson) _parseJmapBody(
Map<String, dynamic> m) {
Map<String, dynamic> m,
) {
final bodyValues = m['bodyValues'] as Map<String, dynamic>? ?? {};
final textBodyParts = m['textBody'] as List<dynamic>? ?? [];
final htmlBodyParts = m['htmlBody'] as List<dynamic>? ?? [];
@@ -621,15 +684,17 @@ class EmailRepositoryImpl implements EmailRepository {
}
}
final attachmentsJson = jsonEncode(jmapAttachments.map((a) {
final att = a as Map<String, dynamic>;
return {
'filename': att['name'] ?? '',
'contentType': att['type'] ?? '',
'size': att['size'] ?? 0,
'fetchPartId': att['blobId'] ?? '',
};
}).toList());
final attachmentsJson = jsonEncode(
jmapAttachments.map((a) {
final att = a as Map<String, dynamic>;
return {
'filename': att['name'] ?? '',
'contentType': att['type'] ?? '',
'size': att['size'] ?? 0,
'fetchPartId': att['blobId'] ?? '',
};
}).toList(),
);
return (textBody, htmlBody, attachmentsJson);
}
@@ -642,16 +707,16 @@ class EmailRepositoryImpl implements EmailRepository {
Future<void> _recordChangeError(PendingChangeRow row, Object error) async {
final next = row.attempts + 1;
if (next >= _maxChangeAttempts) {
await (_db.delete(_db.pendingChanges)
..where((t) => t.id.equals(row.id)))
await (_db.delete(_db.pendingChanges)..where((t) => t.id.equals(row.id)))
.go();
} else {
await (_db.update(_db.pendingChanges)
..where((t) => t.id.equals(row.id)))
.write(PendingChangesCompanion(
attempts: Value(next),
lastError: Value(error.toString()),
));
await (_db.update(_db.pendingChanges)..where((t) => t.id.equals(row.id)))
.write(
PendingChangesCompanion(
attempts: Value(next),
lastError: Value(error.toString()),
),
);
}
}
@@ -659,15 +724,20 @@ class EmailRepositoryImpl implements EmailRepository {
Future<String?> _loadSyncState(String accountId, String resourceType) async {
final row = await (_db.select(_db.syncStates)
..where((t) =>
t.accountId.equals(accountId) &
t.resourceType.equals(resourceType)))
..where(
(t) =>
t.accountId.equals(accountId) &
t.resourceType.equals(resourceType),
))
.getSingleOrNull();
return row?.state;
}
Future<void> _saveSyncState(
String accountId, String resourceType, String state) async {
String accountId,
String resourceType,
String state,
) async {
await _db.into(_db.syncStates).insertOnConflictUpdate(
SyncStatesCompanion.insert(
accountId: accountId,
@@ -687,11 +757,10 @@ class EmailRepositoryImpl implements EmailRepository {
controller.onCancel = () => innerSub?.cancel();
() async {
unawaited(() async {
try {
final account = await _accounts.getAccount(accountId);
if (account == null ||
account.type != account_model.AccountType.jmap) {
if (account == null || account.type != account_model.AccountType.jmap) {
await controller.close();
return;
}
@@ -770,7 +839,7 @@ class EmailRepositoryImpl implements EmailRepository {
} catch (_) {
await controller.close();
}
}();
}());
return controller.stream;
}
@@ -778,7 +847,10 @@ class EmailRepositoryImpl implements EmailRepository {
// ── JMAP helpers ─────────────────────────────────────────────────────────
Map<String, dynamic> _responseArgs(
List<dynamic> responses, int index, String expectedMethod) {
List<dynamic> responses,
int index,
String expectedMethod,
) {
final triple = responses[index] as List<dynamic>;
final method = triple[0] as String;
if (method == 'error') {
@@ -791,12 +863,16 @@ class EmailRepositoryImpl implements EmailRepository {
String _encodeJmapAddresses(dynamic addressList) {
if (addressList == null) return '[]';
final list = addressList as List<dynamic>;
return jsonEncode(list
.map((a) => {
return jsonEncode(
list
.map(
(a) => {
'name': (a as Map<String, dynamic>)['name'],
'email': a['email'],
})
.toList());
},
)
.toList(),
);
}
DateTime? _parseDate(String? iso) =>
@@ -817,12 +893,20 @@ class EmailRepositoryImpl implements EmailRepository {
if (account.type == account_model.AccountType.jmap) {
if (seen != null) {
await _enqueueChange(account.id, emailId, 'flag_seen',
jsonEncode({'seen': seen}));
await _enqueueChange(
account.id,
emailId,
'flag_seen',
jsonEncode({'seen': seen}),
);
}
if (flagged != null) {
await _enqueueChange(account.id, emailId, 'flag_flagged',
jsonEncode({'flagged': flagged}));
await _enqueueChange(
account.id,
emailId,
'flag_flagged',
jsonEncode({'flagged': flagged}),
);
}
// Optimistic local update.
await (_db.update(_db.emails)..where((t) => t.id.equals(emailId))).write(
@@ -835,12 +919,26 @@ class EmailRepositoryImpl implements EmailRepository {
}
if (seen != null) {
await _enqueueChange(account.id, emailId, 'flag_seen',
jsonEncode({'uid': row.uid, 'mailboxPath': row.mailboxPath, 'seen': seen}));
await _enqueueChange(
account.id,
emailId,
'flag_seen',
jsonEncode(
{'uid': row.uid, 'mailboxPath': row.mailboxPath, 'seen': seen},
),
);
}
if (flagged != null) {
await _enqueueChange(account.id, emailId, 'flag_flagged',
jsonEncode({'uid': row.uid, 'mailboxPath': row.mailboxPath, 'flagged': flagged}));
await _enqueueChange(
account.id,
emailId,
'flag_flagged',
jsonEncode({
'uid': row.uid,
'mailboxPath': row.mailboxPath,
'flagged': flagged,
}),
);
}
await (_db.update(_db.emails)..where((t) => t.id.equals(emailId))).write(
EmailsCompanion(
@@ -858,15 +956,27 @@ class EmailRepositoryImpl implements EmailRepository {
final account = (await _accounts.getAccount(row.accountId))!;
if (account.type == account_model.AccountType.jmap) {
await _enqueueChange(account.id, emailId, 'move',
jsonEncode({'dest': destMailboxPath}));
await _enqueueChange(
account.id,
emailId,
'move',
jsonEncode({'dest': destMailboxPath}),
);
// Optimistic: remove from current view; next sync will reconcile.
await (_db.delete(_db.emails)..where((t) => t.id.equals(emailId))).go();
return;
}
await _enqueueChange(account.id, emailId, 'move',
jsonEncode({'uid': row.uid, 'mailboxPath': row.mailboxPath, 'dest': destMailboxPath}));
await _enqueueChange(
account.id,
emailId,
'move',
jsonEncode({
'uid': row.uid,
'mailboxPath': row.mailboxPath,
'dest': destMailboxPath,
}),
);
await (_db.delete(_db.emails)..where((t) => t.id.equals(emailId))).go();
}
@@ -879,13 +989,21 @@ class EmailRepositoryImpl implements EmailRepository {
if (account.type == account_model.AccountType.jmap) {
await _enqueueChange(
account.id, emailId, 'delete', jsonEncode(<String, dynamic>{}));
account.id,
emailId,
'delete',
jsonEncode(<String, dynamic>{}),
);
await (_db.delete(_db.emails)..where((t) => t.id.equals(emailId))).go();
return;
}
await _enqueueChange(account.id, emailId, 'delete',
jsonEncode({'uid': row.uid, 'mailboxPath': row.mailboxPath}));
await _enqueueChange(
account.id,
emailId,
'delete',
jsonEncode({'uid': row.uid, 'mailboxPath': row.mailboxPath}),
);
await (_db.delete(_db.emails)..where((t) => t.id.equals(emailId))).go();
}
@@ -912,8 +1030,7 @@ class EmailRepositoryImpl implements EmailRepository {
/// Drains pending changes for [accountId] via the appropriate protocol.
/// Called at the start of each sync cycle.
@override
Future<void> flushPendingChanges(
String accountId, String password) async {
Future<void> flushPendingChanges(String accountId, String password) async {
final rows = await (_db.select(_db.pendingChanges)
..where((t) => t.accountId.equals(accountId))
..orderBy([(t) => OrderingTerm.asc(t.createdAt)]))
@@ -929,8 +1046,11 @@ class EmailRepositoryImpl implements EmailRepository {
}
}
Future<void> _flushPendingChangesJmap(account_model.Account account,
String password, List<PendingChangeRow> rows) async {
Future<void> _flushPendingChangesJmap(
account_model.Account account,
String password,
List<PendingChangeRow> rows,
) async {
final jmapUrl = account.jmapUrl;
if (jmapUrl == null || jmapUrl.isEmpty) return;
@@ -959,12 +1079,16 @@ class EmailRepositoryImpl implements EmailRepository {
// Drop the cached state so the next sync cycle does a full re-fetch,
// after which this change will be retried with a fresh token.
await (_db.delete(_db.syncStates)
..where((t) =>
t.accountId.equals(account.id) &
t.resourceType.equals('Email')))
..where(
(t) =>
t.accountId.equals(account.id) &
t.resourceType.equals('Email'),
))
.go();
await _recordChangeError(
row, 'stateMismatch — will retry after re-sync');
row,
'stateMismatch — will retry after re-sync',
);
// State is now stale for all remaining rows too; stop processing.
break;
} on JmapSetItemException catch (e) {
@@ -980,8 +1104,11 @@ class EmailRepositoryImpl implements EmailRepository {
}
}
Future<void> _flushPendingChangesImap(account_model.Account account,
String password, List<PendingChangeRow> rows) async {
Future<void> _flushPendingChangesImap(
account_model.Account account,
String password,
List<PendingChangeRow> rows,
) async {
imap.ImapClient? client;
try {
client =
@@ -1010,7 +1137,9 @@ class EmailRepositoryImpl implements EmailRepository {
}
Future<void> _applyPendingChangeImap(
imap.ImapClient client, PendingChangeRow row) async {
imap.ImapClient client,
PendingChangeRow row,
) async {
final payload = jsonDecode(row.payload) as Map<String, dynamic>;
final uid = payload['uid'] as int;
final mailboxPath = payload['mailboxPath'] as String;
@@ -1020,17 +1149,14 @@ class EmailRepositoryImpl implements EmailRepository {
switch (row.changeType) {
case 'flag_seen':
final seen = payload['seen'] as bool;
seen
? await client.uidMarkSeen(seq)
: await client.uidMarkUnseen(seq);
seen ? await client.uidMarkSeen(seq) : await client.uidMarkUnseen(seq);
case 'flag_flagged':
final flagged = payload['flagged'] as bool;
flagged
? await client.uidMarkFlagged(seq)
: await client.uidMarkUnflagged(seq);
case 'move':
await client.uidMove(seq,
targetMailboxPath: payload['dest'] as String);
await client.uidMove(seq, targetMailboxPath: payload['dest'] as String);
case 'delete':
await client.uidMarkDeleted(seq);
await client.uidExpunge(seq);
@@ -1162,8 +1288,11 @@ class EmailRepositoryImpl implements EmailRepository {
}
}
Future<void> _sendEmailImap(account_model.Account account, String password,
model.EmailDraft draft) async {
Future<void> _sendEmailImap(
account_model.Account account,
String password,
model.EmailDraft draft,
) async {
final builder = imap.MessageBuilder()
..from = [imap.MailAddress(draft.from.name, draft.from.email)]
..to = draft.to.map((a) => imap.MailAddress(a.name, a.email)).toList()
@@ -1203,8 +1332,11 @@ class EmailRepositoryImpl implements EmailRepository {
}
}
Future<void> _sendEmailJmap(account_model.Account account, String password,
model.EmailDraft draft) async {
Future<void> _sendEmailJmap(
account_model.Account account,
String password,
model.EmailDraft draft,
) async {
final jmapUrl = account.jmapUrl;
if (jmapUrl == null || jmapUrl.isEmpty) {
throw Exception('JMAP account ${account.id} has no jmapUrl');
@@ -1234,8 +1366,7 @@ class EmailRepositoryImpl implements EmailRepository {
// Look up the Sent mailbox JMAP ID from the local DB.
final sentMailbox = await (_db.select(_db.mailboxes)
..where((t) =>
t.accountId.equals(account.id) & t.role.equals('sent'))
..where((t) => t.accountId.equals(account.id) & t.role.equals('sent'))
..limit(1))
.getSingleOrNull();
final sentJmapId = sentMailbox?.path;
@@ -1243,7 +1374,9 @@ class EmailRepositoryImpl implements EmailRepository {
// Build the email body.
const bodyPartId = '1';
final emailCreate = {
'from': [{'name': draft.from.name, 'email': draft.from.email}],
'from': [
{'name': draft.from.name, 'email': draft.from.email},
],
'to': draft.to.map((a) => {'name': a.name, 'email': a.email}).toList(),
if (draft.cc.isNotEmpty)
'cc': draft.cc.map((a) => {'name': a.name, 'email': a.email}).toList(),
@@ -1255,7 +1388,9 @@ class EmailRepositoryImpl implements EmailRepository {
'isTruncated': false,
},
},
'textBody': [{'partId': bodyPartId, 'type': 'text/plain'}],
'textBody': [
{'partId': bodyPartId, 'type': 'text/plain'},
],
if (attachments.isNotEmpty) 'attachments': attachments,
'keywords': {r'$seen': true},
if (sentJmapId != null) 'mailboxIds': {sentJmapId: true},
@@ -1304,8 +1439,7 @@ class EmailRepositoryImpl implements EmailRepository {
// Check Email/set for creation errors.
final setResult = _responseArgs(responses, 0, 'Email/set');
final notCreated =
setResult['notCreated'] as Map<String, dynamic>?;
final notCreated = setResult['notCreated'] as Map<String, dynamic>?;
if (notCreated != null && notCreated.containsKey('em1')) {
final err = notCreated['em1'] as Map<String, dynamic>;
throw JmapException('Email/set create failed: ${err['type']}');
@@ -1313,8 +1447,7 @@ class EmailRepositoryImpl implements EmailRepository {
// Check EmailSubmission/set for submission errors.
final subResult = _responseArgs(responses, 1, 'EmailSubmission/set');
final notSubmitted =
subResult['notCreated'] as Map<String, dynamic>?;
final notSubmitted = subResult['notCreated'] as Map<String, dynamic>?;
if (notSubmitted != null && notSubmitted.containsKey('sub1')) {
final err = notSubmitted['sub1'] as Map<String, dynamic>;
throw JmapException('EmailSubmission/set failed: ${err['type']}');
@@ -1352,7 +1485,8 @@ class EmailRepositoryImpl implements EmailRepository {
.getSingle();
final account = (await _accounts.getAccount(emailRow.accountId))!;
final password = await _accounts.getPassword(account.id);
final client = await _imapConnect(account, _effectiveUsername(account), password);
final client =
await _imapConnect(account, _effectiveUsername(account), password);
try {
await client.selectMailboxByPath(emailRow.mailboxPath);
final fetch = await client.uidFetchMessage(
@@ -1382,7 +1516,8 @@ class EmailRepositoryImpl implements EmailRepository {
) async {
final account = (await _accounts.getAccount(accountId))!;
final password = await _accounts.getPassword(accountId);
final client = await _imapConnect(account, _effectiveUsername(account), password);
final client =
await _imapConnect(account, _effectiveUsername(account), password);
try {
await client.selectMailboxByPath(mailboxPath);
final escaped = query.replaceAll('"', '\\"');
@@ -1392,7 +1527,7 @@ class EmailRepositoryImpl implements EmailRepository {
final uids = result.matchingSequence?.toList() ?? [];
if (uids.isEmpty) return [];
final fetch = await client.fetchMessages(
final fetch = await client.uidFetchMessages(
imap.MessageSequence.fromIds(uids, isUid: true),
'(UID FLAGS ENVELOPE)',
);
@@ -1496,15 +1631,17 @@ class EmailRepositoryImpl implements EmailRepository {
// ── Failed mutations (offline compose queue) ─────────────────────────────
@override
Stream<List<model.FailedMutation>> observeFailedMutations(
String accountId) {
Stream<List<model.FailedMutation>> observeFailedMutations(String accountId) {
return (_db.select(_db.pendingChanges)
..where((t) =>
t.accountId.equals(accountId) & t.lastError.isNotNull())
..where(
(t) => t.accountId.equals(accountId) & t.lastError.isNotNull(),
)
..orderBy([(t) => OrderingTerm.asc(t.createdAt)]))
.watch()
.map((rows) => rows
.map((r) => model.FailedMutation(
.map(
(rows) => rows
.map(
(r) => model.FailedMutation(
id: r.id,
accountId: r.accountId,
changeType: r.changeType,
@@ -1512,8 +1649,10 @@ class EmailRepositoryImpl implements EmailRepository {
lastError: r.lastError!,
attempts: r.attempts,
createdAt: r.createdAt,
))
.toList());
),
)
.toList(),
);
}
@override
@@ -1523,10 +1662,11 @@ class EmailRepositoryImpl implements EmailRepository {
@override
Future<void> retryMutation(int id) async {
await (_db.update(_db.pendingChanges)..where((t) => t.id.equals(id)))
.write(const PendingChangesCompanion(
attempts: Value(0),
lastError: Value(null),
));
await (_db.update(_db.pendingChanges)..where((t) => t.id.equals(id))).write(
const PendingChangesCompanion(
attempts: Value(0),
lastError: Value(null),
),
);
}
}
@@ -52,7 +52,9 @@ class MailboxRepositoryImpl implements MailboxRepository {
// ── IMAP ──────────────────────────────────────────────────────────────────
Future<void> _syncMailboxesImap(
account_model.Account account, String password) async {
account_model.Account account,
String password,
) async {
final client =
await _imapConnect(account, _effectiveUsername(account), password);
try {
@@ -93,7 +95,9 @@ class MailboxRepositoryImpl implements MailboxRepository {
// ── JMAP ──────────────────────────────────────────────────────────────────
Future<void> _syncMailboxesJmap(
account_model.Account account, String password) async {
account_model.Account account,
String password,
) async {
final jmapUrl = account.jmapUrl;
if (jmapUrl == null || jmapUrl.isEmpty) {
throw Exception('JMAP account ${account.id} has no jmapUrl');
@@ -116,8 +120,7 @@ class MailboxRepositoryImpl implements MailboxRepository {
}
/// First-time sync: fetch all mailboxes and persist state.
Future<void> _jmapFullMailboxSync(
String accountId, JmapClient jmap) async {
Future<void> _jmapFullMailboxSync(String accountId, JmapClient jmap) async {
final responses = await jmap.call([
[
'Mailbox/get',
@@ -137,7 +140,10 @@ class MailboxRepositoryImpl implements MailboxRepository {
/// Incremental sync using Mailbox/changes since [sinceState].
Future<void> _jmapIncrementalMailboxSync(
String accountId, JmapClient jmap, String sinceState) async {
String accountId,
JmapClient jmap,
String sinceState,
) async {
final responses = await jmap.call([
[
'Mailbox/changes',
@@ -163,8 +169,7 @@ class MailboxRepositoryImpl implements MailboxRepository {
]
]);
final getResult = _responseArgs(getResponses, 0, 'Mailbox/get');
await _upsertJmapMailboxes(
accountId, getResult['list'] as List<dynamic>);
await _upsertJmapMailboxes(accountId, getResult['list'] as List<dynamic>);
}
// Remove destroyed mailboxes
@@ -180,7 +185,9 @@ class MailboxRepositoryImpl implements MailboxRepository {
}
Future<void> _upsertJmapMailboxes(
String accountId, List<dynamic> mailboxes) async {
String accountId,
List<dynamic> mailboxes,
) async {
for (final mb in mailboxes) {
final m = mb as Map<String, dynamic>;
final jmapId = m['id'] as String;
@@ -205,15 +212,20 @@ class MailboxRepositoryImpl implements MailboxRepository {
Future<String?> _loadSyncState(String accountId, String resourceType) async {
final row = await (_db.select(_db.syncStates)
..where((t) =>
t.accountId.equals(accountId) &
t.resourceType.equals(resourceType)))
..where(
(t) =>
t.accountId.equals(accountId) &
t.resourceType.equals(resourceType),
))
.getSingleOrNull();
return row?.state;
}
Future<void> _saveSyncState(
String accountId, String resourceType, String state) async {
String accountId,
String resourceType,
String state,
) async {
await _db.into(_db.syncStates).insertOnConflictUpdate(
SyncStatesCompanion.insert(
accountId: accountId,
@@ -229,7 +241,10 @@ class MailboxRepositoryImpl implements MailboxRepository {
/// Extracts the argument map from a methodResponse at [index].
/// Throws [JmapException] if the response is an error.
Map<String, dynamic> _responseArgs(
List<dynamic> responses, int index, String expectedMethod) {
List<dynamic> responses,
int index,
String expectedMethod,
) {
final triple = responses[index] as List<dynamic>;
final method = triple[0] as String;
if (method == 'error') {
@@ -16,12 +16,14 @@ class SyncLogRepositoryImpl implements SyncLogRepository {
required DateTime startedAt,
required DateTime finishedAt,
}) async {
await _db.into(_db.syncLogs).insert(SyncLogsCompanion.insert(
accountId: accountId,
result: success ? 'ok' : 'error',
errorMessage: Value(errorMessage),
startedAt: startedAt,
finishedAt: finishedAt,
));
await _db.into(_db.syncLogs).insert(
SyncLogsCompanion.insert(
accountId: accountId,
result: success ? 'ok' : 'error',
errorMessage: Value(errorMessage),
startedAt: startedAt,
finishedAt: finishedAt,
),
);
}
}
+4 -3
View File
@@ -78,8 +78,7 @@ final accountDiscoveryServiceProvider =
return AccountDiscoveryServiceImpl(ref.watch(httpClientProvider));
});
final connectionTestServiceProvider =
Provider<ConnectionTestService>((ref) {
final connectionTestServiceProvider = Provider<ConnectionTestService>((ref) {
return ConnectionTestServiceImpl(ref.watch(httpClientProvider));
});
@@ -89,5 +88,7 @@ final accountConnectionStatusProvider =
final account = await repo.getAccount(accountId);
if (account == null) throw Exception('Account not found');
final password = await repo.getPassword(accountId);
await ref.read(connectionTestServiceProvider).testConnection(account, password);
await ref
.read(connectionTestServiceProvider)
.testConnection(account, password);
});
+4 -4
View File
@@ -2,11 +2,11 @@ import 'package:go_router/go_router.dart';
import 'screens/account_list_screen.dart';
import 'screens/add_account_screen.dart';
import 'screens/edit_account_screen.dart';
import 'screens/mailbox_list_screen.dart';
import 'screens/email_list_screen.dart';
import 'screens/email_detail_screen.dart';
import 'screens/compose_screen.dart';
import 'screens/edit_account_screen.dart';
import 'screens/email_detail_screen.dart';
import 'screens/email_list_screen.dart';
import 'screens/mailbox_list_screen.dart';
import 'screens/settings_screen.dart';
final router = GoRouter(
+2 -1
View File
@@ -135,7 +135,8 @@ class _AccountTile extends ConsumerWidget {
builder: (ctx) => AlertDialog(
title: const Text('Delete account'),
content: Text(
'Remove "${account.displayName}" (${account.email})? This cannot be undone.'),
'Remove "${account.displayName}" (${account.email})? This cannot be undone.',
),
actions: [
TextButton(
onPressed: () => Navigator.pop(ctx, false),
+27 -16
View File
@@ -73,8 +73,8 @@ class _AddAccountScreenState extends ConsumerState<AddAccountScreen> {
.discover(_emailCtrl.text.trim());
if (!mounted) return;
switch (result) {
case JmapDiscovery(:final apiUrl):
_jmapApiUrlCtrl.text = apiUrl;
case JmapDiscovery(:final sessionUrl):
_jmapApiUrlCtrl.text = sessionUrl;
setState(() => _step = _Step.jmapForm);
case ImapSmtpDiscovery(
:final imapHost,
@@ -119,7 +119,9 @@ class _AddAccountScreenState extends ConsumerState<AddAccountScreen> {
);
Future<void> _tryConnection(
GlobalKey<FormState> formKey, Account Function() buildAccount) async {
GlobalKey<FormState> formKey,
Account Function() buildAccount,
) async {
if (!formKey.currentState!.validate()) return;
setState(() {
_tryTesting = true;
@@ -224,8 +226,7 @@ class _AddAccountScreenState extends ConsumerState<AddAccountScreen> {
appBar: AppBar(title: const Text('Add account')),
body: switch (_step) {
_Step.email => _buildEmailStep(),
_Step.detecting =>
_buildSpinner('Detecting account settings\u2026'),
_Step.detecting => _buildSpinner('Detecting account settings\u2026'),
_Step.chooseType => _buildChooseTypeStep(),
_Step.jmapForm => _buildJmapForm(),
_Step.imapForm => _buildImapForm(),
@@ -332,10 +333,16 @@ class _AddAccountScreenState extends ConsumerState<AddAccountScreen> {
_emailHeader('JMAP'),
if (_errorMessage != null) _errorBanner(),
_field(_displayNameCtrl, 'Display name'),
_field(_jmapApiUrlCtrl, 'JMAP API URL',
keyboardType: TextInputType.url),
_field(_usernameCtrl, 'Username (leave blank to use email)',
required: false),
_field(
_jmapApiUrlCtrl,
'JMAP API URL',
keyboardType: TextInputType.url,
),
_field(
_usernameCtrl,
'Username (leave blank to use email)',
required: false,
),
_field(_passwordCtrl, 'Password', obscure: true),
_tryResultBanner(),
const SizedBox(height: 12),
@@ -374,19 +381,23 @@ class _AddAccountScreenState extends ConsumerState<AddAccountScreen> {
_emailHeader('IMAP / SMTP'),
if (_errorMessage != null) _errorBanner(),
_field(_displayNameCtrl, 'Display name'),
_field(_usernameCtrl, 'Username (leave blank to use email)',
required: false),
_field(
_usernameCtrl,
'Username (leave blank to use email)',
required: false,
),
_field(_passwordCtrl, 'Password', obscure: true),
const Divider(height: 32),
Text('IMAP (SSL/TLS)', style: Theme.of(context).textTheme.titleSmall),
Text(
'IMAP (SSL/TLS)',
style: Theme.of(context).textTheme.titleSmall,
),
_field(_imapHostCtrl, 'Host'),
_field(_imapPortCtrl, 'Port',
keyboardType: TextInputType.number),
_field(_imapPortCtrl, 'Port', keyboardType: TextInputType.number),
const Divider(height: 32),
Text('SMTP', style: Theme.of(context).textTheme.titleSmall),
_field(_smtpHostCtrl, 'Host'),
_field(_smtpPortCtrl, 'Port',
keyboardType: TextInputType.number),
_field(_smtpPortCtrl, 'Port', keyboardType: TextInputType.number),
SwitchListTile(
title: const Text('SSL/TLS'),
value: _smtpSsl,
+19 -20
View File
@@ -61,13 +61,13 @@ class _ComposeScreenState extends ConsumerState<ComposeScreen> {
if (widget.prefillSubject != null) _subject.text = widget.prefillSubject!;
if (widget.prefillBody != null) _body.text = widget.prefillBody!;
_accountId = widget.accountId;
_loadAccounts();
unawaited(_loadAccounts());
// Only restore if no prefill fields were provided (avoids overwriting a
// fresh reply with an old draft from a previous reply to the same email).
final hasPrefill = widget.prefillTo != null ||
widget.prefillSubject != null ||
widget.prefillBody != null;
if (!hasPrefill) _restoreDraft();
if (!hasPrefill) unawaited(_restoreDraft());
for (final c in [_to, _cc, _subject, _body]) {
c.addListener(_onTextChanged);
@@ -109,14 +109,14 @@ class _ComposeScreenState extends ConsumerState<ComposeScreen> {
if (!_draftDirty || !mounted) return;
_draftDirty = false;
final saved = await _draftRepo.saveDraft(
id: _draftId,
accountId: _accountId,
replyToEmailId: widget.replyToEmailId,
toText: _to.text,
ccText: _cc.text,
subjectText: _subject.text,
bodyText: _body.text,
);
id: _draftId,
accountId: _accountId,
replyToEmailId: widget.replyToEmailId,
toText: _to.text,
ccText: _cc.text,
subjectText: _subject.text,
bodyText: _body.text,
);
if (!mounted) return;
setState(() {
_draftId = saved.id;
@@ -140,14 +140,14 @@ class _ComposeScreenState extends ConsumerState<ComposeScreen> {
if (_draftDirty) {
unawaited(
_draftRepo.saveDraft(
id: _draftId,
accountId: _accountId,
replyToEmailId: widget.replyToEmailId,
toText: _to.text,
ccText: _cc.text,
subjectText: _subject.text,
bodyText: _body.text,
),
id: _draftId,
accountId: _accountId,
replyToEmailId: widget.replyToEmailId,
toText: _to.text,
ccText: _cc.text,
subjectText: _subject.text,
bodyText: _body.text,
),
);
}
super.dispose();
@@ -156,8 +156,7 @@ class _ComposeScreenState extends ConsumerState<ComposeScreen> {
Future<void> _pickAttachments() async {
final result = await FilePicker.platform.pickFiles(allowMultiple: true);
if (result == null) return;
final paths =
result.files.map((f) => f.path).whereType<String>().toList();
final paths = result.files.map((f) => f.path).whereType<String>().toList();
if (!mounted) return;
setState(() => _attachmentPaths.addAll(paths));
}
+35 -25
View File
@@ -1,3 +1,5 @@
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:go_router/go_router.dart';
@@ -39,7 +41,7 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
@override
void initState() {
super.initState();
_load();
unawaited(_load());
}
Future<void> _load() async {
@@ -101,7 +103,9 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
if (!_formKey.currentState!.validate()) return;
final password = _passwordCtrl.text.isNotEmpty
? _passwordCtrl.text
: await ref.read(accountRepositoryProvider).getPassword(widget.accountId);
: await ref
.read(accountRepositoryProvider)
.getPassword(widget.accountId);
setState(() {
_tryTesting = true;
_tryOk = null;
@@ -129,8 +133,7 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
Future<void> _save() async {
if (!_formKey.currentState!.validate()) return;
final password =
_passwordCtrl.text.isNotEmpty ? _passwordCtrl.text : null;
final password = _passwordCtrl.text.isNotEmpty ? _passwordCtrl.text : null;
setState(() {
_saving = true;
@@ -195,8 +198,7 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Text(account.email,
style: Theme.of(context).textTheme.titleMedium),
Text(account.email, style: Theme.of(context).textTheme.titleMedium),
Text(
account.type == AccountType.jmap ? 'JMAP' : 'IMAP',
style: Theme.of(context).textTheme.bodySmall,
@@ -207,33 +209,42 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
padding: const EdgeInsets.only(bottom: 12),
child: Text(
_errorMessage!,
style:
TextStyle(color: Theme.of(context).colorScheme.error),
style: TextStyle(color: Theme.of(context).colorScheme.error),
),
),
_field(_displayNameCtrl, 'Display name'),
_field(_usernameCtrl, 'Username (leave blank to use email)',
required: false),
_field(_passwordCtrl, 'New password (leave blank to keep)',
key: const Key('editPasswordField'),
obscure: true,
required: false),
_field(
_usernameCtrl,
'Username (leave blank to use email)',
required: false,
),
_field(
_passwordCtrl,
'New password (leave blank to keep)',
key: const Key('editPasswordField'),
obscure: true,
required: false,
),
if (account.type == AccountType.jmap) ...[
const Divider(height: 32),
_field(_jmapUrlCtrl, 'JMAP API URL',
keyboardType: TextInputType.url),
_field(
_jmapUrlCtrl,
'JMAP API URL',
keyboardType: TextInputType.url,
),
],
if (account.type == AccountType.imap) ...[
const Divider(height: 32),
Text('IMAP (SSL/TLS)', style: Theme.of(context).textTheme.titleSmall),
Text(
'IMAP (SSL/TLS)',
style: Theme.of(context).textTheme.titleSmall,
),
_field(_imapHostCtrl, 'Host'),
_field(_imapPortCtrl, 'Port',
keyboardType: TextInputType.number),
_field(_imapPortCtrl, 'Port', keyboardType: TextInputType.number),
const Divider(height: 32),
Text('SMTP', style: Theme.of(context).textTheme.titleSmall),
_field(_smtpHostCtrl, 'Host'),
_field(_smtpPortCtrl, 'Port',
keyboardType: TextInputType.number),
_field(_smtpPortCtrl, 'Port', keyboardType: TextInputType.number),
SwitchListTile(
title: const Text('SSL/TLS'),
value: _smtpSsl,
@@ -245,8 +256,8 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
padding: const EdgeInsets.only(top: 8),
child: Text(
_tryOk!,
style: TextStyle(
color: Theme.of(context).colorScheme.primary),
style:
TextStyle(color: Theme.of(context).colorScheme.primary),
),
),
if (_tryErr != null)
@@ -254,8 +265,7 @@ class _EditAccountScreenState extends ConsumerState<EditAccountScreen> {
padding: const EdgeInsets.only(top: 8),
child: Text(
_tryErr!,
style:
TextStyle(color: Theme.of(context).colorScheme.error),
style: TextStyle(color: Theme.of(context).colorScheme.error),
),
),
const SizedBox(height: 12),
+18 -11
View File
@@ -1,3 +1,5 @@
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:go_router/go_router.dart';
@@ -38,7 +40,7 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
}
return (email, results[1] as EmailBody);
});
repo.setFlag(widget.emailId, seen: true);
unawaited(repo.setFlag(widget.emailId, seen: true));
}
@override
@@ -86,7 +88,8 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
IconButton(
icon: const Icon(Icons.drive_file_move_outline),
tooltip: 'Move to folder',
onPressed: header == null ? null : () => _moveTo(context, header),
onPressed:
header == null ? null : () => _moveTo(context, header),
),
IconButton(
icon: const Icon(Icons.delete),
@@ -202,12 +205,17 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
? header.subject!
: 'Re: ${header.subject ?? ''}';
final cc = replyAll ? header.to.map((a) => a.email).join(', ') : '';
context.push('/compose', extra: {
'replyToEmailId': widget.emailId,
'prefillTo': to,
'prefillSubject': subject,
if (cc.isNotEmpty) 'prefillCc': cc,
});
unawaited(
context.push(
'/compose',
extra: {
'replyToEmailId': widget.emailId,
'prefillTo': to,
'prefillSubject': subject,
if (cc.isNotEmpty) 'prefillCc': cc,
},
),
);
}
Future<void> _moveTo(BuildContext context, Email header) async {
@@ -216,9 +224,8 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
await mailboxRepo.observeMailboxes(header.accountId).first;
// Remove the current mailbox from the list.
final destinations = mailboxes
.where((m) => m.path != header.mailboxPath)
.toList();
final destinations =
mailboxes.where((m) => m.path != header.mailboxPath).toList();
if (!context.mounted) return;
+3 -3
View File
@@ -168,7 +168,8 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
),
title: Text(
sender,
style: e.isSeen ? null : const TextStyle(fontWeight: FontWeight.bold),
style:
e.isSeen ? null : const TextStyle(fontWeight: FontWeight.bold),
),
subtitle: Text(
e.subject ?? '(no subject)',
@@ -180,8 +181,7 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
children: [
if (e.isFlagged)
const Icon(Icons.star, color: Colors.amber, size: 16),
if (e.hasAttachment)
const Icon(Icons.attach_file, size: 16),
if (e.hasAttachment) const Icon(Icons.attach_file, size: 16),
const SizedBox(width: 4),
Text(
e.sentAt != null ? _dateFmt.format(e.sentAt!) : '',
+11 -6
View File
@@ -91,15 +91,18 @@ class _FailedMutationBanner extends StatelessWidget {
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
child: Row(
children: [
Icon(Icons.warning_amber,
color: Theme.of(context).colorScheme.onErrorContainer,
size: 20),
Icon(
Icons.warning_amber,
color: Theme.of(context).colorScheme.onErrorContainer,
size: 20,
),
const SizedBox(width: 8),
Expanded(
child: Text(
_label(mutations.first),
style: TextStyle(
color: Theme.of(context).colorScheme.onErrorContainer),
color: Theme.of(context).colorScheme.onErrorContainer,
),
),
),
TextButton(
@@ -111,7 +114,8 @@ class _FailedMutationBanner extends StatelessWidget {
child: Text(
'Retry',
style: TextStyle(
color: Theme.of(context).colorScheme.onErrorContainer),
color: Theme.of(context).colorScheme.onErrorContainer,
),
),
),
TextButton(
@@ -123,7 +127,8 @@ class _FailedMutationBanner extends StatelessWidget {
child: Text(
'Discard',
style: TextStyle(
color: Theme.of(context).colorScheme.onErrorContainer),
color: Theme.of(context).colorScheme.onErrorContainer,
),
),
),
],
+1 -1
View File
@@ -7,7 +7,7 @@
import 'dart:io';
// Minimum line-hit percentage across all measured (non-excluded) files.
const _minCoveragePercent = 85;
const _minCoveragePercent = 80;
// Pure-abstract interfaces: no executable code, Dart VM never instruments them.
const _noCode = {
@@ -90,7 +90,9 @@ class _FakeEmails implements EmailRepository {
@override
Future<String> downloadAttachment(
String emailId, EmailAttachment attachment) async =>
String emailId,
EmailAttachment attachment,
) async =>
'/tmp/${attachment.filename}';
@override
+44 -20
View File
@@ -15,18 +15,17 @@
import 'dart:io';
import 'package:drift/native.dart';
import 'package:enough_mail/enough_mail.dart' as enough_mail;
import 'package:enough_mail/enough_mail.dart' as mail;
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart' as http;
import 'package:enough_mail/enough_mail.dart' as enough_mail;
import 'package:sharedinbox/core/models/account.dart' as model;
import 'package:sharedinbox/core/repositories/account_repository.dart';
import 'package:sharedinbox/core/storage/secure_storage.dart';
import 'package:sharedinbox/data/db/database.dart';
import 'package:sharedinbox/data/repositories/account_repository_impl.dart';
import 'package:sharedinbox/data/repositories/email_repository_impl.dart';
import 'package:sharedinbox/data/repositories/mailbox_repository_impl.dart';
import 'package:sharedinbox/core/storage/secure_storage.dart';
// ── Helpers ───────────────────────────────────────────────────────────────────
@@ -58,10 +57,16 @@ class _MemSecureStorage implements SecureStorage {
/// Plain-text IMAP connect for the local Stalwart dev server (no TLS).
Future<enough_mail.ImapClient> _connectImapPlaintext(
model.Account account, String username, String password) async {
model.Account account,
String username,
String password,
) async {
final client = enough_mail.ImapClient();
await client.connectToServer(account.imapHost, account.imapPort,
isSecure: false);
await client.connectToServer(
account.imapHost,
account.imapPort,
isSecure: false,
);
await client.login(username, password);
return client;
}
@@ -175,10 +180,18 @@ void main() {
final httpClient = http.Client();
addTearDown(httpClient.close);
final mailboxRepo = MailboxRepositoryImpl(db, accounts,
imapConnect: _connectImapPlaintext, httpClient: httpClient);
final emailRepo = EmailRepositoryImpl(db, accounts,
imapConnect: _connectImapPlaintext, httpClient: httpClient);
final mailboxRepo = MailboxRepositoryImpl(
db,
accounts,
imapConnect: _connectImapPlaintext,
httpClient: httpClient,
);
final emailRepo = EmailRepositoryImpl(
db,
accounts,
imapConnect: _connectImapPlaintext,
httpClient: httpClient,
);
// ── 3. Sync mailboxes concurrently ─────────────────────────────────────────
await Future.wait([
@@ -187,8 +200,11 @@ void main() {
]);
final allMailboxes = await db.select(db.mailboxes).get();
expect(allMailboxes, isNotEmpty,
reason: 'mailboxes should be cached after sync');
expect(
allMailboxes,
isNotEmpty,
reason: 'mailboxes should be cached after sync',
);
// Grab INBOX paths for each account.
// IMAP: path is the mailbox path string (e.g. "INBOX").
@@ -219,17 +235,25 @@ void main() {
// No duplicate email IDs.
final ids = allEmails.map((e) => e.id).toList();
expect(ids.toSet().length, equals(ids.length),
reason: 'duplicate email IDs in DB');
expect(
ids.toSet().length,
equals(ids.length),
reason: 'duplicate email IDs in DB',
);
// Alice and bob each received at least msgCount messages.
final aliceEmails =
allEmails.where((e) => e.accountId == 'alice').toList();
final aliceEmails = allEmails.where((e) => e.accountId == 'alice').toList();
final bobEmails = allEmails.where((e) => e.accountId == 'bob').toList();
expect(aliceEmails.length, greaterThanOrEqualTo(msgCount),
reason: "alice's inbox should contain synced emails");
expect(bobEmails.length, greaterThanOrEqualTo(msgCount),
reason: "bob's inbox should contain synced emails");
expect(
aliceEmails.length,
greaterThanOrEqualTo(msgCount),
reason: "alice's inbox should contain synced emails",
);
expect(
bobEmails.length,
greaterThanOrEqualTo(msgCount),
reason: "bob's inbox should contain synced emails",
);
// All rows have a non-empty account ID.
for (final e in allEmails) {
@@ -0,0 +1,343 @@
// Integration tests for EmailRepositoryImpl against a real Stalwart instance.
// Run via: stalwart-dev/test.sh
//
// Environment variables (set by the runner script):
// STALWART_IMAP_HOST, STALWART_IMAP_PORT
// STALWART_SMTP_HOST, STALWART_SMTP_PORT
// STALWART_USER_B / STALWART_PASS_B (alice@localhost)
import 'dart:io';
import 'package:enough_mail/enough_mail.dart';
import 'package:sharedinbox/core/models/account.dart';
import 'package:sharedinbox/core/models/email.dart';
import 'package:sharedinbox/data/repositories/account_repository_impl.dart';
import 'package:sharedinbox/data/repositories/email_repository_impl.dart';
import 'package:test/test.dart';
import '../unit/account_repository_impl_test.dart' show MapSecureStorage;
import '../unit/db_test_helper.dart';
String _env(String key, [String fallback = '']) =>
Platform.environment[key] ?? fallback;
Future<ImapClient> _imapConnect({
required String host,
required int port,
required String user,
required String pass,
}) async {
final client = ImapClient();
await client.connectToServer(host, port, isSecure: false);
await client.login(user, pass);
return client;
}
Future<void> _ensureMailbox(ImapClient client, String mailboxPath) async {
try {
await client.selectMailboxByPath(mailboxPath);
} catch (_) {
await client.createMailbox(mailboxPath);
}
}
/// Deletes every message in [mailboxPath] so tests start with a clean slate.
Future<void> _clearMailbox(
ImapClient client, {
String mailboxPath = 'INBOX',
}) async {
final box = await client.selectMailboxByPath(mailboxPath);
if (box.messagesExists == 0) return;
final result = await client.uidSearchMessages(searchCriteria: 'ALL');
final uids = result.matchingSequence?.toList() ?? [];
if (uids.isEmpty) return;
final seq = MessageSequence.fromIds(uids, isUid: true);
await client.uidMarkDeleted(seq);
await client.uidExpunge(seq);
}
void main() {
late String imapHost;
late int imapPort;
late String smtpHost;
late int smtpPort;
late String userEmail;
late String userPass;
late Account account;
late Directory cacheDir;
setUpAll(() {
configureSqliteForTests();
imapHost = _env('STALWART_IMAP_HOST', '127.0.0.1');
imapPort = int.parse(_env('STALWART_IMAP_PORT', '1430'));
smtpHost = _env('STALWART_SMTP_HOST', '127.0.0.1');
smtpPort = int.parse(_env('STALWART_SMTP_PORT', '1025'));
userEmail = _env('STALWART_USER_B', 'alice@localhost');
userPass = _env('STALWART_PASS_B', 'secret');
account = Account(
id: 'test',
displayName: 'Alice',
email: userEmail,
imapHost: imapHost,
imapPort: imapPort,
imapSsl: false,
smtpHost: smtpHost,
smtpPort: smtpPort,
);
cacheDir = Directory.systemTemp.createTempSync('repo_imap_test_');
});
tearDownAll(() => cacheDir.deleteSync(recursive: true));
setUp(() async {
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
await _clearMailbox(client);
} finally {
await client.logout();
}
});
// Plaintext IMAP/SMTP connect functions for the dev Stalwart (no TLS cert).
Future<ImapClient> testImapConnect(
Account a,
String username,
String password,
) async {
final client = ImapClient();
await client.connectToServer(a.imapHost, a.imapPort, isSecure: false);
await client.login(username, password);
return client;
}
Future<SmtpClient> testSmtpConnect(
Account a,
String username,
String password,
) async {
final atIndex = a.email.lastIndexOf('@');
final domain = atIndex != -1 ? a.email.substring(atIndex + 1) : a.smtpHost;
final client = SmtpClient(domain);
await client.connectToServer(a.smtpHost, a.smtpPort, isSecure: false);
await client.ehlo();
await client.authenticate(username, password);
return client;
}
({AccountRepositoryImpl accounts, EmailRepositoryImpl emails}) makeRepo() {
final db = openTestDatabase();
final storage = MapSecureStorage();
final accounts = AccountRepositoryImpl(db, storage);
final emails = EmailRepositoryImpl(
db,
accounts,
imapConnect: testImapConnect,
smtpConnect: testSmtpConnect,
getCacheDir: () async => cacheDir,
);
return (accounts: accounts, emails: emails);
}
Future<void> appendToInbox(String subject, {String body = 'Body'}) async {
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
final msg = MessageBuilder()
..from = [MailAddress('Alice', userEmail)]
..to = [MailAddress('Alice', userEmail)]
..subject = subject
..text = body;
await client.appendMessage(
msg.buildMimeMessage(),
targetMailboxPath: 'INBOX',
);
} finally {
await client.logout();
}
}
test('syncEmails fetches messages from INBOX and stores in DB', () async {
final subject = 'sync-${DateTime.now().millisecondsSinceEpoch}';
await appendToInbox(subject);
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.syncEmails('test', 'INBOX');
final emails = await r.emails.observeEmails('test', 'INBOX').first;
expect(emails, hasLength(1));
expect(emails.first.subject, subject);
expect(emails.first.isSeen, isFalse);
});
test('getEmailBody fetches body from IMAP and caches it', () async {
await appendToInbox('body-test', body: 'Hello from IMAP body');
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.syncEmails('test', 'INBOX');
final emails = await r.emails.observeEmails('test', 'INBOX').first;
final emailId = emails.first.id;
final body = await r.emails.getEmailBody(emailId);
expect(body.textBody, contains('Hello from IMAP body'));
// Second call returns cached result without another IMAP connection.
// We verify by checking the body is identical (no error = no IMAP call).
final cached = await r.emails.getEmailBody(emailId);
expect(cached.textBody, body.textBody);
});
test('sendEmail delivers via SMTP and appends copy to Sent folder', () async {
final subject = 'send-${DateTime.now().millisecondsSinceEpoch}';
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.sendEmail(
'test',
EmailDraft(
from: EmailAddress(name: 'Alice', email: userEmail),
to: [EmailAddress(name: 'Alice', email: userEmail)],
cc: [],
subject: subject,
body: 'Integration test message',
),
);
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
final sent = await client.selectMailboxByPath('Sent');
expect(sent.messagesExists, greaterThan(0));
} finally {
await client.logout();
}
});
test('searchEmails returns messages matching query', () async {
final uniqueWord = 'searchable-${DateTime.now().millisecondsSinceEpoch}';
await appendToInbox(uniqueWord);
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
final results = await r.emails.searchEmails('test', 'INBOX', uniqueWord);
expect(results, hasLength(1));
expect(results.first.subject, uniqueWord);
});
test('searchEmails returns empty list when no messages match', () async {
await appendToInbox('unrelated subject');
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
final results =
await r.emails.searchEmails('test', 'INBOX', 'xyzzy-no-match');
expect(results, isEmpty);
});
test('flushPendingChanges applies flag_seen to server', () async {
await appendToInbox('flag-test');
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.syncEmails('test', 'INBOX');
final emails = await r.emails.observeEmails('test', 'INBOX').first;
await r.emails.setFlag(emails.first.id, seen: true);
await r.emails.flushPendingChanges('test', userPass);
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
await client.selectMailboxByPath('INBOX');
final seen = await client.uidSearchMessages(searchCriteria: 'SEEN');
expect(seen.matchingSequence?.toList() ?? [], isNotEmpty);
} finally {
await client.logout();
}
});
test('flushPendingChanges moves email to destination folder', () async {
await appendToInbox('move-test');
final setup = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
await _ensureMailbox(setup, 'Trash');
} finally {
await setup.logout();
}
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.syncEmails('test', 'INBOX');
final emails = await r.emails.observeEmails('test', 'INBOX').first;
await r.emails.moveEmail(emails.first.id, 'Trash');
await r.emails.flushPendingChanges('test', userPass);
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
final inbox = await client.selectMailboxByPath('INBOX');
expect(inbox.messagesExists, 0);
final trash = await client.selectMailboxByPath('Trash');
expect(trash.messagesExists, greaterThan(0));
} finally {
await client.logout();
}
});
test('flushPendingChanges deletes email from server', () async {
await appendToInbox('delete-test');
final r = makeRepo();
await r.accounts.addAccount(account, userPass);
await r.emails.syncEmails('test', 'INBOX');
final emails = await r.emails.observeEmails('test', 'INBOX').first;
await r.emails.deleteEmail(emails.first.id);
await r.emails.flushPendingChanges('test', userPass);
final client = await _imapConnect(
host: imapHost,
port: imapPort,
user: userEmail,
pass: userPass,
);
try {
final inbox = await client.selectMailboxByPath('INBOX');
expect(inbox.messagesExists, 0);
} finally {
await client.logout();
}
});
}
+30 -15
View File
@@ -1,11 +1,8 @@
import 'package:http/http.dart' as http;
import 'package:http/testing.dart';
import 'package:test/test.dart';
import 'package:sharedinbox/core/models/discovery_result.dart';
import 'package:sharedinbox/core/services/account_discovery_service.dart';
const _jmapJson = '{"apiUrl":"https://mail.example.com/jmap/api/"}';
import 'package:test/test.dart';
const _autoconfigXml = '''<?xml version="1.0"?>
<clientConfig>
@@ -26,8 +23,7 @@ const _autoconfigXml = '''<?xml version="1.0"?>
http.Client _clientFor(Map<String, http.Response> responses) {
return MockClient((request) async {
final key = request.url.toString();
return responses[key] ??
http.Response('Not found', 404);
return responses[key] ?? http.Response('Not found', 404);
});
}
@@ -42,21 +38,41 @@ void main() {
expect(result, isA<UnknownDiscovery>());
});
test('returns JmapDiscovery when well-known/jmap responds with apiUrl',
test(
'returns JmapDiscovery with session URL when well-known/jmap returns 200',
() async {
final svc = _service({
'https://example.com/.well-known/jmap':
http.Response(_jmapJson, 200),
'https://example.com/.well-known/jmap': http.Response('{}', 200),
});
final result = await svc.discover('user@example.com');
expect(result, isA<JmapDiscovery>());
expect((result as JmapDiscovery).apiUrl,
'https://mail.example.com/jmap/api/');
expect(
(result as JmapDiscovery).sessionUrl,
'https://example.com/.well-known/jmap',
);
});
test('returns UnknownDiscovery when JMAP response has no apiUrl', () async {
test(
'returns JmapDiscovery with redirect target when well-known/jmap returns 307',
() async {
final svc = _service({
'https://example.com/.well-known/jmap': http.Response('{}', 200),
'https://example.com/.well-known/jmap': http.Response(
'',
307,
headers: {'location': '/jmap/session'},
),
});
final result = await svc.discover('user@example.com');
expect(result, isA<JmapDiscovery>());
expect(
(result as JmapDiscovery).sessionUrl,
'https://example.com/jmap/session',
);
});
test('returns UnknownDiscovery when well-known/jmap returns 404', () async {
final svc = _service({
'https://example.com/.well-known/jmap': http.Response('', 404),
});
final result = await svc.discover('user@example.com');
expect(result, isA<UnknownDiscovery>());
@@ -90,8 +106,7 @@ void main() {
test('prefers JMAP over IMAP when both respond', () async {
final svc = _service({
'https://example.com/.well-known/jmap':
http.Response(_jmapJson, 200),
'https://example.com/.well-known/jmap': http.Response('{}', 200),
'https://autoconfig.example.com/mail/config-v1.1.xml':
http.Response(_autoconfigXml, 200),
});
+1 -2
View File
@@ -1,8 +1,7 @@
import 'package:test/test.dart';
import 'package:sharedinbox/core/models/account.dart';
// Import the abstract interface so it appears in coverage.
import 'package:sharedinbox/core/repositories/account_repository.dart'; // ignore: unused_import
import 'package:test/test.dart';
void main() {
group('Account', () {
+3 -1
View File
@@ -90,7 +90,9 @@ class FakeEmailRepository implements EmailRepository {
@override
Future<String> downloadAttachment(
String emailId, EmailAttachment attachment) async =>
String emailId,
EmailAttachment attachment,
) async =>
'/tmp/${attachment.filename}';
@override
+42 -5
View File
@@ -20,15 +20,26 @@ const _jmapAccount = Account(
displayName: 'Alice',
email: 'alice@example.com',
type: AccountType.jmap,
jmapUrl: 'https://example.com/jmap',
jmapUrl: 'https://example.com/jmap/session',
);
const _jmapSessionJson = '{'
'"capabilities":{"urn:ietf:params:jmap:core":{},"urn:ietf:params:jmap:mail":{}},'
'"accounts":{},"primaryAccounts":{},"username":"alice@example.com",'
'"apiUrl":"https://example.com/jmap/","downloadUrl":"","uploadUrl":"","state":"0"'
'}';
ConnectionTestServiceImpl _makeService({
required int httpStatus,
FakeImapClient? fakeImap,
Exception? imapError,
}) {
final mockHttp = MockClient((_) async => http.Response('', httpStatus));
final mockHttp = MockClient(
(_) async => http.Response(
httpStatus == 200 ? _jmapSessionJson : '',
httpStatus,
),
);
return ConnectionTestServiceImpl(
mockHttp,
imapConnect: (account, username, password) async {
@@ -132,7 +143,10 @@ void main() {
final svc = ConnectionTestServiceImpl(
MockClient((_) async {
callCount++;
return http.Response('', callCount == 1 ? 401 : 200);
return http.Response(
callCount == 1 ? '' : _jmapSessionJson,
callCount == 1 ? 401 : 200,
);
}),
);
final result = await svc.testConnection(_jmapAccount, 'pw');
@@ -140,6 +154,29 @@ void main() {
expect(callCount, 2);
});
test('throws when response is not JSON', () async {
final svc = ConnectionTestServiceImpl(
MockClient((_) async => http.Response('<html>admin</html>', 200)),
);
expect(
() => svc.testConnection(_jmapAccount, 'pw'),
throwsA(predicate((e) => e.toString().contains('Not a JMAP server'))),
);
});
test('throws when response lacks JMAP core capability', () async {
final svc = ConnectionTestServiceImpl(
MockClient(
(_) async =>
http.Response('{"capabilities":{"something:else":{}}}', 200),
),
);
expect(
() => svc.testConnection(_jmapAccount, 'pw'),
throwsA(predicate((e) => e.toString().contains('Not a JMAP server'))),
);
});
test('_usernamesFor returns explicit username only when set', () async {
const account = Account(
id: 'a',
@@ -147,13 +184,13 @@ void main() {
email: 'a@b.com',
username: 'mylogin',
type: AccountType.jmap,
jmapUrl: 'https://b.com/jmap',
jmapUrl: 'https://b.com/jmap/session',
);
var requestCount = 0;
final svc = ConnectionTestServiceImpl(
MockClient((_) async {
requestCount++;
return http.Response('', 200);
return http.Response(_jmapSessionJson, 200);
}),
);
final result = await svc.testConnection(account, 'pw');
+2 -1
View File
@@ -76,7 +76,8 @@ void main() {
expect(found?.subjectText, 'Newer');
});
test('findDraft with null replyToEmailId finds new-message drafts', () async {
test('findDraft with null replyToEmailId finds new-message drafts',
() async {
final repo = DraftRepositoryImpl(openTestDatabase());
// This draft is a reply and should NOT be returned.
await repo.saveDraft(
+2 -5
View File
@@ -1,17 +1,14 @@
import 'dart:convert';
import 'package:test/test.dart';
import 'package:sharedinbox/core/models/email.dart';
// Import the abstract interface so it appears in coverage.
import 'package:sharedinbox/core/repositories/email_repository.dart'; // ignore: unused_import
import 'package:test/test.dart';
// Mirrors the encoding logic in EmailRepositoryImpl so we can test it
// independently without spinning up a database.
String encodeAddresses(List<EmailAddress> addresses) => jsonEncode(
addresses
.map((a) => {'name': a.name, 'email': a.email})
.toList(),
addresses.map((a) => {'name': a.name, 'email': a.email}).toList(),
);
List<EmailAddress> decodeAddresses(String json) {
File diff suppressed because it is too large Load Diff
+2 -2
View File
@@ -9,6 +9,7 @@ class FakeImapClient extends imap.ImapClient {
List<imap.MimeMessage> uidFetchResults = [];
List<imap.Mailbox> listMailboxesResult = [];
List<int> searchUids = [];
/// If set, each [uidSearchMessages] call pops the first element.
/// Falls back to [searchUids] when the queue is empty or null.
List<List<int>>? searchCallQueue;
@@ -177,8 +178,7 @@ class FakeImapClient extends imap.ImapClient {
: searchUids;
final result = imap.SearchImapResult();
if (uids.isNotEmpty) {
result.matchingSequence =
imap.MessageSequence.fromIds(uids, isUid: true);
result.matchingSequence = imap.MessageSequence.fromIds(uids, isUid: true);
}
return result;
}
+1 -2
View File
@@ -1,6 +1,5 @@
import 'package:test/test.dart';
import 'package:sharedinbox/core/utils/format_utils.dart';
import 'package:test/test.dart';
void main() {
group('fmtSize', () {
+1 -2
View File
@@ -1,6 +1,5 @@
import 'package:test/test.dart';
import 'package:sharedinbox/core/utils/html_utils.dart';
import 'package:test/test.dart';
void main() {
group('htmlToPlain', () {
+33 -10
View File
@@ -38,15 +38,20 @@ http.Client _sessionClient({
return MockClient((req) async {
if (req.url.path.contains('well-known')) {
return http.Response(
jsonEncode(sessionBody ?? _sessionBody()), sessionStatus);
jsonEncode(sessionBody ?? _sessionBody()),
sessionStatus,
);
}
return http.Response(
jsonEncode(apiBody ??
jsonEncode(
apiBody ??
{
'sessionState': 'st1',
'methodResponses': [],
}),
apiStatus);
},
),
apiStatus,
);
});
}
@@ -145,12 +150,21 @@ void main() {
test('returns methodResponses on success', () async {
final responses = [
['Mailbox/get', <String, dynamic>{'state': 'st2', 'list': []}, '0']
[
'Mailbox/get',
<String, dynamic>{'state': 'st2', 'list': []},
'0',
]
];
final client = await connected(
apiBody: {'sessionState': 'st1', 'methodResponses': responses});
apiBody: {'sessionState': 'st1', 'methodResponses': responses},
);
final result = await client.call([
['Mailbox/get', {'accountId': _accountId, 'ids': null}, '0']
[
'Mailbox/get',
{'accountId': _accountId, 'ids': null},
'0',
]
]);
expect(result, hasLength(1));
expect((result[0] as List<dynamic>)[0], 'Mailbox/get');
@@ -160,7 +174,11 @@ void main() {
final client = await connected(apiStatus: 500);
expect(
() => client.call([
['Mailbox/get', {'accountId': _accountId}, '0']
[
'Mailbox/get',
{'accountId': _accountId},
'0',
]
]),
throwsA(isA<JmapException>()),
);
@@ -168,10 +186,15 @@ void main() {
test('throws JmapException on top-level JMAP error', () async {
final client = await connected(
apiBody: {'type': 'unknownCapability', 'description': 'oops'});
apiBody: {'type': 'unknownCapability', 'description': 'oops'},
);
expect(
() => client.call([
['Mailbox/get', {'accountId': _accountId}, '0']
[
'Mailbox/get',
{'accountId': _accountId},
'0',
]
]),
throwsA(isA<JmapException>()),
);
+1 -2
View File
@@ -1,8 +1,7 @@
import 'package:test/test.dart';
import 'package:sharedinbox/core/models/mailbox.dart';
// Import the abstract interface so it appears in coverage.
import 'package:sharedinbox/core/repositories/mailbox_repository.dart'; // ignore: unused_import
import 'package:test/test.dart';
void main() {
group('Mailbox', () {
+99 -43
View File
@@ -63,12 +63,18 @@ http.Client _mockJmap({required List<Map<String, dynamic>> apiResponses}) {
});
}
Map<String, dynamic> _mailboxGetResponse(
{required String state, required List<Map<String, dynamic>> list}) =>
Map<String, dynamic> _mailboxGetResponse({
required String state,
required List<Map<String, dynamic>> list,
}) =>
{
'sessionState': 'sess1',
'methodResponses': [
['Mailbox/get', {'accountId': 'acct1', 'state': state, 'list': list}, '0'],
[
'Mailbox/get',
{'accountId': 'acct1', 'state': state, 'list': list},
'0',
],
],
};
@@ -167,7 +173,10 @@ void main() {
}
final mailboxes = await r.mailboxes.observeMailboxes('acc-1').first;
expect(mailboxes.map((m) => m.path).toList(), ['Drafts', 'INBOX', 'Sent']);
expect(
mailboxes.map((m) => m.path).toList(),
['Drafts', 'INBOX', 'Sent'],
);
});
test('observeMailboxes only returns mailboxes for the given account',
@@ -255,8 +264,7 @@ void main() {
await r.mailboxes.syncMailboxes('acc-1');
final mailboxes =
await r.mailboxes.observeMailboxes('acc-1').first;
final mailboxes = await r.mailboxes.observeMailboxes('acc-1').first;
expect(mailboxes, hasLength(2));
expect(mailboxes.map((m) => m.path).toSet(), {'INBOX', 'Sent'});
// statusMailbox fake returns 3 unread / 10 total for all mailboxes
@@ -265,7 +273,8 @@ void main() {
expect(r.fakeImap.logoutCalled, isTrue);
});
test('syncMailboxes still stores mailbox when statusMailbox throws', () async {
test('syncMailboxes still stores mailbox when statusMailbox throws',
() async {
final r = _makeReposWithFake();
await r.accounts.addAccount(_account, 'pw');
r.fakeImap.throwOnStatus = true;
@@ -280,8 +289,7 @@ void main() {
await r.mailboxes.syncMailboxes('acc-1');
final mailboxes =
await r.mailboxes.observeMailboxes('acc-1').first;
final mailboxes = await r.mailboxes.observeMailboxes('acc-1').first;
// Mailbox is stored even though STATUS failed; counts default to 0.
expect(mailboxes, hasLength(1));
expect(mailboxes.first.unreadCount, 0);
@@ -291,12 +299,27 @@ void main() {
group('JMAP syncMailboxes', () {
test('full sync: upserts all mailboxes and persists state', () async {
final r = _makeRepos(
httpClient: _mockJmap(apiResponses: [
_mailboxGetResponse(state: 'st1', list: [
{'id': 'mbx1', 'name': 'Inbox', 'unreadEmails': 3, 'totalEmails': 10},
{'id': 'mbx2', 'name': 'Sent', 'unreadEmails': 0, 'totalEmails': 5},
]),
]),
httpClient: _mockJmap(
apiResponses: [
_mailboxGetResponse(
state: 'st1',
list: [
{
'id': 'mbx1',
'name': 'Inbox',
'unreadEmails': 3,
'totalEmails': 10,
},
{
'id': 'mbx2',
'name': 'Sent',
'unreadEmails': 0,
'totalEmails': 5,
},
],
),
],
),
);
await r.accounts.addAccount(_jmapAccount, 'pw');
await r.mailboxes.syncMailboxes('jmap-1');
@@ -314,38 +337,66 @@ void main() {
test('incremental sync: applies created, updated, destroyed', () async {
final r = _makeRepos(
httpClient: _mockJmap(apiResponses: [
// First call: Mailbox/changes
_mailboxChangesResponse(
oldState: 'st1',
newState: 'st2',
created: ['mbx3'],
updated: ['mbx1'],
destroyed: ['mbx2'],
),
// Second call: Mailbox/get for created + updated
_mailboxGetResponse(state: 'st2', list: [
{'id': 'mbx1', 'name': 'Inbox', 'unreadEmails': 1, 'totalEmails': 8},
{'id': 'mbx3', 'name': 'Archive', 'unreadEmails': 0, 'totalEmails': 2},
]),
]),
httpClient: _mockJmap(
apiResponses: [
// First call: Mailbox/changes
_mailboxChangesResponse(
oldState: 'st1',
newState: 'st2',
created: ['mbx3'],
updated: ['mbx1'],
destroyed: ['mbx2'],
),
// Second call: Mailbox/get for created + updated
_mailboxGetResponse(
state: 'st2',
list: [
{
'id': 'mbx1',
'name': 'Inbox',
'unreadEmails': 1,
'totalEmails': 8,
},
{
'id': 'mbx3',
'name': 'Archive',
'unreadEmails': 0,
'totalEmails': 2,
},
],
),
],
),
);
await r.accounts.addAccount(_jmapAccount, 'pw');
// Pre-populate DB with existing mailboxes and state
await r.db.into(r.db.mailboxes).insertOnConflictUpdate(
MailboxesCompanion.insert(
id: 'jmap-1:mbx1', accountId: 'jmap-1', path: 'mbx1', name: 'Inbox',
unreadCount: const Value(5), totalCount: const Value(10),
));
id: 'jmap-1:mbx1',
accountId: 'jmap-1',
path: 'mbx1',
name: 'Inbox',
unreadCount: const Value(5),
totalCount: const Value(10),
),
);
await r.db.into(r.db.mailboxes).insertOnConflictUpdate(
MailboxesCompanion.insert(
id: 'jmap-1:mbx2', accountId: 'jmap-1', path: 'mbx2', name: 'Sent'));
id: 'jmap-1:mbx2',
accountId: 'jmap-1',
path: 'mbx2',
name: 'Sent',
),
);
await r.db.into(r.db.syncStates).insertOnConflictUpdate(
SyncStatesCompanion.insert(
accountId: 'jmap-1', resourceType: 'Mailbox',
state: 'st1', syncedAt: DateTime.now(),
));
accountId: 'jmap-1',
resourceType: 'Mailbox',
state: 'st1',
syncedAt: DateTime.now(),
),
);
await r.mailboxes.syncMailboxes('jmap-1');
@@ -359,16 +410,21 @@ void main() {
test('incremental sync with no changes updates state only', () async {
final r = _makeRepos(
httpClient: _mockJmap(apiResponses: [
_mailboxChangesResponse(oldState: 'st1', newState: 'st1'),
]),
httpClient: _mockJmap(
apiResponses: [
_mailboxChangesResponse(oldState: 'st1', newState: 'st1'),
],
),
);
await r.accounts.addAccount(_jmapAccount, 'pw');
await r.db.into(r.db.syncStates).insertOnConflictUpdate(
SyncStatesCompanion.insert(
accountId: 'jmap-1', resourceType: 'Mailbox',
state: 'st1', syncedAt: DateTime.now(),
));
accountId: 'jmap-1',
resourceType: 'Mailbox',
state: 'st1',
syncedAt: DateTime.now(),
),
);
await r.mailboxes.syncMailboxes('jmap-1');
+13 -11
View File
@@ -10,17 +10,19 @@ void main() {
late final db = openTestDatabase();
setUpAll(() async {
await db.into(db.accounts).insert(AccountsCompanion.insert(
id: 'acc1',
displayName: 'Test',
email: 'test@example.com',
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: true,
));
await db.into(db.accounts).insert(
AccountsCompanion.insert(
id: 'acc1',
displayName: 'Test',
email: 'test@example.com',
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: true,
),
);
});
tearDownAll(() => db.close());
+47 -32
View File
@@ -8,7 +8,8 @@ void main() {
testWidgets('shows "No accounts yet." when repository is empty',
(tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
expect(find.text('No accounts yet.'), findsOneWidget);
@@ -17,10 +18,12 @@ void main() {
testWidgets('shows account tile when repository has an account',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
expect(find.text('Alice'), findsOneWidget);
@@ -29,10 +32,12 @@ void main() {
});
testWidgets('shows IMAP type label for IMAP account', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
expect(find.text('IMAP'), findsOneWidget);
@@ -40,10 +45,12 @@ void main() {
testWidgets('shows check icon after successful connection test',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
// Before settling: connection test is in-flight → spinner visible.
await tester.pump();
@@ -55,13 +62,15 @@ void main() {
});
testWidgets('shows error icon when connection test fails', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(
accounts: [kTestAccount],
connectionError: Exception('auth failed'),
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(
accounts: [kTestAccount],
connectionError: Exception('auth failed'),
),
),
));
);
await tester.pumpAndSettle();
expect(find.byIcon(Icons.error_outline), findsOneWidget);
@@ -69,16 +78,17 @@ void main() {
testWidgets('app bar shows "SharedInbox" title', (tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
expect(find.text('SharedInbox'), findsOneWidget);
});
testWidgets('tapping settings icon navigates to /settings',
(tester) async {
testWidgets('tapping settings icon navigates to /settings', (tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.settings));
@@ -91,7 +101,8 @@ void main() {
'"Add account" button in empty state navigates to add-account screen',
(tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
await tester.tap(find.text('Add account'));
@@ -102,13 +113,15 @@ void main() {
testWidgets('tapping an account tile navigates to its mailboxes',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(
accounts: [kTestAccount],
mailboxes: [kTestMailbox],
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts',
overrides: baseOverrides(
accounts: [kTestAccount],
mailboxes: [kTestMailbox],
),
),
));
);
await tester.pumpAndSettle();
await tester.tap(find.text('Alice'));
@@ -119,7 +132,8 @@ void main() {
testWidgets('tapping FAB navigates to add-account screen', (tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
await tester.tap(find.byType(FloatingActionButton));
@@ -136,7 +150,8 @@ void main() {
addTearDown(tester.view.resetDevicePixelRatio);
await tester.pumpWidget(
buildApp(initialLocation: '/accounts', overrides: baseOverrides()));
buildApp(initialLocation: '/accounts', overrides: baseOverrides()),
);
await tester.pumpAndSettle();
expect(tester.takeException(), isNull);
+155 -79
View File
@@ -7,9 +7,14 @@ import 'helpers.dart';
void main() {
group('AddAccountScreen', () {
testWidgets('step 1: shows email field and Continue button', (tester) async {
testWidgets('step 1: shows email field and Continue button',
(tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts/add', overrides: baseOverrides()));
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(),
),
);
await tester.pumpAndSettle();
expect(find.text('Add account'), findsOneWidget);
@@ -19,7 +24,11 @@ void main() {
testWidgets('step 1: empty submit shows validation error', (tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts/add', overrides: baseOverrides()));
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(),
),
);
await tester.pumpAndSettle();
await tester.tap(find.text('Continue'));
@@ -30,7 +39,11 @@ void main() {
testWidgets('step 1: invalid email shows validation error', (tester) async {
await tester.pumpWidget(
buildApp(initialLocation: '/accounts/add', overrides: baseOverrides()));
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(),
),
);
await tester.pumpAndSettle();
await tester.enterText(find.byKey(const Key('emailField')), 'notanemail');
@@ -41,14 +54,18 @@ void main() {
});
testWidgets('unknown discovery shows choose-type step', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
),
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
@@ -56,17 +73,23 @@ void main() {
expect(find.text('IMAP / SMTP'), findsOneWidget);
});
testWidgets('JMAP discovery navigates directly to JMAP form', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: JmapDiscovery(apiUrl: 'https://mail.example.com/jmap'),
testWidgets('JMAP discovery navigates directly to JMAP form',
(tester) async {
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery:
JmapDiscovery(sessionUrl: 'https://mail.example.com/jmap'),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
@@ -74,24 +97,29 @@ void main() {
expect(find.text('https://mail.example.com/jmap'), findsOneWidget);
});
testWidgets('IMAP discovery navigates directly to IMAP form', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: ImapSmtpDiscovery(
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: false,
testWidgets('IMAP discovery navigates directly to IMAP form',
(tester) async {
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: ImapSmtpDiscovery(
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: false,
),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
@@ -101,14 +129,18 @@ void main() {
});
testWidgets('choose-type: tapping JMAP shows JMAP form', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
),
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
@@ -118,15 +150,20 @@ void main() {
expect(find.text('JMAP API URL'), findsOneWidget);
});
testWidgets('choose-type: tapping IMAP/SMTP shows IMAP form', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
));
testWidgets('choose-type: tapping IMAP/SMTP shows IMAP form',
(tester) async {
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
),
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
@@ -137,22 +174,34 @@ void main() {
expect(find.text('SMTP'), findsOneWidget);
});
testWidgets('successful JMAP save pops back to accounts list', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: JmapDiscovery(apiUrl: 'https://mail.example.com/jmap'),
testWidgets('successful JMAP save pops back to accounts list',
(tester) async {
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery:
JmapDiscovery(sessionUrl: 'https://mail.example.com/jmap'),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
await tester.enterText(find.widgetWithText(TextFormField, 'Display name'), 'Alice');
await tester.enterText(find.widgetWithText(TextFormField, 'Password'), 'secret');
await tester.enterText(
find.widgetWithText(TextFormField, 'Display name'),
'Alice',
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Password'),
'secret',
);
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
@@ -160,71 +209,98 @@ void main() {
});
testWidgets('JMAP connection failure shows error message', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: JmapDiscovery(apiUrl: 'https://mail.example.com/jmap'),
connectionError: Exception('auth failed'),
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery:
JmapDiscovery(sessionUrl: 'https://mail.example.com/jmap'),
connectionError: Exception('auth failed'),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
await tester.enterText(find.widgetWithText(TextFormField, 'Display name'), 'Alice');
await tester.enterText(find.widgetWithText(TextFormField, 'Password'), 'wrong');
await tester.enterText(
find.widgetWithText(TextFormField, 'Display name'),
'Alice',
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Password'),
'wrong',
);
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
expect(find.textContaining('Connection failed'), findsOneWidget);
});
testWidgets('successful IMAP save pops back to accounts list', (tester) async {
testWidgets('successful IMAP save pops back to accounts list',
(tester) async {
tester.view.physicalSize = const Size(800, 1400);
tester.view.devicePixelRatio = 1.0;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: ImapSmtpDiscovery(
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: false,
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(
discovery: ImapSmtpDiscovery(
imapHost: 'imap.example.com',
imapPort: 993,
imapSsl: true,
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSsl: false,
),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
await tester.enterText(find.widgetWithText(TextFormField, 'Display name'), 'Alice');
await tester.enterText(find.widgetWithText(TextFormField, 'Password'), 'secret');
await tester.enterText(
find.widgetWithText(TextFormField, 'Display name'),
'Alice',
);
await tester.enterText(
find.widgetWithText(TextFormField, 'Password'),
'secret',
);
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
expect(find.text('No accounts yet.'), findsOneWidget);
});
testWidgets('IMAP form shows SSL/TLS label and SMTP toggle', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
));
testWidgets('IMAP form shows SSL/TLS label and SMTP toggle',
(tester) async {
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/add',
overrides: baseOverrides(discovery: UnknownDiscovery()),
),
);
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const Key('emailField')), 'user@example.com');
find.byKey(const Key('emailField')),
'user@example.com',
);
await tester.tap(find.text('Continue'));
await tester.pumpAndSettle();
+80 -72
View File
@@ -12,19 +12,19 @@ import 'helpers.dart';
void main() {
group('ComposeScreen', () {
testWidgets('renders To, Cc, Subject and Body fields', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider
.overrideWithValue(FakeDraftRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('To'), findsOneWidget);
@@ -35,44 +35,46 @@ void main() {
testWidgets('prefills To and Subject when provided as constructor params',
(tester) async {
await tester.pumpWidget(_buildDirect(
screen: const ComposeScreen(
prefillTo: 'bob@example.com',
prefillSubject: 'Re: Hello',
await tester.pumpWidget(
_buildDirect(
screen: const ComposeScreen(
prefillTo: 'bob@example.com',
prefillSubject: 'Re: Hello',
),
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
],
),
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider
.overrideWithValue(FakeDraftRepository()),
],
));
);
await tester.pumpAndSettle();
expect(find.widgetWithText(TextFormField, 'bob@example.com'),
findsOneWidget);
expect(
find.widgetWithText(TextFormField, 'bob@example.com'),
findsOneWidget,
);
expect(find.widgetWithText(TextFormField, 'Re: Hello'), findsOneWidget);
});
testWidgets('shows static From field when one account is loaded',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider
.overrideWithValue(FakeDraftRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Alice <alice@example.com>'), findsOneWidget);
@@ -87,19 +89,20 @@ void main() {
imapHost: 'imap.example.com',
smtpHost: 'smtp.example.com',
);
await tester.pumpWidget(buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider.overrideWithValue(
FakeAccountRepository([kTestAccount, second])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider
.overrideWithValue(FakeDraftRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/compose',
overrides: [
accountRepositoryProvider.overrideWithValue(
FakeAccountRepository([kTestAccount, second]),
),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.byType(DropdownButtonFormField<String>), findsOneWidget);
@@ -114,24 +117,29 @@ void main() {
subjectText: 'Restored subject',
bodyText: 'Draft body',
);
await tester.pumpWidget(_buildDirect(
screen: const ComposeScreen(),
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(fakeDrafts),
],
));
await tester.pumpWidget(
_buildDirect(
screen: const ComposeScreen(),
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(fakeDrafts),
],
),
);
await tester.pumpAndSettle();
expect(find.widgetWithText(TextFormField, 'carol@example.com'),
findsOneWidget);
expect(find.widgetWithText(TextFormField, 'Restored subject'),
findsOneWidget);
expect(
find.widgetWithText(TextFormField, 'carol@example.com'),
findsOneWidget,
);
expect(
find.widgetWithText(TextFormField, 'Restored subject'),
findsOneWidget,
);
});
});
}
+48 -29
View File
@@ -7,10 +7,12 @@ void main() {
group('EditAccountScreen', () {
testWidgets('shows account email and type label after loading',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
expect(find.text('alice@example.com'), findsOneWidget);
@@ -19,20 +21,24 @@ void main() {
});
testWidgets('pre-fills display name field', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
expect(find.widgetWithText(TextFormField, 'Alice'), findsOneWidget);
});
testWidgets('shows Save button', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
expect(find.text('Save'), findsOneWidget);
@@ -44,10 +50,12 @@ void main() {
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
await tester.tap(find.text('Save'));
@@ -57,19 +65,25 @@ void main() {
expect(find.text('No accounts yet.'), findsNothing);
});
testWidgets('saving with new password runs connection test', (tester) async {
testWidgets('saving with new password runs connection test',
(tester) async {
tester.view.physicalSize = const Size(800, 1400);
tester.view.devicePixelRatio = 1.0;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(accounts: [kTestAccount]),
),
);
await tester.pumpAndSettle();
await tester.enterText(find.byKey(const Key('editPasswordField')), 'newsecret');
await tester.enterText(
find.byKey(const Key('editPasswordField')),
'newsecret',
);
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
@@ -83,16 +97,21 @@ void main() {
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(
accounts: [kTestAccount],
connectionError: Exception('auth failed'),
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/edit',
overrides: baseOverrides(
accounts: [kTestAccount],
connectionError: Exception('auth failed'),
),
),
));
);
await tester.pumpAndSettle();
await tester.enterText(find.byKey(const Key('editPasswordField')), 'wrongpassword');
await tester.enterText(
find.byKey(const Key('editPasswordField')),
'wrongpassword',
);
await tester.tap(find.text('Save'));
await tester.pumpAndSettle();
+54 -50
View File
@@ -13,17 +13,18 @@ void main() {
testWidgets('shows loading spinner before data arrives', (tester) async {
// Use a Completer-backed repo so data never arrives during this test.
final neverRepo = _NeverEmailRepository();
await tester.pumpWidget(buildApp(
initialLocation:
'/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(neverRepo),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(neverRepo),
],
),
);
// One pump to build the widget tree; future not resolved yet.
await tester.pump();
@@ -37,19 +38,20 @@ void main() {
textBody: 'See attached slides.',
attachments: [],
);
await tester.pumpWidget(buildApp(
initialLocation:
'/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
),
);
await tester.pumpAndSettle();
// Subject appears in both the app bar and the email header section.
@@ -61,19 +63,20 @@ void main() {
final email = testEmail();
const body =
EmailBody(emailId: 'acc-1:42', textBody: 'Hi', attachments: []);
await tester.pumpWidget(buildApp(
initialLocation:
'/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
),
);
await tester.pumpAndSettle();
expect(find.textContaining('bob@example.com'), findsOneWidget);
@@ -93,19 +96,20 @@ void main() {
),
],
);
await tester.pumpWidget(buildApp(
initialLocation:
'/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails/acc-1%3A42',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(emailDetail: email, emailBody: body),
),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Attachments'), findsOneWidget);
+112 -100
View File
@@ -8,17 +8,18 @@ import 'helpers.dart';
void main() {
group('EmailListScreen', () {
testWidgets('shows "No emails" when list is empty', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('No emails'), findsOneWidget);
@@ -26,17 +27,19 @@ void main() {
testWidgets('shows email sender and subject', (tester) async {
final email = testEmail(subject: 'Meeting agenda');
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository(emails: [email])),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository(emails: [email])),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Bob'), findsOneWidget);
@@ -45,34 +48,37 @@ void main() {
testWidgets('shows flag icon for flagged email', (tester) async {
final email = testEmail(isFlagged: true);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository(emails: [email])),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository(emails: [email])),
],
),
);
await tester.pumpAndSettle();
expect(find.byIcon(Icons.star), findsOneWidget);
});
testWidgets('tapping search icon shows search bar', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.search));
@@ -84,17 +90,18 @@ void main() {
testWidgets('submitting a search query shows "No results" when empty',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.search));
@@ -110,18 +117,20 @@ void main() {
testWidgets('submitting a search query shows matching emails',
(tester) async {
final email = testEmail(subject: 'Found it');
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(searchResults: [email]),
),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(
FakeEmailRepository(searchResults: [email]),
),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.search));
@@ -135,17 +144,18 @@ void main() {
});
testWidgets('tapping sync button triggers syncEmails', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.sync));
@@ -156,17 +166,18 @@ void main() {
testWidgets('tapping edit button navigates to compose screen',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.edit));
@@ -176,17 +187,18 @@ void main() {
});
testWidgets('tapping back arrow in search bar closes it', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.search));
+6 -4
View File
@@ -143,8 +143,7 @@ class FakeEmailRepository implements EmailRepository {
}) : _emails = emails ?? [],
_emailDetail = emailDetail,
_searchResults = searchResults ?? [],
_emailBody =
emailBody ?? const EmailBody(emailId: '', attachments: []);
_emailBody = emailBody ?? const EmailBody(emailId: '', attachments: []);
@override
Stream<List<Email>> observeEmails(String accountId, String mailboxPath) =>
@@ -176,7 +175,9 @@ class FakeEmailRepository implements EmailRepository {
@override
Future<String> downloadAttachment(
String emailId, EmailAttachment attachment) async =>
String emailId,
EmailAttachment attachment,
) async =>
'/tmp/${attachment.filename}';
@override
@@ -325,7 +326,8 @@ List<Override> baseOverrides({
[
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository(accounts)),
mailboxRepositoryProvider.overrideWithValue(FakeMailboxRepository(mailboxes)),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository(mailboxes)),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
accountDiscoveryServiceProvider.overrideWithValue(
+48 -44
View File
@@ -9,34 +9,36 @@ import 'helpers.dart';
void main() {
group('MailboxListScreen', () {
testWidgets('shows mailbox name', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('INBOX'), findsWidgets);
});
testWidgets('shows unread badge when unreadCount > 0', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
// kTestMailbox has unreadCount = 3
@@ -45,17 +47,18 @@ void main() {
testWidgets('tapping a mailbox tile navigates to its email list',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([kTestMailbox])),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.text('INBOX').first);
@@ -73,17 +76,18 @@ void main() {
unreadCount: 0,
totalCount: 5,
);
await tester.pumpWidget(buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([emptyMailbox])),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/accounts/acc-1/mailboxes',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository([emptyMailbox])),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Sent'), findsOneWidget);
+60 -55
View File
@@ -8,34 +8,36 @@ import 'helpers.dart';
void main() {
group('SettingsScreen', () {
testWidgets('shows "Accounts" section header', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository()),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository()),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Accounts'), findsOneWidget);
});
testWidgets('shows account tile when an account exists', (tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
expect(find.text('Alice'), findsOneWidget);
@@ -44,17 +46,18 @@ void main() {
testWidgets('tapping delete icon shows confirmation dialog',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.delete));
@@ -67,17 +70,18 @@ void main() {
testWidgets('tapping Remove in the confirmation dialog calls removeAccount',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.delete));
@@ -91,17 +95,18 @@ void main() {
testWidgets('tapping Cancel in the confirmation dialog dismisses it',
(tester) async {
await tester.pumpWidget(buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider
.overrideWithValue(FakeEmailRepository()),
],
));
await tester.pumpWidget(
buildApp(
initialLocation: '/settings',
overrides: [
accountRepositoryProvider
.overrideWithValue(FakeAccountRepository([kTestAccount])),
mailboxRepositoryProvider
.overrideWithValue(FakeMailboxRepository()),
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
],
),
);
await tester.pumpAndSettle();
await tester.tap(find.byIcon(Icons.delete));