docs: explain why continue-on-error is intentional on deploy steps (#154) #177

Merged
guettlibot merged 4 commits from issue-154-fix into main 2026-05-23 13:30:17 +00:00
guettlibot commented 2026-05-23 13:28:15 +00:00 (Migrated from codeberg.org)

Summary

  • Adds inline comments to all three continue-on-error: true deploy steps in .forgejo/workflows/deploy.yml
  • Explains that each step is best-effort and requires SSH_PRIVATE_KEY; a missing secret causes a soft step failure (orange in UI) while the overall job stays green — this is intentional
  • Closes the confusion reported in issue #154

Why these comments matter

The continue-on-error: true flag makes a failing step appear as orange/failed in the step list but does not propagate the failure to the job, so the overall CI run shows green. Without an explanation this looks like a bug. The comments document that this is by design: deployment to the server is best-effort and should not block the CI green light when SSH credentials are absent.

Test plan

  • CI passes on this branch (no code logic changed, only YAML comments)
## Summary - Adds inline comments to all three `continue-on-error: true` deploy steps in `.forgejo/workflows/deploy.yml` - Explains that each step is best-effort and requires `SSH_PRIVATE_KEY`; a missing secret causes a soft step failure (orange in UI) while the overall job stays green — this is intentional - Closes the confusion reported in issue #154 ## Why these comments matter The `continue-on-error: true` flag makes a failing step appear as orange/failed in the step list but does not propagate the failure to the job, so the overall CI run shows green. Without an explanation this looks like a bug. The comments document that this is by design: deployment to the server is best-effort and should not block the CI green light when SSH credentials are absent. ## Test plan - [ ] CI passes on this branch (no code logic changed, only YAML comments)
Sign in to join this conversation.