guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Question: Should other deploy jobs also use fetch-depth > 1 for changelog accuracy? #229

New Issue
Closed
opened 2026-05-24 19:03:25 +00:00 by guettlibot · 1 comment
guettlibot commented 2026-05-24 19:03:25 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Context (from #228)

The fix for issue #228 changes fetch-depth: 1 to fetch-depth: 100 only in the deploy-playstore job in .forgejo/workflows/deploy.yml.

The other deploy jobs (deploy-apk, build-linux) also use fetch-depth: 1. Their Taskfile tasks already list generate-changelog in their deps, so they attempt to regenerate the changelog, but a shallow clone of depth 1 means git log -n 50 returns only one commit.

Question

Should deploy-apk and build-linux CI jobs also be updated to use fetch-depth: 100 so their in-app changelog is accurate?

Tradeoffs

  • Adding deeper fetch to all jobs ensures changelog consistency everywhere
  • Each extra commit fetched adds a small overhead to checkout time
  • Only deploy-playstore bundles assets/changelog.txt into the AAB via Dagger's --source=. flag; it is unclear if APK/Linux builds benefit similarly
## Context (from #228) The fix for issue #228 changes fetch-depth: 1 to fetch-depth: 100 only in the deploy-playstore job in .forgejo/workflows/deploy.yml. The other deploy jobs (deploy-apk, build-linux) also use fetch-depth: 1. Their Taskfile tasks already list generate-changelog in their deps, so they attempt to regenerate the changelog, but a shallow clone of depth 1 means git log -n 50 returns only one commit. ## Question Should deploy-apk and build-linux CI jobs also be updated to use fetch-depth: 100 so their in-app changelog is accurate? ## Tradeoffs - Adding deeper fetch to all jobs ensures changelog consistency everywhere - Each extra commit fetched adds a small overhead to checkout time - Only deploy-playstore bundles assets/changelog.txt into the AAB via Dagger's --source=. flag; it is unclear if APK/Linux builds benefit similarly
guettlibot commented 2026-05-25 12:43:37 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Implemented in PR #248: deploy-apk and build-linux now use fetch-depth: 100, matching deploy-playstore.

Implemented in PR #248: deploy-apk and build-linux now use fetch-depth: 100, matching deploy-playstore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#229