guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: guard against empty IMAP fetch message list #346

Merged
guettlibot merged 1 commits from issue-339-safe-first-on-imap-fetch into main 2026-06-01 19:48:23 +00:00
Conversation 0 Commits 1 Files Changed 2
+3124 -10847
guettlibot commented 2026-06-01 16:06:16 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Closes #339

What changed

Replaced three unsafe .first accesses on fetch.messages in email_repository_impl.dart with .firstOrNull + an early throw StateError(...) that names the UID. This turns the cryptic StateError: No element (triggered when an IMAP server returns an empty list due to a network hiccup or an already-expunged UID) into a descriptive error.

Also added snapshot.hasError handling in the FutureBuilder in thread_detail_screen.dart so users see an inline error message instead of an infinite spinner when getEmailBody throws.

Locations fixed

File Line Change
email_repository_impl.dart ~240 getEmailBody IMAP path
email_repository_impl.dart ~2816 downloadAttachment IMAP path
email_repository_impl.dart ~2888 fetchRawRfc822 IMAP path
thread_detail_screen.dart FutureBuilder added hasError branch

Verification

  • task analyze — no issues
  • task test — 491/491 tests passed
Closes #339 ## What changed Replaced three unsafe `.first` accesses on `fetch.messages` in `email_repository_impl.dart` with `.firstOrNull` + an early `throw StateError(...)` that names the UID. This turns the cryptic `StateError: No element` (triggered when an IMAP server returns an empty list due to a network hiccup or an already-expunged UID) into a descriptive error. Also added `snapshot.hasError` handling in the `FutureBuilder` in `thread_detail_screen.dart` so users see an inline error message instead of an infinite spinner when `getEmailBody` throws. ## Locations fixed | File | Line | Change | |------|------|--------| | `email_repository_impl.dart` | ~240 | `getEmailBody` IMAP path | | `email_repository_impl.dart` | ~2816 | `downloadAttachment` IMAP path | | `email_repository_impl.dart` | ~2888 | `fetchRawRfc822` IMAP path | | `thread_detail_screen.dart` | FutureBuilder | added `hasError` branch | ## Verification - `task analyze` — no issues - `task test` — 491/491 tests passed
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#346