guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Auto complete of To/cc/bcc #375

New Issue
Closed
opened 2026-06-03 20:22:30 +00:00 by guettli · 1 comment
guettli commented 2026-06-03 20:22:30 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Auto complete of To/cc/bcc should prioritize last To usage (sent folder) to received messages.

Example: I wrote to info@foo.de yesterday, and I got a spam message from info@spam.de some minutes ago.

When I type "i" in To field, I want to see info@foo.de first.

Auto complete of To/cc/bcc should prioritize last To usage (sent folder) to received messages. Example: I wrote to info@foo.de yesterday, and I got a spam message from info@spam.de some minutes ago. When I type "i" in To field, I want to see info@foo.de first.
guettlibot commented 2026-06-03 22:15:02 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

The PR is open at https://codeberg.org/guettli/sharedinbox/pulls/380.

Here's a summary of what was done:

Problem: The To/Cc/Bcc autocomplete sorted suggestions purely by recency (receivedAt DESC). A spam email received today from info@spam.de would appear before info@foo.de that the user deliberately sent to yesterday.

Fix (lib/data/repositories/email_repository_impl.dart):

  • Before processing candidate rows, searchAddresses now queries the mailboxes table for any mailbox with role='sent' and collects their paths.
  • Candidate email rows are split into two groups: sent-folder rows first, then all others — each group still sorted by recency internally.
  • Within sent-folder rows, toAddresses/ccJson are checked before fromJson (since fromJson in a sent email is the user's own address, not a useful suggestion).

Test (test/unit/email_repository_impl_test.dart):

  • Added searchAddresses prioritises sent-folder addresses over newer received — inserts an older sent email to info@foo.de and a newer inbox email from info@spam.de, verifies info@foo.de is returned first.
  • All 492 existing tests continue to pass.
The PR is open at https://codeberg.org/guettli/sharedinbox/pulls/380. Here's a summary of what was done: **Problem:** The To/Cc/Bcc autocomplete sorted suggestions purely by recency (`receivedAt` DESC). A spam email received today from `info@spam.de` would appear before `info@foo.de` that the user deliberately sent to yesterday. **Fix** (`lib/data/repositories/email_repository_impl.dart`): - Before processing candidate rows, `searchAddresses` now queries the `mailboxes` table for any mailbox with `role='sent'` and collects their paths. - Candidate email rows are split into two groups: sent-folder rows first, then all others — each group still sorted by recency internally. - Within sent-folder rows, `toAddresses`/`ccJson` are checked before `fromJson` (since `fromJson` in a sent email is the user's own address, not a useful suggestion). **Test** (`test/unit/email_repository_impl_test.dart`): - Added `searchAddresses prioritises sent-folder addresses over newer received` — inserts an older sent email to `info@foo.de` and a newer inbox email from `info@spam.de`, verifies `info@foo.de` is returned first. - All 492 existing tests continue to pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels loop/code-done
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#375