guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

refactor(A1): extract EmailDetailNotifier, drop initState DB coupling #39

Merged
guettlibot merged 1 commits from task/a1-email-detail-notifier into main 2026-05-14 07:49:39 +00:00
Conversation 0 Commits 1 Files Changed 2
+2158 -33895
guettlibot commented 2026-05-14 07:17:38 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Implements A1 from the improvement plan.

EmailDetailScreen was calling ref.read(emailRepositoryProvider) and
awaiting futures inside initState, tightly coupling the screen to the
repository API. This PR extracts a dedicated EmailDetailNotifier
(AsyncNotifierProvider.autoDispose.family) in di.dart that owns the
load logic and the setFlag(seen: true) side effect. The screen now
watches the provider and renders via detail.when(loading/error/data),
removing all direct repository calls from the widget.

Changes:

  • lib/di.dart: add emailDetailProvider + EmailDetailNotifier; hide
    Drift-generated Email/EmailBody from database.dart to avoid
    ambiguous import with the domain model.
  • lib/ui/screens/email_detail_screen.dart: remove initState override,
    remove _dataFuture field, replace FutureBuilder with ref.watch +
    detail.when, initialize _isFlagged via ref.listen.

Closes #19 (A1)

Implements A1 from the improvement plan. `EmailDetailScreen` was calling `ref.read(emailRepositoryProvider)` and awaiting futures inside `initState`, tightly coupling the screen to the repository API. This PR extracts a dedicated `EmailDetailNotifier` (`AsyncNotifierProvider.autoDispose.family`) in `di.dart` that owns the load logic and the `setFlag(seen: true)` side effect. The screen now watches the provider and renders via `detail.when(loading/error/data)`, removing all direct repository calls from the widget. Changes: - `lib/di.dart`: add `emailDetailProvider` + `EmailDetailNotifier`; hide Drift-generated `Email`/`EmailBody` from `database.dart` to avoid ambiguous import with the domain model. - `lib/ui/screens/email_detail_screen.dart`: remove `initState` override, remove `_dataFuture` field, replace `FutureBuilder` with `ref.watch` + `detail.when`, initialize `_isFlagged` via `ref.listen`. Closes #19 (A1)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#39