guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Deleting mail in thread view, remove popup #398

New Issue
Closed
opened 2026-06-04 01:21:07 +00:00 by guettli · 1 comment
guettli commented 2026-06-04 01:21:07 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

When deleting a mail from thread view, a pop-up is shown:. Delete mail?

Avoid that. Use a snack bar like when deleting from single Mail View

When deleting a mail from thread view, a pop-up is shown:. Delete mail? Avoid that. Use a snack bar like when deleting from single Mail View
guettlibot commented 2026-06-04 02:05:03 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

PR created: https://codeberg.org/guettli/sharedinbox/pulls/402

What changed: In thread_detail_screen.dart, the _delete() method previously showed an AlertDialog asking "Move this email to Trash?" before proceeding. I removed the dialog and made deletion happen immediately — exactly as the single mail view does. The UndoShell widget already handles showing a snack bar with an "Undo" button whenever a UndoAction is pushed to undoServiceProvider, so no additional UI code was needed. The change is a net deletion of 20 lines.

PR created: https://codeberg.org/guettli/sharedinbox/pulls/402 --- **What changed:** In `thread_detail_screen.dart`, the `_delete()` method previously showed an `AlertDialog` asking "Move this email to Trash?" before proceeding. I removed the dialog and made deletion happen immediately — exactly as the single mail view does. The `UndoShell` widget already handles showing a snack bar with an "Undo" button whenever a `UndoAction` is pushed to `undoServiceProvider`, so no additional UI code was needed. The change is a net deletion of 20 lines.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels loop/code-done
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#398