guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Deleting mail, snack bar does not vanish when #399

New Issue
Closed
opened 2026-06-04 01:22:50 +00:00 by guettli · 1 comment
guettli commented 2026-06-04 01:22:50 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

When deleting a mail from single Mail View, the snack bar does not vanish after some seconds. It should.

When deleting a mail from single Mail View, the snack bar does not vanish after some seconds. It should.
guettlibot commented 2026-06-04 02:00:06 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

PR is open at https://codeberg.org/guettli/sharedinbox/pulls/401.

What I did and why:

When the delete button is pressed in the single Mail View (email_detail_screen.dart), the original code called unawaited(pushAction(...)) immediately before _navigateTo(). Because pushAction is async, navigation fired first. The UndoShell's ref.listen callback (which fires synchronously on state change in Riverpod) only triggered after navigation had started, so showSnackBar() was called while the destination scaffold was still mid-transition. This prevented the snack bar's internal duration animation from starting correctly, leaving it stuck on screen indefinitely.

Fix: Changed unawaited(pushAction(...)) to await pushAction(...). Now the state change (and the resulting ref.listen → showSnackBar call) happens before _navigateTo(). The snack bar gets queued on the current stable scaffold, then transfers cleanly to the destination scaffold after navigation completes, and auto-dismisses after 5 seconds as expected.

All 338 existing tests pass unchanged.

PR is open at https://codeberg.org/guettli/sharedinbox/pulls/401. --- **What I did and why:** When the delete button is pressed in the single Mail View (`email_detail_screen.dart`), the original code called `unawaited(pushAction(...))` immediately before `_navigateTo()`. Because `pushAction` is async, navigation fired first. The `UndoShell`'s `ref.listen` callback (which fires synchronously on state change in Riverpod) only triggered *after* navigation had started, so `showSnackBar()` was called while the destination scaffold was still mid-transition. This prevented the snack bar's internal duration animation from starting correctly, leaving it stuck on screen indefinitely. **Fix:** Changed `unawaited(pushAction(...))` to `await pushAction(...)`. Now the state change (and the resulting `ref.listen` → `showSnackBar` call) happens *before* `_navigateTo()`. The snack bar gets queued on the current stable scaffold, then transfers cleanly to the destination scaffold after navigation completes, and auto-dismisses after 5 seconds as expected. All 338 existing tests pass unchanged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels loop/code-done
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#399