guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: make Android signing config conditional on ANDROID_KEYSTORE_PATH #440

Merged
guettlibot merged 1 commits from refs/pull/440/head into main 2026-06-05 09:48:49 +00:00
Conversation 0 Commits 1 Files Changed 1
+1010 -6495
guettlibot commented 2026-06-05 09:13:54 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • BuildAndroidRelease in ci/main.go intentionally builds the AAB without setting up the keystore — the unsigned AAB is later stamped with StampAndroidVersionCode and re-signed by SignAndroidBundle via jarsigner.
  • The old signingConfigs.create("release") block in android/app/build.gradle.kts called error("ANDROID_KEYSTORE_PATH is not set") at Gradle configuration time, which fired even when the keystore wasn't needed for the build step.
  • Fix: guard the signingConfigs block and the signingConfig assignment in the release build type behind a null-check on ANDROID_KEYSTORE_PATH. When the env var is absent (unsigned build path), Gradle skips the signing config entirely; when it is present (e.g. BuildAndroidApk via setupKeystore), the config is created and applied as before.

Test plan

  • Trigger deploy.yml via workflow_dispatch and verify the Build & Deploy to Play Store job no longer fails at step 4 with "ANDROID_KEYSTORE_PATH is not set"
  • Verify BuildAndroidApk (which calls setupKeystore) still produces a correctly signed APK

Closes #439

🤖 Generated with Claude Code

## Summary - `BuildAndroidRelease` in `ci/main.go` intentionally builds the AAB without setting up the keystore — the unsigned AAB is later stamped with `StampAndroidVersionCode` and re-signed by `SignAndroidBundle` via jarsigner. - The old `signingConfigs.create("release")` block in `android/app/build.gradle.kts` called `error("ANDROID_KEYSTORE_PATH is not set")` at Gradle _configuration_ time, which fired even when the keystore wasn't needed for the build step. - Fix: guard the `signingConfigs` block and the `signingConfig` assignment in the release build type behind a null-check on `ANDROID_KEYSTORE_PATH`. When the env var is absent (unsigned build path), Gradle skips the signing config entirely; when it is present (e.g. `BuildAndroidApk` via `setupKeystore`), the config is created and applied as before. ## Test plan - Trigger `deploy.yml` via `workflow_dispatch` and verify the `Build & Deploy to Play Store` job no longer fails at step 4 with "ANDROID_KEYSTORE_PATH is not set" - Verify `BuildAndroidApk` (which calls `setupKeystore`) still produces a correctly signed APK Closes #439 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#440