guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

feat: add per-email notes stored on IMAP/JMAP server #443

Merged
guettlibot merged 5 commits from issue-436-notes-on-emails into main 2026-06-05 17:31:37 +00:00
Conversation 0 Commits 5 Files Changed 9
+570 -4806
guettlibot commented 2026-06-05 14:52:24 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Closes #436

What changed

Notes can now be added and deleted on any email. Each note is stored as a message in a dedicated Notes folder on the IMAP or JMAP server, so:

  • Multi-user safe — all clients connected to the same account see the same notes
  • Move-stable — notes are keyed by the RFC 2822 Message-ID header (via X-SharedInbox-Note-For custom header), not the IMAP UID, so they survive folder moves
  • No local-only storage — the server is the source of truth; the local Drift cache is only a read-through cache

Implementation

  • Schema v39: new EmailNotes table (id, accountId, messageId, noteText, serverId, createdAt)
  • NoteRepository + NoteRepositoryImpl: IMAP uses APPEND to Notes folder with X-SharedInbox-Note-For/X-SharedInbox-Note-Id custom headers, SEARCH HEADER to sync, UID STORE \Deleted + EXPUNGE to delete. JMAP uses Email/set create/destroy in a Notes mailbox, Email/get with header:...:asText to sync.
  • di.dart: noteRepositoryProvider + notesProvider stream family
  • email_detail_screen.dart: Notes section below the email body — list with delete buttons, "Add" dialog. Notes synced from server once when the screen opens.
  • migration_test.dart: updated for schema v39

Verification

  • flutter analyze lib/ → no issues
  • flutter test test/unit/ → 335 tests, all pass
Closes #436 ## What changed Notes can now be added and deleted on any email. Each note is stored as a message in a dedicated **Notes** folder on the IMAP or JMAP server, so: - **Multi-user safe** — all clients connected to the same account see the same notes - **Move-stable** — notes are keyed by the RFC 2822 `Message-ID` header (via `X-SharedInbox-Note-For` custom header), not the IMAP UID, so they survive folder moves - **No local-only storage** — the server is the source of truth; the local Drift cache is only a read-through cache ## Implementation - **Schema v39**: new `EmailNotes` table (`id`, `accountId`, `messageId`, `noteText`, `serverId`, `createdAt`) - **`NoteRepository`** + **`NoteRepositoryImpl`**: IMAP uses `APPEND` to `Notes` folder with `X-SharedInbox-Note-For`/`X-SharedInbox-Note-Id` custom headers, `SEARCH HEADER` to sync, `UID STORE \Deleted` + `EXPUNGE` to delete. JMAP uses `Email/set` create/destroy in a `Notes` mailbox, `Email/get` with `header:...:asText` to sync. - **`di.dart`**: `noteRepositoryProvider` + `notesProvider` stream family - **`email_detail_screen.dart`**: Notes section below the email body — list with delete buttons, "Add" dialog. Notes synced from server once when the screen opens. - **`migration_test.dart`**: updated for schema v39 ## Verification - `flutter analyze lib/` → no issues - `flutter test test/unit/` → 335 tests, all pass
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#443