guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

refactor: unify mail display with shared ThreadTile widget #445

Merged
guettlibot merged 2 commits from issue-429-unify-mail-display into main 2026-06-05 17:06:30 +00:00
Conversation 0 Commits 2 Files Changed 6
+570 -5580
guettlibot commented 2026-06-05 15:10:02 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

Closes #429

There were three separate places that rendered a mail row:

  • EmailTile — used in SearchScreen and EmailListScreen._buildEmailList(), accepted an Email object
  • Inline ListTile in EmailListScreen._buildThreadList() — accepted an EmailThread
  • Inline ListTile in CombinedInboxScreen._buildThreadTile() — accepted an EmailThread

What changed

  • New lib/ui/widgets/thread_tile.dart — a single ThreadTile widget that renders an EmailThread with all the thread-level features (message count badge, preview snippet, flagged star, location label). The _fmtDate date-formatting cache previously duplicated in both screens is now owned by this widget.
  • EmailThread.fromEmail(Email e) factory added to lib/core/models/email.dart — maps a single Email to a one-message EmailThread so search results can be fed to ThreadTile without changing the repository layer.
  • EmailListScreen and CombinedInboxScreen inline ListTile blocks replaced with ThreadTile. Dismissible wrappers and all selection/swipe logic stay in the screens.
  • SearchScreen and EmailListScreen._buildEmailList() now convert Email → EmailThread.fromEmail() and use ThreadTile.
  • EmailTile deleted — no longer has any usages.

Verification

dart analyze on all changed files reports no issues.

## Summary Closes #429 There were three separate places that rendered a mail row: - `EmailTile` — used in `SearchScreen` and `EmailListScreen._buildEmailList()`, accepted an `Email` object - Inline `ListTile` in `EmailListScreen._buildThreadList()` — accepted an `EmailThread` - Inline `ListTile` in `CombinedInboxScreen._buildThreadTile()` — accepted an `EmailThread` ## What changed - **New `lib/ui/widgets/thread_tile.dart`** — a single `ThreadTile` widget that renders an `EmailThread` with all the thread-level features (message count badge, preview snippet, flagged star, location label). The `_fmtDate` date-formatting cache previously duplicated in both screens is now owned by this widget. - **`EmailThread.fromEmail(Email e)` factory** added to `lib/core/models/email.dart` — maps a single `Email` to a one-message `EmailThread` so search results can be fed to `ThreadTile` without changing the repository layer. - **`EmailListScreen`** and **`CombinedInboxScreen`** inline `ListTile` blocks replaced with `ThreadTile`. `Dismissible` wrappers and all selection/swipe logic stay in the screens. - **`SearchScreen`** and **`EmailListScreen._buildEmailList()`** now convert `Email` → `EmailThread.fromEmail()` and use `ThreadTile`. - **`EmailTile` deleted** — no longer has any usages. ## Verification `dart analyze` on all changed files reports no issues.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#445