Fix CI of Chaos monkey pr #456

Closed
opened 2026-06-05 20:50:03 +00:00 by guettli · 1 comment
guettli commented 2026-06-05 20:50:03 +00:00 (Migrated from codeberg.org)
https://codeberg.org/guettli/sharedinbox/pulls/455
guettlibot commented 2026-06-05 21:35:02 +00:00 (Migrated from codeberg.org)

The PR is open at https://codeberg.org/guettli/sharedinbox/pulls/458.


What I did:

The CI failures for PR #455 (chaos monkey backend test) were caused by dart analyze --fatal-infos rejecting three categories of lint violations in test/backend/chaos_monkey_test.dart:

  1. avoid_print — 5 print(...) calls replaced with stdout.writeln(...) (dart:io was already imported)
  2. avoid_redundant_argument_values_env('CHAOS_SEED', '') simplified to _env('CHAOS_SEED') since '' is the function's default
  3. dart format — trailing commas added and long connectToServer(...) calls wrapped to fit the 80-char limit

After the fixes, fvm dart analyze --fatal-infos reports No issues found! and the formatter confirms the file is clean.

The PR is open at https://codeberg.org/guettli/sharedinbox/pulls/458. --- **What I did:** The CI failures for PR #455 (chaos monkey backend test) were caused by `dart analyze --fatal-infos` rejecting three categories of lint violations in `test/backend/chaos_monkey_test.dart`: 1. **`avoid_print`** — 5 `print(...)` calls replaced with `stdout.writeln(...)` (`dart:io` was already imported) 2. **`avoid_redundant_argument_values`** — `_env('CHAOS_SEED', '')` simplified to `_env('CHAOS_SEED')` since `''` is the function's default 3. **`dart format`** — trailing commas added and long `connectToServer(...)` calls wrapped to fit the 80-char limit After the fixes, `fvm dart analyze --fatal-infos` reports `No issues found!` and the formatter confirms the file is clean.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#456