Allow to load images, snack bar does not disappear #484

Closed
opened 2026-06-06 15:07:27 +00:00 by guettli · 2 comments
guettli commented 2026-06-06 15:07:27 +00:00 (Migrated from codeberg.org)

View and comment on the plan

I view a single Mail. I press

Load remote images

First update agent loop, fix search bug.

A snack bar with link to settings appears.

The snack bar does not disappear again.

It should disappear after some (maybe 3) seconds.



Agentloop runs

# Started (UTC) Ended (UTC) Status Tokens in Tokens out
1 2026-06-07 18:07:55 2026-06-08 14:19:38 success 42 17 591
2 2026-06-08 17:04:01 2026-06-08 17:29:00 success 114 48 634
<!-- agentloop:plan --> [View and comment on the plan](https://codeberg.org/guettli/sharedinbox/pulls/545/files) <!-- /agentloop:plan --> I view a single Mail. I press Load remote images First update agent loop, fix search bug. A snack bar with link to settings appears. The snack bar does not disappear again. It should disappear after some (maybe 3) seconds. --- --- <!-- agentloop-summary --> **Agentloop runs** | # | Started (UTC) | Ended (UTC) | Status | Tokens in | Tokens out | |---|---------------------|---------------------|---------|-----------|------------| | 1 | 2026-06-07 18:07:55 | 2026-06-08 14:19:38 | success | 42 | 17 591 | | 2 | 2026-06-08 17:04:01 | 2026-06-08 17:29:00 | success | 114 | 48 634 |
guettlibot commented 2026-06-07 18:07:57 +00:00 (Migrated from codeberg.org)

agentloop: the agent run did not complete (no result was produced).

agentloop: the agent run did not complete (no result was produced).
guettlibot commented 2026-06-08 17:29:00 +00:00 (Migrated from codeberg.org)

PR #548 is open: https://codeberg.org/guettli/sharedinbox/pulls/548

Summary

Root cause: Flutter's SnackBar defaults to persist: true whenever an action is provided. Inside ScaffoldMessengerState.build, the duration timer's callback explicitly returns early when snackBar.persist is true — so the duration: 3s set on the "Load remote images" snack bar was being silently ignored because the "View" action made it persistent.

Fix: pass persist: false explicitly on the two affected snack bars (lib/ui/screens/email_detail_screen.dart and lib/ui/screens/thread_detail_screen.dart). The "View" action button still navigates to /accounts/trusted-senders; only the auto-dismiss behavior is restored.

Verified locally: 174 widget tests pass (including the two new regression tests), 552 unit tests pass, dart analyze and dart format are clean. PR: https://codeberg.org/guettli/sharedinbox/pulls/548

agentloop · agent: claude

PR #548 is open: https://codeberg.org/guettli/sharedinbox/pulls/548 ## Summary Root cause: Flutter's `SnackBar` defaults to `persist: true` whenever an `action` is provided. Inside `ScaffoldMessengerState.build`, the duration timer's callback explicitly returns early when `snackBar.persist` is true — so the `duration: 3s` set on the "Load remote images" snack bar was being silently ignored because the "View" action made it persistent. Fix: pass `persist: false` explicitly on the two affected snack bars (`lib/ui/screens/email_detail_screen.dart` and `lib/ui/screens/thread_detail_screen.dart`). The "View" action button still navigates to `/accounts/trusted-senders`; only the auto-dismiss behavior is restored. Verified locally: 174 widget tests pass (including the two new regression tests), 552 unit tests pass, `dart analyze` and `dart format` are clean. PR: https://codeberg.org/guettli/sharedinbox/pulls/548 <sub>agentloop · agent: claude</sub>
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#484