Thomas GüttlerandClaude Sonnet 4.6
03d35387f7
Linting:
- analysis_options.yaml: flutter_lints base + 20 additional rules
(prefer_single_quotes, avoid_print, cancel_subscriptions,
unawaited_futures, empty_catches, always_declare_return_types, …)
- unused_import / dead_code treated as errors
pubspec.yaml:
- Remove 6 unused packages: freezed, freezed_annotation, json_annotation,
json_serializable, riverpod_generator, collection
- Add test: ^1.25.0 for pure-Dart unit tests
Testable utilities (extracted from screen code):
- lib/core/utils/html_utils.dart — htmlToPlain()
- lib/core/utils/format_utils.dart — fmtSize()
- lib/core/utils/logger.dart — thin debugPrint wrapper
Unit tests (test/unit/, no device required):
- html_utils_test.dart — 13 cases covering tags, entities, edge cases
- format_utils_test.dart — B / KB / MB / GB formatting
- email_model_test.dart — EmailAddress JSON roundtrip, toString, EmailDraft
- account_sync_backoff_test.dart — exponential backoff + clamping
Taskfile:
- task test → dart test test/unit/ (fast, no device)
- task test-flutter → flutter test (widget tests)
- task check → analyze + unit tests in parallel
README rewrite:
- Covers user flow (download, add account)
- Developer flow: nix develop, direnv allow, task codegen, task check
- Platform status table (Linux done, others pending)
- Project layout diagram
- Schema-change workflow
CI (.github/workflows/ci.yml):
- analyze-and-test job: flutter analyze + dart test on every push/PR
- integration job: Nix + Stalwart on push to main
- build-linux job: flutter build linux --release
Logging:
- Replace all bare catch (_) {} with log() calls
- Sync backoff errors now print account email + retry delay
- STATUS failures on \Noselect mailboxes logged at debug level
- STARTTLS failures logged before continuing without TLS
.gitignore:
- Add .direnv/, .flutter-plugins-dependencies
- Add all platform generated-plugin wiring files
- Add .env / .env.local
- Add linux/build/
.env.example: documents optional STALWART_PORT overrides
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
42 lines
1.1 KiB
Dart
42 lines
1.1 KiB
Dart
// Tests for the exponential-backoff clamping logic used in AccountSyncManager.
|
|
// The manager itself requires Flutter DI, so we test the math standalone.
|
|
|
|
import 'package:test/test.dart';
|
|
|
|
int nextBackoff(int current) => (current * 2).clamp(5, 300);
|
|
|
|
void main() {
|
|
group('sync backoff', () {
|
|
test('starts at 5 seconds', () {
|
|
expect(5, 5);
|
|
});
|
|
|
|
test('doubles each failure', () {
|
|
var backoff = 5;
|
|
backoff = nextBackoff(backoff);
|
|
expect(backoff, 10);
|
|
backoff = nextBackoff(backoff);
|
|
expect(backoff, 20);
|
|
backoff = nextBackoff(backoff);
|
|
expect(backoff, 40);
|
|
backoff = nextBackoff(backoff);
|
|
expect(backoff, 80);
|
|
backoff = nextBackoff(backoff);
|
|
expect(backoff, 160);
|
|
});
|
|
|
|
test('clamps at 300 seconds (5 minutes)', () {
|
|
var backoff = 5;
|
|
for (var i = 0; i < 20; i++) {
|
|
backoff = nextBackoff(backoff);
|
|
}
|
|
expect(backoff, 300);
|
|
});
|
|
|
|
test('never goes below 5 seconds', () {
|
|
expect(nextBackoff(1), 5);
|
|
expect(nextBackoff(0), 5);
|
|
});
|
|
});
|
|
}
|