Thomas GüttlerandClaude Sonnet 4.6
03d35387f7
Linting:
- analysis_options.yaml: flutter_lints base + 20 additional rules
(prefer_single_quotes, avoid_print, cancel_subscriptions,
unawaited_futures, empty_catches, always_declare_return_types, …)
- unused_import / dead_code treated as errors
pubspec.yaml:
- Remove 6 unused packages: freezed, freezed_annotation, json_annotation,
json_serializable, riverpod_generator, collection
- Add test: ^1.25.0 for pure-Dart unit tests
Testable utilities (extracted from screen code):
- lib/core/utils/html_utils.dart — htmlToPlain()
- lib/core/utils/format_utils.dart — fmtSize()
- lib/core/utils/logger.dart — thin debugPrint wrapper
Unit tests (test/unit/, no device required):
- html_utils_test.dart — 13 cases covering tags, entities, edge cases
- format_utils_test.dart — B / KB / MB / GB formatting
- email_model_test.dart — EmailAddress JSON roundtrip, toString, EmailDraft
- account_sync_backoff_test.dart — exponential backoff + clamping
Taskfile:
- task test → dart test test/unit/ (fast, no device)
- task test-flutter → flutter test (widget tests)
- task check → analyze + unit tests in parallel
README rewrite:
- Covers user flow (download, add account)
- Developer flow: nix develop, direnv allow, task codegen, task check
- Platform status table (Linux done, others pending)
- Project layout diagram
- Schema-change workflow
CI (.github/workflows/ci.yml):
- analyze-and-test job: flutter analyze + dart test on every push/PR
- integration job: Nix + Stalwart on push to main
- build-linux job: flutter build linux --release
Logging:
- Replace all bare catch (_) {} with log() calls
- Sync backoff errors now print account email + retry delay
- STATUS failures on \Noselect mailboxes logged at debug level
- STARTTLS failures logged before continuing without TLS
.gitignore:
- Add .direnv/, .flutter-plugins-dependencies
- Add all platform generated-plugin wiring files
- Add .env / .env.local
- Add linux/build/
.env.example: documents optional STALWART_PORT overrides
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
50 lines
1.2 KiB
YAML
50 lines
1.2 KiB
YAML
include: package:flutter_lints/flutter.yaml
|
|
|
|
analyzer:
|
|
errors:
|
|
# Treat these as errors, not warnings.
|
|
unused_import: error
|
|
unused_local_variable: error
|
|
dead_code: error
|
|
exclude:
|
|
- lib/data/db/database.g.dart
|
|
- "**/*.g.dart"
|
|
- "**/*.freezed.dart"
|
|
|
|
linter:
|
|
rules:
|
|
# Style
|
|
- prefer_single_quotes
|
|
- prefer_const_constructors
|
|
- prefer_const_declarations
|
|
- prefer_const_collections
|
|
- prefer_final_locals
|
|
- prefer_final_in_for_each
|
|
- unnecessary_const
|
|
- unnecessary_new
|
|
- unnecessary_this
|
|
- avoid_redundant_argument_values
|
|
|
|
# Safety
|
|
- avoid_catching_errors
|
|
- avoid_dynamic_calls
|
|
- avoid_empty_else
|
|
- avoid_print
|
|
- avoid_returning_null_for_future
|
|
- avoid_returning_null_for_void
|
|
- avoid_type_to_string
|
|
- cancel_subscriptions
|
|
- close_sinks
|
|
- literal_only_boolean_expressions
|
|
- no_duplicate_case_values
|
|
- throw_in_finally
|
|
- unawaited_futures
|
|
|
|
# Correctness
|
|
- always_declare_return_types
|
|
- annotate_overrides
|
|
- empty_catches # flag silent catch{} — use comment if intentional
|
|
- hash_and_equals
|
|
- use_rethrow_when_possible
|
|
- valid_regexps
|