fix(tests): suppress ink_sparkle shader crash in crash screen and about screen

CrashScreen creates its own MaterialApp which was loading InkSparkle on first tap. Also fixes about_screen_test._buildScreen to use a themed MaterialApp with NoSplash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix(tests): suppress ink_sparkle shader crash in software rendering
2026-06-07 04:03:30 +02:00 · 2026-06-07 03:58:03 +02:00 · 2026-06-07 03:53:46 +02:00 · 2026-06-07 03:48:56 +02:00 · 2026-06-07 03:29:40 +02:00 · 2026-06-07 03:16:43 +02:00
11 changed files with 35 additions and 99 deletions
@@ -22,14 +22,7 @@ jobs:
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -24,14 +24,7 @@ jobs:
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -174,14 +167,7 @@ for r in data.get('workflow_runs', []):
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -232,14 +218,7 @@ for r in data.get('workflow_runs', []):
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -284,14 +263,7 @@ for r in data.get('workflow_runs', []):
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -341,14 +313,7 @@ for r in data.get('workflow_runs', []):
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -23,14 +23,7 @@ jobs:
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -83,14 +76,7 @@ for r in data.get('workflow_runs', []):
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -27,14 +27,7 @@ jobs:
          created_at=$(curl -sf \
            -H "Authorization: token $FORGEJO_TOKEN" \
            "${{ github.server_url }}/api/v1/repos/${{ github.repository }}/actions/tasks?limit=100" \
-            | python3 -c "
-import sys, json
-data = json.load(sys.stdin)
-for r in data.get('workflow_runs', []):
-    if r.get('run_number') == $RUN_NUMBER:
-        print(r['created_at'])
-        break
-" 2>/dev/null)
+            | python3 -c "import sys,json;data=json.load(sys.stdin);rs=[r for r in data.get('workflow_runs',[]) if r.get('run_number')==$RUN_NUMBER];print(rs[0]['created_at'] if rs else '')" 2>/dev/null)
          if [ -n "$created_at" ]; then
            queued_epoch=$(date -d "$created_at" +%s)
            wait_seconds=$((runner_start - queued_epoch))
@@ -539,7 +539,7 @@ func (m *Ci) TestBackend(ctx context.Context) (string, error) {
 	return m.WithStalwart(m.setup(m.backendSrc())).
 		WithExec([]string{"/bin/bash", "-c",
 			`tmp=$(mktemp); trap 'rm -f "$tmp"' EXIT; ` +
-				`flutter test --concurrency=1 --reporter expanded --no-pub test/backend >"$tmp" 2>&1 || { cat "$tmp"; exit 1; }; ` +
+				`flutter test --concurrency=1 --reporter expanded --no-pub --exclude-tags=nightly test/backend >"$tmp" 2>&1 || { cat "$tmp"; exit 1; }; ` +
 				`grep -E '^All [0-9]+ tests passed' "$tmp" || tail -1 "$tmp"`}).
 		Stdout(ctx)
 }
@@ -570,7 +570,7 @@ func (m *Ci) ChaosMonkeyBackend(ctx context.Context) (string, error) {
 	return m.WithStalwart(m.setup(m.backendSrc())).
 		WithExec([]string{"/bin/bash", "-c",
 			`tmp=$(mktemp); trap 'rm -f "$tmp"' EXIT; ` +
-				`flutter test test/backend/chaos_monkey_test.dart --reporter expanded --concurrency=1 --no-pub >"$tmp" 2>&1 || { cat "$tmp"; exit 1; }; ` +
+				`flutter test test/backend/chaos_monkey_test.dart --reporter expanded --concurrency=1 --no-pub --tags=nightly >"$tmp" 2>&1 || { cat "$tmp"; exit 1; }; ` +
 				`grep -E '^All [0-9]+ tests passed' "$tmp" || tail -1 "$tmp"`}).
 		Stdout(ctx)
 }
@@ -2952,16 +2952,12 @@ class EmailRepositoryImpl implements EmailRepository {
    String? mailboxPath,
    String query,
  ) async {
-    final words = query
-        .trim()
-        .split(RegExp(r'\s+'))
-        .where((w) => w.isNotEmpty)
-        .toList();
+    final words =
+        query.trim().split(RegExp(r'\s+')).where((w) => w.isNotEmpty).toList();
    if (words.isEmpty) return [];

    final noteConditions = words.map((_) => 'n.note_text LIKE ?').join(' AND ');
-    final likeVars =
-        words.map((w) => Variable<String>('%$w%')).toList();
+    final likeVars = words.map((w) => Variable<String>('%$w%')).toList();

    final extraConditions = StringBuffer();
    final extraVars = <Variable<String>>[];
@@ -2980,14 +2976,13 @@ class EmailRepositoryImpl implements EmailRepository {
        ' WHERE $noteConditions$extraConditions'
        ' ORDER BY e.received_at DESC LIMIT 50';

-    final rows = await _db
-        .customSelect(
-          sql,
-          variables: [...likeVars, ...extraVars],
-          readsFrom: {_db.emails, _db.emailNotes},
-        )
-        .get();
-    final emailRows = await Future.wait(rows.map((r) => _db.emails.mapFromRow(r)));
+    final rows = await _db.customSelect(
+      sql,
+      variables: [...likeVars, ...extraVars],
+      readsFrom: {_db.emails, _db.emailNotes},
+    ).get();
+    final emailRows =
+        await Future.wait(rows.map((r) => _db.emails.mapFromRow(r)));
    return emailRows.map(_toModel).toList();
  }

@@ -2997,9 +2992,7 @@ class EmailRepositoryImpl implements EmailRepository {
  static String _toFtsQuery(String query) {
    final words = query
        .trim()
-        .split(RegExp(r'\s+'))
-        .where((w) => w.isNotEmpty)
-        .map((w) => w.replaceAll(RegExp(r'[^\w]'), ''))
+        .split(RegExp(r'[^\w]+'))
        .where((w) => w.isNotEmpty)
        .toList();
    if (words.isEmpty) return '';
@@ -3126,8 +3119,7 @@ class EmailRepositoryImpl implements EmailRepository {
      queryRows.map((r) => _db.emails.mapFromRow(r)),
    );

-    final noteRows =
-        await _searchEmailsByNotes(accountId, mailboxPath, query);
+    final noteRows = await _searchEmailsByNotes(accountId, mailboxPath, query);

    final seen = <String>{};
    final merged = <model.Email>[];
@@ -109,6 +109,7 @@ class _SharedInboxAppState extends ConsumerState<SharedInboxApp> {
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.indigo),
        useMaterial3: true,
+        splashFactory: NoSplash.splashFactory,
      ),
      darkTheme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
@@ -116,6 +117,7 @@ class _SharedInboxAppState extends ConsumerState<SharedInboxApp> {
          brightness: Brightness.dark,
        ),
        useMaterial3: true,
+        splashFactory: NoSplash.splashFactory,
      ),
      routerConfig: router,
    );
@@ -57,6 +57,7 @@ class CrashScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
+      theme: ThemeData(splashFactory: NoSplash.splashFactory),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Something went wrong'),
@@ -10,6 +10,9 @@
 //   CHAOS_ROUNDS  (default: 30) — number of random operations to perform
 //   CHAOS_SEED    (default: current epoch ms) — seed for reproducibility

+@Tags(['nightly'])
+library;
+
 import 'dart:io';
 import 'dart:math';

@@ -514,8 +514,7 @@ void main() {
            ),
          );

-      final results =
-          await r.emails.searchEmailsGlobal(null, 'urgent');
+      final results = await r.emails.searchEmailsGlobal(null, 'urgent');
      expect(results, hasLength(1));
      expect(results.first.subject, 'Weekly report');
    });
@@ -569,8 +568,7 @@ void main() {
            ),
          );

-      final results =
-          await r.emails.searchEmails('acc-1', 'INBOX', 'client');
+      final results = await r.emails.searchEmails('acc-1', 'INBOX', 'client');
      expect(results, hasLength(1));
      expect(results.first.subject, 'Project update');
      expect(results.first.mailboxPath, 'INBOX');
@@ -50,7 +50,10 @@ Widget _buildScreen({List<Account> accounts = const []}) {
        FakeAccountRepository(accounts),
      ),
    ],
-    child: const MaterialApp(home: AboutScreen()),
+    child: MaterialApp(
+      theme: ThemeData(splashFactory: NoSplash.splashFactory),
+      home: const AboutScreen(),
+    ),
  );
 }
Author	SHA1	Message	Date
Thomas SharedInboxandClaude Sonnet 4.6	fdafe799eb	fix(tests): suppress ink_sparkle shader crash in crash screen and about screen CrashScreen creates its own MaterialApp which was loading InkSparkle on first tap. Also fixes about_screen_test._buildScreen to use a themed MaterialApp with NoSplash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 04:03:30 +02:00
Thomas SharedInboxandClaude Sonnet 4.6	7646b28f8d	fix(tests): suppress ink_sparkle shader crash in software rendering Integration tests under software rendering (LIBGL_ALWAYS_SOFTWARE=1) crash with an INVALID_ARGUMENT error when the Material 3 ink_sparkle ripple shader is compiled. Disable it via splashFactory: NoSplash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 03:58:03 +02:00
Thomas SharedInboxandClaude Sonnet 4.6	98f20a2191	fix(search): fix _toFtsQuery to split on non-word chars instead of stripping The old implementation stripped non-word chars within tokens, causing 'searchable-{timestamp}' to become 'searchable{timestamp}*'. FTS5 tokenizes on hyphens so the merged token never matched. Fix: split on [^\w]+ so each FTS token is queried separately. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 03:53:46 +02:00
Thomas SharedInboxandClaude Sonnet 4.6	6ad8cbf600	fix(ci): fix YAML parse errors in deploy, firebase-tests, website workflows The multi-line python3 -c blocks had unindented Python code that terminated YAML block scalars. Inline as one-liners. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 03:48:56 +02:00
Thomas SharedInboxandClaude Sonnet 4.6	f1f4171306	fix(ci): fix YAML parse error in Print runner wait time step The multi-line python3 -c block had unindented Python code that terminated the YAML block scalar, causing a preExecutionError on every CI run. Inline the Python as a one-liner. Also apply dart format to email_repository_impl.dart and email_repository_impl_test.dart (reformatted by CI container). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 03:29:40 +02:00
Thomas SharedInbox	92161f74fc	Merge remote-tracking branch 'origin/main' into fix-518	2026-06-07 03:16:43 +02:00
ClaudeandClaude Sonnet 4.6	5de1030899	fix(ci): exclude chaos_monkey_test from regular CI (TestBackend) Tag chaos_monkey_test.dart with @Tags(['nightly']) and add --exclude-tags=nightly to TestBackend so it no longer runs on every PR push. ChaosMonkeyBackend keeps --tags=nightly to ensure the nightly workflow still exercises the test. Closes #505 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-07 00:43:29 +00:00