perf(P4): add indexes on mailboxes(account_id) and threads(latest_date)

Schema v25: adds mailboxes_account_id covering (account_id, path) for
observeMailboxes and threads_latest_date covering (account_id,
mailbox_path, latest_date DESC) for observeThreads, replacing full-table
scans on both tables.  Migration test updated with a complete v22 schema
fixture and index assertions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Taskfile.yml

@@ -331,6 +331,12 @@ tasks:
     cmds:
       - fvm dart run scripts/check_coverage.dart
 
+  check-coverage:
+    desc: Run unit+widget tests with coverage, then fail if the gate is not met
+    deps: [test]
+    cmds:
+      - task: coverage
+
   website-dev:
     desc: Run Hugo development server
     cmds:
@@ -361,8 +367,8 @@ tasks:
           ${SSH_USER}@${SSH_HOST}:public_html/
 
   check-fast:
-    desc: Pre-commit checks — analyze + unit tests + widget tests (no build, no integration)
-    deps: [analyze, test, check-hygiene]
+    desc: Pre-commit checks — analyze + unit+widget tests + coverage gate (no build, no integration)
+    deps: [analyze, check-coverage, check-hygiene]
 
   check-hygiene:
     desc: Verify that no forbidden files (like home dir config) are tracked

lib/data/db/database.dart

@@ -269,7 +269,7 @@ class AppDatabase extends _$AppDatabase {
   AppDatabase([QueryExecutor? executor]) : super(executor ?? _openConnection());
 
   @override
-  int get schemaVersion => 24;
+  int get schemaVersion => 25;
 
   @override
   MigrationStrategy get migration => MigrationStrategy(
@@ -431,6 +431,22 @@ class AppDatabase extends _$AppDatabase {
           if (from >= 4 && from < 24) {
             await m.addColumn(drafts, drafts.imapServerId);
           }
+          if (from < 25) {
+            // For observeMailboxes: filter by account_id, sort by path.
+            await m.createIndex(
+              Index(
+                'mailboxes_account_id',
+                'CREATE INDEX IF NOT EXISTS mailboxes_account_id ON mailboxes (account_id, path);',
+              ),
+            );
+            // For observeThreads: filter by account_id+mailbox_path, sort by latest_date.
+            await m.createIndex(
+              Index(
+                'threads_latest_date',
+                'CREATE INDEX IF NOT EXISTS threads_latest_date ON threads (account_id, mailbox_path, latest_date DESC);',
+              ),
+            );
+          }
         },
       );
 }

lib/ui/screens/email_list_screen.dart

@@ -10,6 +10,7 @@ import 'package:sharedinbox/core/models/email.dart';
 import 'package:sharedinbox/core/models/undo_action.dart';
 import 'package:sharedinbox/core/repositories/email_repository.dart';
 import 'package:sharedinbox/di.dart';
+import 'package:sharedinbox/ui/widgets/email_tile.dart';
 import 'package:sharedinbox/ui/widgets/folder_drawer.dart';
 import 'package:sharedinbox/ui/widgets/snooze_picker.dart';
 
@@ -711,10 +712,9 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
       itemBuilder: (ctx, i) {
         final e = emails[i];
         final isSelected = _selectedSearchIds.contains(e.id);
-        final sender = e.from.isNotEmpty
-            ? (e.from.first.name ?? e.from.first.email)
-            : '(unknown)';
-        return ListTile(
+        return EmailTile(
+          email: e,
+          selected: isSelected,
           leading: SizedBox(
             width: 40,
             child: _selecting
@@ -722,25 +722,7 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
                     value: isSelected,
                     onChanged: (_) => _toggleSearchSelection(e.id),
                   )
-                : Icon(
-                    e.isSeen ? Icons.mail_outline : Icons.mail,
-                    color: e.isSeen ? null : Theme.of(ctx).colorScheme.primary,
-                  ),
-          ),
-          title: Text(
-            sender,
-            style:
-                e.isSeen ? null : const TextStyle(fontWeight: FontWeight.bold),
-          ),
-          subtitle: Text(
-            e.subject ?? '(no subject)',
-            maxLines: 1,
-            overflow: TextOverflow.ellipsis,
-          ),
-          selected: isSelected,
-          trailing: Text(
-            e.sentAt != null ? _dateFmt.format(e.sentAt!) : '',
-            style: Theme.of(ctx).textTheme.bodySmall,
+                : null,
           ),
           onTap: _selecting
               ? () => _toggleSearchSelection(e.id)

lib/ui/screens/search_screen.dart

@@ -8,6 +8,7 @@ import 'package:sharedinbox/core/models/email.dart';
 import 'package:sharedinbox/core/models/mailbox.dart';
 import 'package:sharedinbox/core/utils/logger.dart';
 import 'package:sharedinbox/di.dart';
+import 'package:sharedinbox/ui/widgets/email_tile.dart';
 
 class SearchScreen extends ConsumerStatefulWidget {
   const SearchScreen({super.key, this.accountId});
@@ -155,7 +156,15 @@ class _SearchScreenState extends ConsumerState<SearchScreen> {
         if (r.emails.isNotEmpty) ...[
           const _SectionHeader('Messages'),
           for (final e in r.emails)
-            _EmailTile(email: e, accountId: e.accountId),
+            EmailTile(
+              email: e,
+              showLocation: true,
+              onTap: () => context.push(
+                '/accounts/${e.accountId}/mailboxes'
+                '/${Uri.encodeComponent(e.mailboxPath)}'
+                '/emails/${Uri.encodeComponent(e.id)}',
+              ),
+            ),
         ],
       ],
     );
@@ -246,42 +255,3 @@ class _AddressTile extends StatelessWidget {
     );
   }
 }
-
-class _EmailTile extends StatelessWidget {
-  const _EmailTile({required this.email, required this.accountId});
-  final Email email;
-  final String accountId;
-
-  @override
-  Widget build(BuildContext context) {
-    final sender = email.from.isNotEmpty
-        ? (email.from.first.name ?? email.from.first.email)
-        : '(unknown)';
-    return ListTile(
-      leading: Icon(
-        email.isSeen ? Icons.mail_outline : Icons.mail,
-        color: email.isSeen ? null : Theme.of(context).colorScheme.primary,
-      ),
-      title: Text(sender),
-      subtitle: Column(
-        crossAxisAlignment: CrossAxisAlignment.start,
-        children: [
-          Text(
-            email.subject ?? '(no subject)',
-            maxLines: 1,
-            overflow: TextOverflow.ellipsis,
-          ),
-          Text(
-            '$accountId • ${email.mailboxPath}',
-            style: Theme.of(context).textTheme.bodySmall,
-          ),
-        ],
-      ),
-      onTap: () => context.push(
-        '/accounts/$accountId/mailboxes'
-        '/${Uri.encodeComponent(email.mailboxPath)}'
-        '/emails/${Uri.encodeComponent(email.id)}',
-      ),
-    );
-  }
-}

lib/ui/widgets/email_tile.dart

@@ -0,0 +1,74 @@
+import 'package:flutter/material.dart';
+import 'package:intl/intl.dart';
+
+import 'package:sharedinbox/core/models/email.dart';
+
+final _dateFmt = DateFormat('MMM d');
+
+/// A flat list tile for an individual [email].
+///
+/// Used in search-result lists and the per-mailbox search overlay.
+/// Pass a custom [leading] widget to support selection-mode checkboxes.
+class EmailTile extends StatelessWidget {
+  const EmailTile({
+    super.key,
+    required this.email,
+    required this.onTap,
+    this.leading,
+    this.selected = false,
+    this.onLongPress,
+    this.showLocation = false,
+  });
+
+  final Email email;
+  final VoidCallback onTap;
+  final Widget? leading;
+  final bool selected;
+  final VoidCallback? onLongPress;
+
+  /// When true, appends `accountId • mailboxPath` as a second subtitle line.
+  final bool showLocation;
+
+  @override
+  Widget build(BuildContext context) {
+    final sender = email.from.isNotEmpty
+        ? (email.from.first.name ?? email.from.first.email)
+        : '(unknown)';
+    final date = email.sentAt != null ? _dateFmt.format(email.sentAt!) : '';
+
+    return ListTile(
+      leading: leading ??
+          Icon(
+            email.isSeen ? Icons.mail_outline : Icons.mail,
+            color: email.isSeen ? null : Theme.of(context).colorScheme.primary,
+          ),
+      title: Text(
+        sender,
+        style:
+            email.isSeen ? null : const TextStyle(fontWeight: FontWeight.bold),
+        overflow: TextOverflow.ellipsis,
+      ),
+      subtitle: Column(
+        crossAxisAlignment: CrossAxisAlignment.start,
+        children: [
+          Text(
+            email.subject ?? '(no subject)',
+            maxLines: 1,
+            overflow: TextOverflow.ellipsis,
+          ),
+          if (showLocation)
+            Text(
+              '${email.accountId} • ${email.mailboxPath}',
+              style: Theme.of(context).textTheme.bodySmall,
+            ),
+        ],
+      ),
+      trailing: date.isEmpty
+          ? null
+          : Text(date, style: Theme.of(context).textTheme.bodySmall),
+      selected: selected,
+      onTap: onTap,
+      onLongPress: onLongPress,
+    );
+  }
+}

test/unit/migration_test.dart

@@ -14,7 +14,7 @@ void main() {
   group('Migration', () {
     test('schemaVersion matches expected value', () async {
       final db = AppDatabase(NativeDatabase.memory());
-      expect(db.schemaVersion, 24);
+      expect(db.schemaVersion, 25);
       await db.close();
     });
 
@@ -141,6 +141,23 @@ void main() {
         ]),
       );
 
+      // v18, v22, v25: indexes.
+      final allIndexes = await db
+          .customSelect("SELECT name FROM sqlite_master WHERE type='index'")
+          .get();
+      final indexNames = allIndexes.map((r) => r.read<String>('name')).toSet();
+      expect(
+        indexNames,
+        containsAll([
+          'emails_received_at', // v18
+          'emails_thread_id', // v18
+          'pending_changes_account_id', // v18
+          'emails_snoozed_until', // v22
+          'mailboxes_account_id', // v25
+          'threads_latest_date', // v25
+        ]),
+      );
+
       await db.close();
       if (dbFile.existsSync()) dbFile.deleteSync();
     });
@@ -186,6 +203,17 @@ void main() {
           updated_at INTEGER NOT NULL
         );
       ''');
+      rawDb.execute('''
+        CREATE TABLE mailboxes (
+          id TEXT NOT NULL PRIMARY KEY,
+          account_id TEXT NOT NULL,
+          path TEXT NOT NULL,
+          name TEXT NOT NULL,
+          unread_count INTEGER NOT NULL DEFAULT 0,
+          total_count INTEGER NOT NULL DEFAULT 0,
+          role TEXT NULL
+        );
+      ''');
       rawDb.execute('''
         CREATE TABLE emails (
           id TEXT NOT NULL PRIMARY KEY,
@@ -210,6 +238,23 @@ void main() {
           snoozed_from_mailbox_path TEXT NULL
         );
       ''');
+      rawDb.execute('''
+        CREATE TABLE threads (
+          account_id TEXT NOT NULL,
+          mailbox_path TEXT NOT NULL,
+          id TEXT NOT NULL,
+          subject TEXT NULL,
+          latest_date INTEGER NOT NULL,
+          message_count INTEGER NOT NULL DEFAULT 1,
+          has_unread INTEGER NOT NULL DEFAULT 0 CHECK ("has_unread" IN (0, 1)),
+          is_flagged INTEGER NOT NULL DEFAULT 0 CHECK ("is_flagged" IN (0, 1)),
+          participants_json TEXT NOT NULL DEFAULT '[]',
+          preview TEXT NULL,
+          latest_email_id TEXT NOT NULL,
+          email_ids_json TEXT NOT NULL DEFAULT '[]',
+          PRIMARY KEY (account_id, mailbox_path, id)
+        );
+      ''');
       rawDb.execute('PRAGMA user_version = 22;');
       rawDb.close();
 
@@ -223,11 +268,19 @@ void main() {
       final draftColumns = await _tableColumns(db, 'drafts');
       expect(draftColumns, contains('imap_server_id'));
 
+      // v25: new indexes on mailboxes and threads.
+      final allIndexes = await db
+          .customSelect("SELECT name FROM sqlite_master WHERE type='index'")
+          .get();
+      final indexNames = allIndexes.map((r) => r.read<String>('name')).toSet();
+      expect(indexNames, contains('mailboxes_account_id'));
+      expect(indexNames, contains('threads_latest_date'));
+
       await db.close();
       if (dbFile.existsSync()) dbFile.deleteSync();
     });
 
-    test('fresh install creates all tables at schemaVersion 24', () async {
+    test('fresh install creates all tables at schemaVersion 25', () async {
       final db = AppDatabase(NativeDatabase.memory());
       await db.select(db.accounts).get();