feat: recent searches history in SearchScreen (U3)

Store last 10 search queries in a new search_history_entries DB table
(schema v27). Show them as chips below the search field when it is
focused and empty; tapping a chip re-runs the search. Add a "Clear"
button to wipe all history.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lib/core/repositories/email_repository.dart

@@ -27,7 +27,6 @@ abstract class EmailRepository {
   Future<EmailBody> getEmailBody(String emailId);
   Future<SyncEmailsResult> syncEmails(String accountId, String mailboxPath);
   Future<void> setFlag(String emailId, {bool? seen, bool? flagged});
-  Future<void> markAllAsRead(String accountId, String mailboxPath);
   Future<void> moveEmail(String emailId, String destMailboxPath);
 
   /// Deletes the email. Returns the path of the mailbox it was moved to

lib/data/repositories/email_repository_impl.dart

@@ -1520,63 +1520,6 @@ class EmailRepositoryImpl implements EmailRepository {
     );
   }
 
-  @override
-  Future<void> markAllAsRead(String accountId, String mailboxPath) async {
-    final account = (await _accounts.getAccount(accountId))!;
-    final unread = await (_db.select(_db.emails)
-          ..where(
-            (t) =>
-                t.accountId.equals(accountId) &
-                t.mailboxPath.equals(mailboxPath) &
-                t.isSeen.equals(false),
-          ))
-        .get();
-    if (unread.isEmpty) return;
-
-    await _db.transaction(() async {
-      for (final row in unread) {
-        if (account.type == account_model.AccountType.jmap) {
-          await _enqueueChange(
-            accountId,
-            row.id,
-            'flag_seen',
-            jsonEncode({'seen': true}),
-          );
-        } else {
-          await _enqueueChange(
-            accountId,
-            row.id,
-            'flag_seen',
-            jsonEncode({
-              'uid': row.uid,
-              'mailboxPath': row.mailboxPath,
-              'seen': true,
-            }),
-          );
-        }
-      }
-
-      // Bulk mark all unread emails in this mailbox as seen.
-      await (_db.update(_db.emails)
-            ..where(
-              (t) =>
-                  t.accountId.equals(accountId) &
-                  t.mailboxPath.equals(mailboxPath) &
-                  t.isSeen.equals(false),
-            ))
-          .write(const EmailsCompanion(isSeen: Value(true)));
-
-      // Update all threads in this mailbox to reflect no unread.
-      await (_db.update(_db.threads)
-            ..where(
-              (t) =>
-                  t.accountId.equals(accountId) &
-                  t.mailboxPath.equals(mailboxPath),
-            ))
-          .write(const ThreadsCompanion(hasUnread: Value(false)));
-    });
-  }
-
   @override
   Future<void> moveEmail(String emailId, String destMailboxPath) async {
     final row = await (_db.select(

lib/ui/screens/account_list_screen.dart

@@ -60,7 +60,20 @@ class AccountListScreen extends ConsumerWidget {
           }
           final accounts = snap.data!;
           if (accounts.isEmpty) {
-            return const _OnboardingView();
+            return Center(
+              child: Column(
+                mainAxisSize: MainAxisSize.min,
+                children: [
+                  const Text('No accounts yet.'),
+                  const SizedBox(height: 12),
+                  FilledButton.icon(
+                    onPressed: () => context.push('/accounts/add'),
+                    icon: const Icon(Icons.add),
+                    label: const Text('Add account'),
+                  ),
+                ],
+              ),
+            );
           }
           return ListView.builder(
             itemCount: accounts.length,
@@ -220,112 +233,6 @@ class _AccountTile extends ConsumerWidget {
   }
 }
 
-class _OnboardingView extends StatelessWidget {
-  const _OnboardingView();
-
-  @override
-  Widget build(BuildContext context) {
-    final theme = Theme.of(context);
-    return Center(
-      child: SingleChildScrollView(
-        padding: const EdgeInsets.all(24),
-        child: Column(
-          mainAxisSize: MainAxisSize.min,
-          children: [
-            Icon(
-              Icons.mail_outline,
-              size: 64,
-              color: theme.colorScheme.primary,
-            ),
-            const SizedBox(height: 16),
-            Text(
-              'Welcome to SharedInbox',
-              style: theme.textTheme.headlineSmall,
-              textAlign: TextAlign.center,
-            ),
-            const SizedBox(height: 8),
-            Text(
-              'Get started in three steps:',
-              style: theme.textTheme.bodyMedium,
-              textAlign: TextAlign.center,
-            ),
-            const SizedBox(height: 24),
-            const _Step(
-              number: '1',
-              title: 'Add an account',
-              description: 'Connect your IMAP or JMAP email account.',
-            ),
-            const _Step(
-              number: '2',
-              title: 'Wait for sync',
-              description:
-                  'SharedInbox downloads your messages in the background.',
-            ),
-            const _Step(
-              number: '3',
-              title: 'Open your inbox',
-              description:
-                  'Tap the account to browse mailboxes and read emails.',
-            ),
-            const SizedBox(height: 32),
-            FilledButton.icon(
-              onPressed: () => context.push('/accounts/add'),
-              icon: const Icon(Icons.add),
-              label: const Text('Add account'),
-            ),
-          ],
-        ),
-      ),
-    );
-  }
-}
-
-class _Step extends StatelessWidget {
-  const _Step({
-    required this.number,
-    required this.title,
-    required this.description,
-  });
-
-  final String number;
-  final String title;
-  final String description;
-
-  @override
-  Widget build(BuildContext context) {
-    final theme = Theme.of(context);
-    return Padding(
-      padding: const EdgeInsets.symmetric(vertical: 8),
-      child: Row(
-        crossAxisAlignment: CrossAxisAlignment.start,
-        children: [
-          CircleAvatar(
-            radius: 16,
-            backgroundColor: theme.colorScheme.primaryContainer,
-            child: Text(
-              number,
-              style: TextStyle(
-                color: theme.colorScheme.onPrimaryContainer,
-                fontWeight: FontWeight.bold,
-              ),
-            ),
-          ),
-          const SizedBox(width: 16),
-          Expanded(
-            child: Column(
-              crossAxisAlignment: CrossAxisAlignment.start,
-              children: [
-                Text(title, style: theme.textTheme.titleSmall),
-                Text(description, style: theme.textTheme.bodySmall),
-              ],
-            ),
-          ),
-        ],
-      ),
-    );
-  }
-}
-
 enum _AccountAction { syncLog, verifySync, edit, emailFilters, delete }
 
 /// Whether to surface the "Email filters" (Sieve) entry for [account].

lib/ui/screens/email_detail_screen.dart

@@ -1,6 +1,5 @@
 import 'dart:async';
 
-import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_html/flutter_html.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
@@ -18,14 +17,6 @@ import 'package:url_launcher/url_launcher.dart';
 
 final _dateFmt = DateFormat('EEE, MMM d yyyy, HH:mm');
 
-void _openLink(String? url, Map<String, String> attrs, dynamic _) {
-  if (url == null) return;
-  final uri = Uri.tryParse(url);
-  if (uri != null) {
-    unawaited(launchUrl(uri, mode: LaunchMode.externalApplication));
-  }
-}
-
 class EmailDetailScreen extends ConsumerStatefulWidget {
   const EmailDetailScreen({super.key, required this.emailId});
   final String emailId;
@@ -69,27 +60,20 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
             tooltip: 'Reply',
             onPressed: header == null
                 ? null
-                : () {
-                    unawaited(_reply(context, header, body, replyAll: false));
-                  },
+                : () => _reply(context, header, body, replyAll: false),
           ),
           IconButton(
             icon: const Icon(Icons.reply_all),
             tooltip: 'Reply all',
             onPressed: header == null
                 ? null
-                : () {
-                    unawaited(_reply(context, header, body, replyAll: true));
-                  },
+                : () => _reply(context, header, body, replyAll: true),
           ),
           IconButton(
             icon: const Icon(Icons.forward),
             tooltip: 'Forward',
-            onPressed: header == null
-                ? null
-                : () {
-                    unawaited(_forward(context, header, body));
-                  },
+            onPressed:
+                header == null ? null : () => _forward(context, header, body),
           ),
           IconButton(
             icon: const Icon(Icons.mark_email_unread_outlined),
@@ -279,31 +263,26 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
     );
   }
 
-  Future<String> _quotedBody(Email header, EmailBody? body) async {
+  String _quotedBody(Email header, EmailBody? body) {
     final date = header.sentAt != null ? _dateFmt.format(header.sentAt!) : '';
     final from =
         header.from.isNotEmpty ? header.from.first.toString() : '(unknown)';
-    final rawText = body?.textBody;
-    final text = (rawText != null && rawText.isNotEmpty)
-        ? rawText
-        : await compute(htmlToPlain, body?.htmlBody ?? '');
+    final text = body?.textBody ?? htmlToPlain(body?.htmlBody ?? '');
     final quoted = text.trim().split('\n').map((l) => '> $l').join('\n');
     return '\n\n— On $date, $from wrote:\n$quoted';
   }
 
-  Future<void> _reply(
+  void _reply(
     BuildContext context,
     Email header,
     EmailBody? body, {
     required bool replyAll,
-  }) async {
+  }) {
     final to = header.from.isNotEmpty ? header.from.first.email : '';
     final subject = (header.subject?.startsWith('Re:') ?? false)
         ? header.subject!
         : 'Re: ${header.subject ?? ''}';
     final cc = replyAll ? header.to.map((a) => a.email).join(', ') : '';
-    final quoted = await _quotedBody(header, body);
-    if (!context.mounted) return;
     unawaited(
       context.push(
         '/compose',
@@ -311,29 +290,23 @@ class _EmailDetailScreenState extends ConsumerState<EmailDetailScreen> {
           'replyToEmailId': widget.emailId,
           'prefillTo': to,
           'prefillSubject': subject,
-          'prefillBody': quoted,
+          'prefillBody': _quotedBody(header, body),
           if (cc.isNotEmpty) 'prefillCc': cc,
         },
       ),
     );
   }
 
-  Future<void> _forward(
-    BuildContext context,
-    Email header,
-    EmailBody? body,
-  ) async {
+  void _forward(BuildContext context, Email header, EmailBody? body) {
     final subject = (header.subject?.startsWith('Fwd:') ?? false)
         ? header.subject!
         : 'Fwd: ${header.subject ?? ''}';
-    final quoted = await _quotedBody(header, body);
-    if (!context.mounted) return;
     unawaited(
       context.push(
         '/compose',
         extra: {
           'prefillSubject': subject,
-          'prefillBody': quoted,
+          'prefillBody': _quotedBody(header, body),
         },
       ),
     );
@@ -561,11 +534,7 @@ class _SafeHtmlState extends State<_SafeHtml> {
       (_) => ErrorWidget.builder = prev,
     );
 
-    return Html(
-      data: widget.data,
-      extensions: widget.extensions,
-      onLinkTap: _openLink,
-    );
+    return Html(data: widget.data, extensions: widget.extensions);
   }
 }
 

lib/ui/screens/email_list_screen.dart

@@ -15,14 +15,6 @@ import 'package:sharedinbox/ui/widgets/folder_drawer.dart';
 import 'package:sharedinbox/ui/widgets/snooze_picker.dart';
 
 final _dateFmt = DateFormat('MMM d');
-// Cache formatted dates by local calendar day so DateFormat.format is called
-// at most once per unique date rather than once per list item per rebuild.
-final _formattedDates = <int, String>{};
-
-int _dayKey(DateTime dt) => dt.year * 10000 + dt.month * 100 + dt.day;
-
-String _fmtDate(DateTime dt) =>
-    _formattedDates[_dayKey(dt)] ??= _dateFmt.format(dt);
 
 class EmailListScreen extends ConsumerStatefulWidget {
   const EmailListScreen({
@@ -201,22 +193,6 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
                   extra: {'accountId': widget.accountId},
                 ),
               ),
-              PopupMenuButton<String>(
-                onSelected: (value) async {
-                  if (value == 'mark_all_read') {
-                    await emailRepo.markAllAsRead(
-                      widget.accountId,
-                      widget.mailboxPath,
-                    );
-                  }
-                },
-                itemBuilder: (_) => const [
-                  PopupMenuItem(
-                    value: 'mark_all_read',
-                    child: Text('Mark all as read'),
-                  ),
-                ],
-              ),
             ],
       bottom: PreferredSize(
         preferredSize: const Size.fromHeight(60),
@@ -649,7 +625,7 @@ class _EmailListScreenState extends ConsumerState<EmailListScreen> {
                 const Icon(Icons.star, color: Colors.amber, size: 16),
               const SizedBox(width: 4),
               Text(
-                _fmtDate(t.latestDate),
+                _dateFmt.format(t.latestDate),
                 style: Theme.of(ctx).textTheme.bodySmall,
               ),
             ],

lib/ui/screens/thread_detail_screen.dart

@@ -10,7 +10,6 @@ import 'package:sharedinbox/core/models/email.dart';
 import 'package:sharedinbox/core/models/undo_action.dart';
 import 'package:sharedinbox/core/utils/html_utils.dart';
 import 'package:sharedinbox/di.dart';
-import 'package:url_launcher/url_launcher.dart';
 
 final _dateFmt = DateFormat('EEE, MMM d, HH:mm');
 
@@ -169,18 +168,6 @@ class _EmailMessageCardState extends ConsumerState<_EmailMessageCard> {
                       extensions: [
                         if (!_loadRemoteImages) _BlockRemoteImagesExtension(),
                       ],
-                      onLinkTap: (url, _, __) {
-                        if (url == null) return;
-                        final uri = Uri.tryParse(url);
-                        if (uri != null) {
-                          unawaited(
-                            launchUrl(
-                              uri,
-                              mode: LaunchMode.externalApplication,
-                            ),
-                          );
-                        }
-                      },
                     ),
                   ] else
                     SelectableText(

test/integration/account_sync_manager_test.dart

@@ -1,7 +1,5 @@
 import 'dart:async';
-import 'dart:io';
 
-import 'package:enough_mail/enough_mail.dart' as imap;
 import 'package:flutter_test/flutter_test.dart';
 import 'package:sharedinbox/core/models/account.dart';
 import 'package:sharedinbox/core/models/email.dart';
@@ -12,16 +10,8 @@ import 'package:sharedinbox/core/repositories/mailbox_repository.dart';
 import 'package:sharedinbox/core/repositories/sync_log_repository.dart';
 import 'package:sharedinbox/core/sync/account_sync_manager.dart';
 
-Future<imap.ImapClient> _fakeImapConnect(
-  Account account,
-  String username,
-  String password,
-) async =>
-    throw const SocketException('fake — no real IMAP server in tests');
-
 void main() {
-  test('AccountSyncManager schedules IMAP sync for multiple accounts',
-      () async {
+  test('AccountSyncManager schedules sync for multiple accounts', () async {
     final accounts = _FakeAccounts('pw');
     final mailboxes = _FakeMailboxes();
     final emails = _FakeEmails();
@@ -32,7 +22,6 @@ void main() {
       mailboxes,
       emails,
       syncLog: logs,
-      imapConnect: _fakeImapConnect,
     );
 
     final a1 = _account('1');
@@ -49,34 +38,6 @@ void main() {
 
     manager.dispose();
   });
-
-  test('AccountSyncManager schedules JMAP sync for multiple accounts',
-      () async {
-    final accounts = _FakeAccounts('pw');
-    final mailboxes = _FakeMailboxes();
-    final emails = _FakeEmails();
-    final logs = _FakeLogs();
-
-    final manager = AccountSyncManager(
-      accounts,
-      mailboxes,
-      emails,
-      syncLog: logs,
-    );
-
-    final a1 = _jmapAccount('1');
-    final a2 = _jmapAccount('2');
-
-    manager.start();
-    accounts.push([a1, a2]);
-
-    await Future<void>.delayed(const Duration(milliseconds: 100));
-
-    expect(emails.syncCounts['1'], greaterThanOrEqualTo(1));
-    expect(emails.syncCounts['2'], greaterThanOrEqualTo(1));
-
-    manager.dispose();
-  });
 }
 
 Account _account(String id) => Account(
@@ -91,17 +52,6 @@ Account _account(String id) => Account(
       smtpSsl: false,
     );
 
-Account _jmapAccount(String id) => Account(
-      id: id,
-      displayName: 'Account $id',
-      email: '$id@example.com',
-      type: AccountType.jmap,
-      jmapUrl: 'http://localhost:8080/.well-known/jmap',
-      smtpHost: 'localhost',
-      smtpPort: 25,
-      smtpSsl: false,
-    );
-
 class _FakeAccounts implements AccountRepository {
   _FakeAccounts(this.password);
   final String password;
@@ -190,9 +140,6 @@ class _FakeEmails implements EmailRepository {
   @override
   Future<void> setFlag(String id, {bool? seen, bool? flagged}) async {}
 
-  @override
-  Future<void> markAllAsRead(String accountId, String mailboxPath) async {}
-
   @override
   Future<void> moveEmail(String id, String dest) async {}
 

test/unit/account_sync_manager_test.dart

@@ -61,8 +61,6 @@ class FakeEmailRepository implements EmailRepository {
   @override
   Future<void> setFlag(String id, {bool? seen, bool? flagged}) async {}
   @override
-  Future<void> markAllAsRead(String accountId, String mailboxPath) async {}
-  @override
   Future<void> moveEmail(String id, String dest) async {}
 
   @override

test/unit/account_sync_manager_test.mocks.dart

@@ -337,23 +337,6 @@ class MockEmailRepository extends _i1.Mock implements _i9.EmailRepository {
         returnValueForMissingStub: _i4.Future<void>.value(),
       ) as _i4.Future<void>);
 
-  @override
-  _i4.Future<void> markAllAsRead(
-    String? accountId,
-    String? mailboxPath,
-  ) =>
-      (super.noSuchMethod(
-        Invocation.method(
-          #markAllAsRead,
-          [
-            accountId,
-            mailboxPath,
-          ],
-        ),
-        returnValue: _i4.Future<void>.value(),
-        returnValueForMissingStub: _i4.Future<void>.value(),
-      ) as _i4.Future<void>);
-
   @override
   _i4.Future<void> moveEmail(
     String? emailId,

test/unit/email_repository_contract_test.dart

@@ -126,35 +126,6 @@ abstract class EmailRepositoryContract {
       expect(email!.isFlagged, isTrue);
     });
 
-    test('markAllAsRead marks every unread email in the mailbox', () async {
-      final repo = await makeRepo();
-      await insertEmail(
-        repo,
-        id: 'er-acc:20',
-        mailboxPath: 'INBOX',
-        isSeen: false,
-      );
-      await insertEmail(
-        repo,
-        id: 'er-acc:21',
-        mailboxPath: 'INBOX',
-        isSeen: false,
-      );
-      await insertEmail(
-        repo,
-        id: 'er-acc:22',
-        mailboxPath: 'Sent',
-        isSeen: false,
-      );
-
-      await repo.markAllAsRead(_account.id, 'INBOX');
-
-      expect((await repo.getEmail('er-acc:20'))!.isSeen, isTrue);
-      expect((await repo.getEmail('er-acc:21'))!.isSeen, isTrue);
-      // Email in a different mailbox should be untouched.
-      expect((await repo.getEmail('er-acc:22'))!.isSeen, isFalse);
-    });
-
     test('observeThreads starts empty', () async {
       final repo = await makeRepo();
       expect(

test/unit/reliability_runner_test.dart

@@ -103,8 +103,6 @@ class _CountingEmails implements EmailRepository {
   @override
   Future<void> setFlag(String id, {bool? seen, bool? flagged}) async {}
   @override
-  Future<void> markAllAsRead(String accountId, String mailboxPath) async {}
-  @override
   Future<void> moveEmail(String id, String dest) async {}
   @override
   Future<String?> deleteEmail(String id) async => null;

test/unit/undo_service_test.mocks.dart

@@ -197,23 +197,6 @@ class MockEmailRepository extends _i1.Mock implements _i3.EmailRepository {
         returnValueForMissingStub: _i4.Future<void>.value(),
       ) as _i4.Future<void>);
 
-  @override
-  _i4.Future<void> markAllAsRead(
-    String? accountId,
-    String? mailboxPath,
-  ) =>
-      (super.noSuchMethod(
-        Invocation.method(
-          #markAllAsRead,
-          [
-            accountId,
-            mailboxPath,
-          ],
-        ),
-        returnValue: _i4.Future<void>.value(),
-        returnValueForMissingStub: _i4.Future<void>.value(),
-      ) as _i4.Future<void>);
-
   @override
   _i4.Future<void> moveEmail(
     String? emailId,

test/widget/account_list_screen_test.dart

@@ -5,7 +5,7 @@ import 'helpers.dart';
 
 void main() {
   group('AccountListScreen', () {
-    testWidgets('shows onboarding walkthrough when repository is empty', (
+    testWidgets('shows "No accounts yet." when repository is empty', (
       tester,
     ) async {
       await tester.pumpWidget(
@@ -13,7 +13,7 @@ void main() {
       );
       await tester.pumpAndSettle();
 
-      expect(find.text('Welcome to SharedInbox'), findsOneWidget);
+      expect(find.text('No accounts yet.'), findsOneWidget);
       expect(find.text('Add account'), findsOneWidget);
     });
 

test/widget/add_account_screen_test.dart

@@ -203,7 +203,7 @@ void main() {
       await tester.tap(find.text('Save'));
       await tester.pumpAndSettle();
 
-      expect(find.text('Welcome to SharedInbox'), findsOneWidget);
+      expect(find.text('No accounts yet.'), findsOneWidget);
     });
 
     testWidgets('JMAP connection failure shows error message', (tester) async {
@@ -284,7 +284,7 @@ void main() {
       await tester.tap(find.text('Save'));
       await tester.pumpAndSettle();
 
-      expect(find.text('Welcome to SharedInbox'), findsOneWidget);
+      expect(find.text('No accounts yet.'), findsOneWidget);
     });
 
     testWidgets(

test/widget/email_list_screen_golden_test.dart

@@ -1,158 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
-import 'package:flutter_test/flutter_test.dart';
-
-import 'package:sharedinbox/core/models/email.dart';
-import 'package:sharedinbox/di.dart';
-
-import 'helpers.dart';
-
-// Fixed-date emails so golden files don't change day to day.
-final _kDate = DateTime(2024, 6);
-
-Email _email({
-  String id = 'acc-1:1',
-  String subject = 'Hello world',
-  bool isSeen = true,
-  bool isFlagged = false,
-}) =>
-    Email(
-      id: id,
-      accountId: 'acc-1',
-      mailboxPath: 'INBOX',
-      uid: int.parse(id.split(':').last),
-      subject: subject,
-      receivedAt: _kDate,
-      sentAt: _kDate,
-      from: const [EmailAddress(name: 'Bob', email: 'bob@example.com')],
-      to: const [EmailAddress(email: 'alice@example.com')],
-      cc: const [],
-      isSeen: isSeen,
-      isFlagged: isFlagged,
-      hasAttachment: false,
-    );
-
-List<Override> _overrides({
-  List<Email> emails = const [],
-  List<Email> searchResults = const [],
-  String? syncError,
-}) =>
-    [
-      accountRepositoryProvider.overrideWithValue(
-        FakeAccountRepository([kTestAccount]),
-      ),
-      mailboxRepositoryProvider.overrideWithValue(
-        FakeMailboxRepository([kTestMailbox]),
-      ),
-      emailRepositoryProvider.overrideWithValue(
-        FakeEmailRepository(emails: emails, searchResults: searchResults),
-      ),
-      draftRepositoryProvider.overrideWithValue(FakeDraftRepository()),
-      searchHistoryRepositoryProvider.overrideWithValue(
-        FakeSearchHistoryRepository(),
-      ),
-      syncLastErrorProvider.overrideWith(
-        (ref, _) => Stream.value(syncError),
-      ),
-    ];
-
-void main() {
-  group('EmailListScreen goldens', () {
-    testWidgets('golden: empty state', (tester) async {
-      await tester.pumpWidget(
-        buildApp(
-          initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
-          overrides: _overrides(),
-        ),
-      );
-      await tester.pumpAndSettle();
-
-      await expectLater(
-        find.byType(MaterialApp),
-        matchesGoldenFile('goldens/email_list_empty.png'),
-      );
-    });
-
-    testWidgets('golden: list with emails', (tester) async {
-      await tester.pumpWidget(
-        buildApp(
-          initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
-          overrides: _overrides(
-            emails: [
-              _email(subject: 'Team standup notes', isSeen: false),
-              _email(id: 'acc-1:2', subject: 'Q3 review', isFlagged: true),
-              _email(id: 'acc-1:3', subject: 'Welcome to the project'),
-            ],
-          ),
-        ),
-      );
-      await tester.pumpAndSettle();
-
-      await expectLater(
-        find.byType(MaterialApp),
-        matchesGoldenFile('goldens/email_list_with_emails.png'),
-      );
-    });
-
-    testWidgets('golden: selection mode', (tester) async {
-      await tester.pumpWidget(
-        buildApp(
-          initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
-          overrides: _overrides(
-            emails: [
-              _email(subject: 'Team standup notes', isSeen: false),
-              _email(id: 'acc-1:2', subject: 'Q3 review'),
-            ],
-          ),
-        ),
-      );
-      await tester.pumpAndSettle();
-
-      await tester.longPress(find.text('Team standup notes'));
-      await tester.pumpAndSettle();
-
-      await expectLater(
-        find.byType(MaterialApp),
-        matchesGoldenFile('goldens/email_list_selection.png'),
-      );
-    });
-
-    testWidgets('golden: search with results', (tester) async {
-      await tester.pumpWidget(
-        buildApp(
-          initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
-          overrides: _overrides(
-            searchResults: [
-              _email(id: 'acc-1:5', subject: 'Project proposal'),
-            ],
-          ),
-        ),
-      );
-      await tester.pumpAndSettle();
-
-      await tester.enterText(find.byType(SearchBar), 'project');
-      await tester.testTextInput.receiveAction(TextInputAction.search);
-      await tester.pumpAndSettle();
-
-      await expectLater(
-        find.byType(MaterialApp),
-        matchesGoldenFile('goldens/email_list_search_results.png'),
-      );
-    });
-
-    testWidgets('golden: error banner', (tester) async {
-      await tester.pumpWidget(
-        buildApp(
-          initialLocation: '/accounts/acc-1/mailboxes/INBOX/emails',
-          overrides: _overrides(syncError: 'Connection refused'),
-        ),
-      );
-      await tester.pumpAndSettle();
-
-      await expectLater(
-        find.byType(MaterialApp),
-        matchesGoldenFile('goldens/email_list_error_banner.png'),
-      );
-    });
-  });
-}

test/widget/helpers.dart

@@ -214,8 +214,6 @@ class FakeEmailRepository implements EmailRepository {
 
   @override
   Future<void> setFlag(String emailId, {bool? seen, bool? flagged}) async {}
-  @override
-  Future<void> markAllAsRead(String accountId, String mailboxPath) async {}
 
   @override
   Future<void> moveEmail(String emailId, String destMailboxPath) async {}