guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Fix open PRs #384

New Issue
Closed
opened 2026-06-03 22:28:00 +00:00 by guettli · 1 comment
guettli commented 2026-06-03 22:28:00 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Fix open PRs. CI failed

Fix open PRs. CI failed
guettlibot commented 2026-06-03 22:50:01 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

CI runs are now queued/in-progress for all the fixed PR branches. Here's a summary of what was done:

What I did

All three open PRs (#378, #379, #381) were failing CI because dart format was not run before committing. CI enforces dart format --set-exit-if-changed and dart analyze --fatal-infos, which are fatal for any formatting or lint issues.

Root causes found:

  • PR #381 (issue-367-prefetch-next-email): lib/di.dart — chained method call wrapped incorrectly
  • PR #378 (issue-377-remember-show-images): test/unit/migration_test.dart — chained method call wrapped incorrectly
  • PR #379 (issue-376-combined-inbox): Three issues:
    1. lib/data/repositories/email_repository_impl.dart — formatting
    2. lib/ui/router.dart — combined_inbox_screen.dart import out of alphabetical order (triggers directives_ordering info, fatal with --fatal-infos)
    3. test/unit/account_sync_manager_test.mocks.dart — mock formatting differed from what build_runner generates

Fixes applied:

CI runs are now queued/in-progress for all the fixed PR branches. Here's a summary of what was done: --- ## What I did All three open PRs (#378, #379, #381) were failing CI because `dart format` was not run before committing. CI enforces `dart format --set-exit-if-changed` and `dart analyze --fatal-infos`, which are fatal for any formatting or lint issues. **Root causes found:** - **PR #381** (`issue-367-prefetch-next-email`): `lib/di.dart` — chained method call wrapped incorrectly - **PR #378** (`issue-377-remember-show-images`): `test/unit/migration_test.dart` — chained method call wrapped incorrectly - **PR #379** (`issue-376-combined-inbox`): Three issues: 1. `lib/data/repositories/email_repository_impl.dart` — formatting 2. `lib/ui/router.dart` — `combined_inbox_screen.dart` import out of alphabetical order (triggers `directives_ordering` info, fatal with `--fatal-infos`) 3. `test/unit/account_sync_manager_test.mocks.dart` — mock formatting differed from what `build_runner` generates **Fixes applied:** - Pushed `fix: apply dart format to fix CI` commits directly to each failing PR branch — CI is now re-running on each - PR #384: https://codeberg.org/guettli/sharedinbox/pulls/385 — adds `dart format` and sorted imports requirements to `AGENTS.md` to prevent recurrence
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels loop/code-done
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#384