guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

test(search): cover sort order of searchEmailsStructured and getEmailsByAddress #534

Merged
guettlibot merged 1 commits from refs/pull/534/head into main 2026-06-07 18:24:30 +00:00
Conversation 0 Commits 1 Files Changed 1
+267 -554
guettlibot commented 2026-06-07 18:21:47 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

Issue #485 reports search showing the oldest mail at the top. PR #520 already fixed the two largest culprits (searchEmails and searchEmailsGlobal) by switching the FTS query from ORDER BY rank to ORDER BY received_at DESC and re-sorting the merged FTS + notes results.

The remaining two search paths surfaced from the UI — searchEmailsStructured (advanced search) and getEmailsByAddress (the per-address email list) — already used OrderingTerm.desc(receivedAt), but had no regression test, so a future change to either could silently reintroduce the bug this issue describes.

Changes

  • Add searchEmailsStructured returns results sorted by receivedAt descending
  • Add getEmailsByAddress returns results sorted by receivedAt descending

No production code changes — the existing implementations already sort newest-first; this just locks in the contract.

Test plan

  • fvm flutter test test/unit/email_repository_impl_test.dart — all 73 tests pass, including the two new ones.
  • fvm dart analyze test/unit/email_repository_impl_test.dart — no issues.
  • fvm dart format — no formatting changes.

Closes #485

## Summary Issue #485 reports search showing the oldest mail at the top. PR #520 already fixed the two largest culprits (`searchEmails` and `searchEmailsGlobal`) by switching the FTS query from `ORDER BY rank` to `ORDER BY received_at DESC` and re-sorting the merged FTS + notes results. The remaining two search paths surfaced from the UI — `searchEmailsStructured` (advanced search) and `getEmailsByAddress` (the per-address email list) — already used `OrderingTerm.desc(receivedAt)`, but had no regression test, so a future change to either could silently reintroduce the bug this issue describes. ## Changes - Add `searchEmailsStructured returns results sorted by receivedAt descending` - Add `getEmailsByAddress returns results sorted by receivedAt descending` No production code changes — the existing implementations already sort newest-first; this just locks in the contract. ## Test plan - [x] `fvm flutter test test/unit/email_repository_impl_test.dart` — all 73 tests pass, including the two new ones. - [x] `fvm dart analyze test/unit/email_repository_impl_test.dart` — no issues. - [x] `fvm dart format` — no formatting changes. Closes #485
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#534