guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: retry AAB upload on RedirectMissingLocation (#186) #196

Closed
guettlibot wants to merge 0 commits from issue-186-fix into main
pull from: issue-186-fix
merge into: :main
Conversation 0 Commits - Files Changed -
guettlibot commented 2026-05-24 02:59:27 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • Wrap the resumable AAB bundle upload in a retry loop with exponential backoff (up to 3 attempts, delays 10 s / 20 s) to survive transient httplib2.error.RedirectMissingLocation errors.
  • Recreate MediaFileUpload on each attempt, since resumable uploads cannot reuse the same object after a failure.
  • Raise RuntimeError (chained to the last exception) when all attempts are exhausted.

Tests

  • test_retries_once_on_redirect_error_then_succeeds — retries after one redirect error and succeeds
  • test_raises_after_all_attempts_exhausted — raises RuntimeError after 3 failures
  • test_backoff_delays_are_10s_then_20s — verifies time.sleep(10) then time.sleep(20)
  • test_fresh_media_upload_created_on_each_attempt — MediaFileUpload constructed twice on one retry
  • test_succeeds_on_first_attempt — happy path unaffected

Depends on #185 (httplib2 infrastructure — included in this PR until #185 is merged).

🤖 Generated with Claude Code

## Summary - Wrap the resumable AAB bundle upload in a retry loop with exponential backoff (up to 3 attempts, delays 10 s / 20 s) to survive transient `httplib2.error.RedirectMissingLocation` errors. - Recreate `MediaFileUpload` on each attempt, since resumable uploads cannot reuse the same object after a failure. - Raise `RuntimeError` (chained to the last exception) when all attempts are exhausted. ## Tests - `test_retries_once_on_redirect_error_then_succeeds` — retries after one redirect error and succeeds - `test_raises_after_all_attempts_exhausted` — raises `RuntimeError` after 3 failures - `test_backoff_delays_are_10s_then_20s` — verifies `time.sleep(10)` then `time.sleep(20)` - `test_fresh_media_upload_created_on_each_attempt` — `MediaFileUpload` constructed twice on one retry - `test_succeeds_on_first_attempt` — happy path unaffected Depends on #185 (httplib2 infrastructure — included in this PR until #185 is merged). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#196