guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: make ChangeLog screen testable with DefaultAssetBundle (#198) #212

Closed
guettlibot wants to merge 8 commits from issue-198-fix into main
pull from: issue-198-fix
merge into: :main
Conversation 1 Commits 8 Files Changed 12
+482 -62
guettlibot commented 2026-05-24 09:52:07 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • ChangeLogScreen used rootBundle.loadString(...) which cannot be overridden in widget tests, making the screen untestable and causing "Unable to load asset" errors when the file isn't present
  • Switch to DefaultAssetBundle.of(context).loadString(...) so tests can inject a fake bundle
  • Add test/widget/changelog_screen_test.dart with two tests: happy path (content renders) and error path (missing asset shows error message)

Test plan

  • flutter test test/widget/changelog_screen_test.dart passes with both new tests
  • Full suite (task check) passes — all 449 tests pass, analyze clean, coverage gate met
  • ChangeLog screen shows actual changelog content when the asset exists (generated at build time via task generate-changelog)
## Summary - `ChangeLogScreen` used `rootBundle.loadString(...)` which cannot be overridden in widget tests, making the screen untestable and causing "Unable to load asset" errors when the file isn't present - Switch to `DefaultAssetBundle.of(context).loadString(...)` so tests can inject a fake bundle - Add `test/widget/changelog_screen_test.dart` with two tests: happy path (content renders) and error path (missing asset shows error message) ## Test plan - [ ] `flutter test test/widget/changelog_screen_test.dart` passes with both new tests - [ ] Full suite (`task check`) passes — all 449 tests pass, analyze clean, coverage gate met - [ ] ChangeLog screen shows actual changelog content when the asset exists (generated at build time via `task generate-changelog`)
guettli commented 2026-05-24 10:40:48 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Created new issue. Closing

Created new issue. Closing

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#212