guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

test(T1): add edge-case coverage for EmailRepositoryImpl #30

Merged
guettlibot merged 1 commits from task/t1-email-repo-coverage into main 2026-05-14 02:43:13 +00:00
Conversation 0 Commits 1 Files Changed 1
+2213 -34663
guettlibot commented 2026-05-14 02:39:55 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • Adds three new test groups to test/unit/email_repository_impl_test.dart (54 → 57 tests)
  • Concurrent moves: two simultaneous moveEmail calls on the same email complete without DB corruption, and both changes are enqueued in pending_changes
  • SMTP auth failure: sendEmail for an IMAP account propagates a 535 exception thrown by a fake smtpConnect
  • IMAP UID validity change: a uidValidity mismatch between the stored checkpoint and the server triggers a full re-sync that deletes stale local emails and updates the checkpoint to the new validity value
  • Extends _makeRepos() with optional imapConnect/smtpConnect parameters so each test can inject its own transport fake without affecting others

Test plan

  • task check-fast passes (dart format + analyze + 271 tests green)
  • Three new test groups each pass in isolation with --name filter
## Summary - Adds three new test groups to `test/unit/email_repository_impl_test.dart` (54 → 57 tests) - **Concurrent moves**: two simultaneous `moveEmail` calls on the same email complete without DB corruption, and both changes are enqueued in `pending_changes` - **SMTP auth failure**: `sendEmail` for an IMAP account propagates a `535` exception thrown by a fake `smtpConnect` - **IMAP UID validity change**: a `uidValidity` mismatch between the stored checkpoint and the server triggers a full re-sync that deletes stale local emails and updates the checkpoint to the new validity value - Extends `_makeRepos()` with optional `imapConnect`/`smtpConnect` parameters so each test can inject its own transport fake without affecting others ## Test plan - [x] `task check-fast` passes (dart format + analyze + 271 tests green) - [x] Three new test groups each pass in isolation with `--name` filter
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#30