guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

test(T3): add contract test suites for Account/Mailbox/Email repositories #43

Merged
guettlibot merged 1 commits from task/t3-repository-contract-tests into main 2026-05-14 08:20:33 +00:00
Conversation 0 Commits 1 Files Changed 4
+2408 -33337
guettlibot commented 2026-05-14 08:16:25 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Implements T3 from the improvement plan.

The three repository interfaces had no shared contract test suite —
concrete impls could silently diverge from the interface semantics.

Three new abstract contract classes verify observable-state invariants:

  • AccountRepositoryContract — 9 tests (addAccount, getAccount, updateAccount, removeAccount, getPassword)
  • MailboxRepositoryContract — 6 tests (observeMailboxes ordering/filtering, findMailboxByRole, clearForResync)
  • EmailRepositoryContract — 8 tests (observeEmails ordering/filtering, getEmail, setFlag, observeThreads)

Each concrete impl (*Impl) is run against the suite via a thin subclass.
Future fakes or alternative implementations can be verified by subclassing
the same contract class without duplicating test logic.

Network-dependent methods (syncEmails, syncMailboxes, etc.) are excluded
from the contract — they are covered by the existing impl-specific tests.

Closes #19 (T3)

Implements T3 from the improvement plan. The three repository interfaces had no shared contract test suite — concrete impls could silently diverge from the interface semantics. Three new abstract contract classes verify observable-state invariants: - `AccountRepositoryContract` — 9 tests (addAccount, getAccount, updateAccount, removeAccount, getPassword) - `MailboxRepositoryContract` — 6 tests (observeMailboxes ordering/filtering, findMailboxByRole, clearForResync) - `EmailRepositoryContract` — 8 tests (observeEmails ordering/filtering, getEmail, setFlag, observeThreads) Each concrete impl (`*Impl`) is run against the suite via a thin subclass. Future fakes or alternative implementations can be verified by subclassing the same contract class without duplicating test logic. Network-dependent methods (syncEmails, syncMailboxes, etc.) are excluded from the contract — they are covered by the existing impl-specific tests. Closes #19 (T3)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#43