guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

feat: unify thread list views via shared EmailThreadTile widget #431

Merged
guettlibot merged 5 commits from issue-424-unify-email-list-views into main 2026-06-05 16:11:30 +00:00
Conversation 0 Commits 5 Files Changed 4
+574 -5878
guettlibot commented 2026-06-04 20:33:51 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Closes #424

What changed

New widget: lib/ui/widgets/email_thread_tile.dart

A shared EmailThreadTile that handles:

  • Dismissible swipe gestures (archive left, delete right)
  • Selection-mode checkbox (when isSelecting is true, swipe is disabled)
  • Optional account-name subtitle line (showAccount / accountName) for combined-inbox use

This eliminates ~150 lines of duplicated thread-tile rendering code that existed separately in both EmailListScreen and CombinedInboxScreen.

CombinedInboxScreen — added multi-select + batch ops

  • Long-press a thread to enter selection mode
  • AppBar switches to "N selected" + close + select-all
  • Batch Archive and Delete via bottom action bar
  • Cross-account batch archive groups threads by accountId to resolve the correct archive folder per account
  • Compose FAB and drawer are hidden while selecting

EmailListScreen — refactored to use EmailThreadTile

  • Swipe handler extracted into _onSwipeDismissed() method (was an inline closure)
  • Duplicate date-formatting helpers removed (now live in email_thread_tile.dart)
  • All existing behaviour preserved

SearchScreen — no changes

Serves a different purpose (cross-entity discovery across folders, addresses, and emails). Its email section already reuses the shared EmailTile widget.

Verification

  • flutter analyze — no issues
  • flutter test test/unit/ test/widget/ — 492 tests pass
  • Golden files regenerated to match the refactored widget output
Closes #424 ## What changed ### New widget: `lib/ui/widgets/email_thread_tile.dart` A shared `EmailThreadTile` that handles: - `Dismissible` swipe gestures (archive left, delete right) - Selection-mode checkbox (when `isSelecting` is true, swipe is disabled) - Optional account-name subtitle line (`showAccount` / `accountName`) for combined-inbox use This eliminates ~150 lines of duplicated thread-tile rendering code that existed separately in both `EmailListScreen` and `CombinedInboxScreen`. ### `CombinedInboxScreen` — added multi-select + batch ops - Long-press a thread to enter selection mode - AppBar switches to "N selected" + close + select-all - Batch Archive and Delete via bottom action bar - Cross-account batch archive groups threads by `accountId` to resolve the correct archive folder per account - Compose FAB and drawer are hidden while selecting ### `EmailListScreen` — refactored to use `EmailThreadTile` - Swipe handler extracted into `_onSwipeDismissed()` method (was an inline closure) - Duplicate date-formatting helpers removed (now live in `email_thread_tile.dart`) - All existing behaviour preserved ### `SearchScreen` — no changes Serves a different purpose (cross-entity discovery across folders, addresses, and emails). Its email section already reuses the shared `EmailTile` widget. ## Verification - `flutter analyze` — no issues - `flutter test test/unit/ test/widget/` — 492 tests pass - Golden files regenerated to match the refactored widget output
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#431