guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: discard stale search results when a newer query supersedes them #468

Merged
guettlibot merged 1 commits from issue-467-fix-search-stale-results into main 2026-06-06 08:32:38 +00:00
Conversation 0 Commits 1 Files Changed 4
+580 -4175
guettlibot commented 2026-06-06 07:33:28 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • _onSearchChanged fired on every keystroke and launched concurrent IMAP searches via unawaited(_runSearch(...)). A slower earlier search completing after a faster later search would overwrite _searchResults with stale data — causing the wrong email to open when tapping a result (issue #467).
  • Added a _searchGeneration counter in EmailListScreen (incremented on each search start). Results are only applied when generation == _searchGeneration, so any in-flight response from a superseded query is silently discarded.
  • Clearing the search field resets state immediately without waiting for pending requests.

Test plan

  • New test: tapping first of multiple search results opens the correct email — verifies the right EmailDetailScreen opens
  • New test: stale results from a slower concurrent search are discarded — uses a Completer to simulate out-of-order IMAP responses; confirms the newer result wins even after the stale one resolves
  • All 23 widget tests pass: fvm flutter test test/widget/

Refs #467

## Summary - `_onSearchChanged` fired on every keystroke and launched concurrent IMAP searches via `unawaited(_runSearch(...))`. A slower earlier search completing after a faster later search would overwrite `_searchResults` with stale data — causing the wrong email to open when tapping a result (issue #467). - Added a `_searchGeneration` counter in `EmailListScreen` (incremented on each search start). Results are only applied when `generation == _searchGeneration`, so any in-flight response from a superseded query is silently discarded. - Clearing the search field resets state immediately without waiting for pending requests. ## Test plan - [x] New test: *tapping first of multiple search results opens the correct email* — verifies the right `EmailDetailScreen` opens - [x] New test: *stale results from a slower concurrent search are discarded* — uses a `Completer` to simulate out-of-order IMAP responses; confirms the newer result wins even after the stale one resolves - [x] All 23 widget tests pass: `fvm flutter test test/widget/` Refs #467
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#468