guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: prevent Enter key from re-running a settled search #479

Merged
guettlibot merged 5 commits from issue-473-search-result-reorder into main 2026-06-07 02:38:31 +00:00
Conversation 0 Commits 5 Files Changed 2
+510 -3319
guettlibot commented 2026-06-06 14:38:08 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • When a user typed a query, onChanged already ran _runSearch and results settled. Pressing Enter then triggered onSubmitted, firing a second IMAP search whose response could arrive in a different order — silently reordering the visible list so the tile at position 0 no longer corresponded to the email the user tapped.
  • Fixed by guarding onSubmitted: it now skips _runSearch when results are already present (_searchResults != null) or a search is already in flight (_searchLoading).
  • Added a regression test that verifies list order is unchanged after pressing Enter on an already-settled search.

Closes #473

Test plan

  • flutter test test/widget/email_list_screen_test.dart — all 24 tests pass, including the new "pressing Enter after search settles does not reorder results"
  • Manually: type a query in folder view search, wait for results to settle, press Enter — list order must not change

🤖 Generated with Claude Code

## Summary - When a user typed a query, `onChanged` already ran `_runSearch` and results settled. Pressing Enter then triggered `onSubmitted`, firing a second IMAP search whose response could arrive in a different order — silently reordering the visible list so the tile at position 0 no longer corresponded to the email the user tapped. - Fixed by guarding `onSubmitted`: it now skips `_runSearch` when results are already present (`_searchResults != null`) or a search is already in flight (`_searchLoading`). - Added a regression test that verifies list order is unchanged after pressing Enter on an already-settled search. Closes #473 ## Test plan - `flutter test test/widget/email_list_screen_test.dart` — all 24 tests pass, including the new "pressing Enter after search settles does not reorder results" - Manually: type a query in folder view search, wait for results to settle, press Enter — list order must not change 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#479