6a097976d3
Closes #361 Three bugs in the hourly deploy workflow's change-detection logic caused the Play Store to silently fall behind whenever a deploy failed or all-android jobs were skipped. **Bug 1 (primary): commit_sha → head_sha** Forgejo's API returns head_sha; commit_sha was always None. This meant LAST_DEPLOYED_SHA was always empty, so the diff fell back to HEAD~1..HEAD — only the single most recent commit was inspected. If android changes landed in an earlier commit, they were silently missed. **Bug 2: Skipped runs counted as 'deployed'** A workflow run where deploy-playstore was skipped (android=false) has status=success, so it was treated as a successful deploy. Now the code queries each run's job results and only trusts a run where the 'Build & Deploy to Play Store' job's own conclusion=success. **Bug 3: Narrow fallback when SHA unknown** When LAST_DEPLOYED_SHA could not be determined the workflow diffed HEAD~1..HEAD — potentially missing many commits. Now it defaults to android=true / linux=true (deploy everything) as the safe fallback. Additional changes: - ::error:: / ::warning:: / ::notice:: annotations so skip/failure reasons surface in the Actions UI. - scripts/verify_playstore_deploy.py: new post-deploy check that queries the internal track and fails if the latest version code is more than 1 hour old. (Version codes are Unix timestamps set by ci/main.go's PublishAndroid.) Catches silent deploy failures the upload API did not reject. - scripts/test_verify_playstore_deploy.py: 5 unit tests for the verify script (all pass). Co-authored-by: Thomas SharedInbox <sharedinbox@thomas-guettler.de> Reviewed-on: https://codeberg.org/guettli/sharedinbox/pulls/364
86 lines
3.1 KiB
Python
86 lines
3.1 KiB
Python
#!/usr/bin/env python3
|
|
"""Tests for verify_playstore_deploy.py."""
|
|
import os
|
|
import sys
|
|
import time
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent))
|
|
|
|
import verify_playstore_deploy
|
|
|
|
|
|
def _make_session(version_code, track="internal"):
|
|
"""Return a mock AuthorizedSession with the given version code on the track."""
|
|
session = MagicMock()
|
|
|
|
edit_resp = MagicMock()
|
|
edit_resp.json.return_value = {"id": "edit-99"}
|
|
session.post.return_value = edit_resp
|
|
|
|
track_resp = MagicMock()
|
|
track_resp.json.return_value = {
|
|
"releases": [{"versionCodes": [str(version_code)], "status": "completed"}]
|
|
}
|
|
session.get.return_value = track_resp
|
|
session.delete.return_value = MagicMock()
|
|
|
|
return session
|
|
|
|
|
|
class TestMissingEnv(unittest.TestCase):
|
|
def test_missing_env_exits(self):
|
|
with patch.dict(os.environ, {}, clear=True):
|
|
with self.assertRaises(SystemExit) as ctx:
|
|
verify_playstore_deploy.main()
|
|
self.assertEqual(ctx.exception.code, 1)
|
|
|
|
|
|
class TestRecentDeploy(unittest.TestCase):
|
|
def _run(self, version_code):
|
|
session = _make_session(version_code)
|
|
with patch.dict(os.environ, {"PLAY_STORE_CONFIG_JSON": '{"type":"service_account"}'}):
|
|
with patch("verify_playstore_deploy.service_account.Credentials.from_service_account_info"):
|
|
with patch("verify_playstore_deploy.AuthorizedSession", return_value=session):
|
|
verify_playstore_deploy.main()
|
|
|
|
def test_recent_version_code_passes(self):
|
|
# Version code is Unix timestamp — a very recent one should pass.
|
|
recent_vc = int(time.time()) - 60 # 1 minute ago
|
|
self._run(recent_vc)
|
|
|
|
def test_old_version_code_fails(self):
|
|
old_vc = int(time.time()) - 7200 # 2 hours ago
|
|
with self.assertRaises(SystemExit) as ctx:
|
|
self._run(old_vc)
|
|
self.assertEqual(ctx.exception.code, 1)
|
|
|
|
|
|
class TestEmptyTrack(unittest.TestCase):
|
|
def _run_empty(self, releases):
|
|
session = MagicMock()
|
|
session.post.return_value = MagicMock(**{"json.return_value": {"id": "edit-1"}})
|
|
session.get.return_value = MagicMock(**{"json.return_value": {"releases": releases}})
|
|
session.delete.return_value = MagicMock()
|
|
|
|
with patch.dict(os.environ, {"PLAY_STORE_CONFIG_JSON": '{"type":"service_account"}'}):
|
|
with patch("verify_playstore_deploy.service_account.Credentials.from_service_account_info"):
|
|
with patch("verify_playstore_deploy.AuthorizedSession", return_value=session):
|
|
verify_playstore_deploy.main()
|
|
|
|
def test_no_releases_exits(self):
|
|
with self.assertRaises(SystemExit) as ctx:
|
|
self._run_empty([])
|
|
self.assertEqual(ctx.exception.code, 1)
|
|
|
|
def test_release_with_no_version_codes_exits(self):
|
|
with self.assertRaises(SystemExit) as ctx:
|
|
self._run_empty([{"status": "completed", "versionCodes": []}])
|
|
self.assertEqual(ctx.exception.code, 1)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|