8ea5237991
## Summary
- The "Load remote images" snack bar in single-mail view (and the analogous thread view) never disappeared on its own — the user had to interact with it.
- Flutter's `SnackBar` defaults to `persist: true` whenever an `action` is provided (see `flutter/lib/src/material/snack_bar.dart`: `persist = persist ?? action != null`), which short-circuits the duration-based dismiss timer in `ScaffoldMessengerState.build`:
```dart
_snackBarTimer = Timer(snackBar.duration, () {
if (snackBar.persist) return; // <-- here
hideCurrentSnackBar(reason: SnackBarClosedReason.timeout);
});
```
So the explicit `duration: 3s` was set, but the "View" action made the snack bar persistent and the timer's callback returned early.
- Pass `persist: false` explicitly on both snack bars so the 3-second timer fires and the snack bar slides away on its own, while the "View" action button still works to navigate to the trusted-senders settings.
## Test plan
- [x] Added widget regression test in `test/widget/email_detail_screen_test.dart` (`Load remote images snack bar auto-dismisses after 3 seconds`).
- [x] Added analogous test in `test/widget/thread_detail_screen_test.dart`.
- [x] `task test-widget` — all 174 widget tests pass.
- [x] `scripts/run_unit_tests.sh` — all 552 unit tests pass.
- [x] `fvm dart analyze --fatal-infos` on changed files — no issues.
- [x] `fvm dart format` — no diffs.
- [ ] Manual: open a single mail with HTML body from an untrusted sender; tap "Load remote images"; verify the snack bar appears, images load, and the snack bar disappears after ~3 seconds while the "View" action button still navigates to `/accounts/trusted-senders` when tapped.
Closes #484
Co-authored-by: Agentloop Bot <agentloop-bot@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/guettli/sharedinbox/pulls/548
308 lines
9.7 KiB
Dart
308 lines
9.7 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'package:sharedinbox/core/models/email.dart';
|
|
import 'package:sharedinbox/core/models/user_preferences.dart';
|
|
import 'package:sharedinbox/di.dart';
|
|
|
|
import 'helpers.dart';
|
|
|
|
Email _threadEmail({
|
|
String id = 'acc-1:10',
|
|
bool isFlagged = false,
|
|
bool isSeen = true,
|
|
}) =>
|
|
Email(
|
|
id: id,
|
|
accountId: 'acc-1',
|
|
mailboxPath: 'INBOX',
|
|
uid: 10,
|
|
threadId: 'thread-1',
|
|
subject: 'Project update',
|
|
receivedAt: DateTime(2024, 6),
|
|
sentAt: DateTime(2024, 6, 1, 9),
|
|
from: const [EmailAddress(name: 'Bob', email: 'bob@example.com')],
|
|
to: const [EmailAddress(email: 'alice@example.com')],
|
|
cc: const [],
|
|
isSeen: isSeen,
|
|
isFlagged: isFlagged,
|
|
hasAttachment: false,
|
|
);
|
|
|
|
void main() {
|
|
group('ThreadDetailScreen', () {
|
|
testWidgets('shows "Thread not found or empty" when thread is empty', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(FakeEmailRepository()),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Thread not found or empty'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('shows sender name for email in thread', (tester) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(emails: [email]),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.textContaining('Bob'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('last email in thread is expanded by default', (tester) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(
|
|
emails: [email],
|
|
emailBody: const EmailBody(
|
|
emailId: 'acc-1:10',
|
|
textBody: 'Hello body text',
|
|
attachments: [],
|
|
),
|
|
),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Reply and delete buttons are visible for the expanded card.
|
|
expect(find.byIcon(Icons.reply), findsOneWidget);
|
|
expect(find.byIcon(Icons.delete_outline), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('tapping an expanded card collapses it', (tester) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(
|
|
emails: [email],
|
|
emailBody: const EmailBody(
|
|
emailId: 'acc-1:10',
|
|
textBody: 'Hello body text',
|
|
attachments: [],
|
|
),
|
|
),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Tap the expand_less icon to collapse.
|
|
await tester.tap(find.byIcon(Icons.expand_less));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byIcon(Icons.reply), findsNothing);
|
|
expect(find.byIcon(Icons.expand_more), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('shows bottom app bar with back button by default', (
|
|
tester,
|
|
) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(emails: [email]),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byType(BottomAppBar), findsOneWidget);
|
|
expect(find.byIcon(Icons.arrow_back), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('hides bottom app bar when button position is top', (
|
|
tester,
|
|
) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
userPreferences: FakeUserPreferencesRepository(
|
|
mailViewButtonPosition: MenuPosition.top,
|
|
),
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(emails: [email]),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byType(BottomAppBar), findsNothing);
|
|
});
|
|
|
|
testWidgets('flagged email shows star icon', (tester) async {
|
|
final email = _threadEmail(isFlagged: true);
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(emails: [email]),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byIcon(Icons.star), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('expanded card shows plain text body', (tester) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(
|
|
emails: [email],
|
|
emailBody: const EmailBody(
|
|
emailId: 'acc-1:10',
|
|
textBody: 'Body content here',
|
|
attachments: [],
|
|
),
|
|
),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Body content here'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets(
|
|
'Load remote images snack bar auto-dismisses after 3 seconds',
|
|
(tester) async {
|
|
final email = _threadEmail();
|
|
await tester.pumpWidget(
|
|
buildApp(
|
|
initialLocation: '/accounts/acc-1/mailboxes/INBOX/threads/thread-1',
|
|
overrides: [
|
|
accountRepositoryProvider.overrideWithValue(
|
|
FakeAccountRepository([kTestAccount]),
|
|
),
|
|
mailboxRepositoryProvider.overrideWithValue(
|
|
FakeMailboxRepository(),
|
|
),
|
|
emailRepositoryProvider.overrideWithValue(
|
|
FakeEmailRepository(
|
|
emails: [email],
|
|
emailBody: const EmailBody(
|
|
emailId: 'acc-1:10',
|
|
htmlBody:
|
|
'<p>Hi <img src="https://example.com/x.png"/></p>',
|
|
attachments: [],
|
|
),
|
|
),
|
|
),
|
|
],
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Load remote images'), findsOneWidget);
|
|
|
|
await tester.tap(find.text('Load remote images'));
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 500));
|
|
|
|
expect(
|
|
find.text('Images will be loaded automatically for this sender.'),
|
|
findsOneWidget,
|
|
);
|
|
|
|
// Regression test for #484: SnackBar with an action defaults to
|
|
// persist=true, which disables auto-dismiss — explicit persist:false
|
|
// restores duration-based dismissal.
|
|
await tester.pump(const Duration(seconds: 4));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
find.text('Images will be loaded automatically for this sender.'),
|
|
findsNothing,
|
|
);
|
|
},
|
|
);
|
|
});
|
|
}
|