guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix: resolve dart analyze failures in chaos_monkey_test.dart #458

Merged
guettlibot merged 2 commits from refs/pull/458/head into main 2026-06-06 03:29:42 +00:00
Conversation 0 Commits 2 Files Changed 4
+572 -4552
guettlibot commented 2026-06-05 21:31:14 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

Fixes CI failures introduced by PR #455 (chaos monkey backend test).

The dart analyze --fatal-infos step in CI was failing because test/backend/chaos_monkey_test.dart had:

  • avoid_print (5 instances): replaced print(...) with stdout.writeln(...) — dart:io is already imported
  • avoid_redundant_argument_values: removed redundant '' from _env('CHAOS_SEED', '') since '' is the parameter default
  • dart format: applied formatter fixes (trailing commas, line wrapping for long connectToServer calls)

Verification

$ nix develop --command bash -c "fvm dart analyze --fatal-infos"
Analyzing 456...
No issues found!

$ nix develop --command bash -c "fvm dart format --output=none --set-exit-if-changed test/backend/chaos_monkey_test.dart"
Formatted 1 file (0 changed) in 0.01 seconds.

Closes #456

🤖 Generated with Claude Code

## Summary Fixes CI failures introduced by PR #455 (chaos monkey backend test). The `dart analyze --fatal-infos` step in CI was failing because `test/backend/chaos_monkey_test.dart` had: - **`avoid_print`** (5 instances): replaced `print(...)` with `stdout.writeln(...)` — `dart:io` is already imported - **`avoid_redundant_argument_values`**: removed redundant `''` from `_env('CHAOS_SEED', '')` since `''` is the parameter default - **`dart format`**: applied formatter fixes (trailing commas, line wrapping for long `connectToServer` calls) ## Verification ``` $ nix develop --command bash -c "fvm dart analyze --fatal-infos" Analyzing 456... No issues found! $ nix develop --command bash -c "fvm dart format --output=none --set-exit-if-changed test/backend/chaos_monkey_test.dart" Formatted 1 file (0 changed) in 0.01 seconds. ``` Closes #456 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#458