fix(tests): remove stale search-toggle test and fix ink_sparkle shader crash #489

2026-06-06T15:31:16Z

guettlibot commented

2026-06-06 15:31:16 +00:00

(Migrated from codeberg.org)

Summary

Deleted the stale 'tapping search icon shows search bar' test from test/widget/email_list_screen_test.dart. The SearchBar is now permanently mounted in AppBar.bottom, so both of the test's assertions (find.byType(TextField), find.text('Search…')) were already true before any interaction. The existing test 'SearchBar is always visible in the AppBar' covers the same intent.
Added splashFactory: NoSplash.splashFactory to both ThemeData instances in test/widget/helpers.dart. This prevents Flutter from trying to load the pre-compiled ink_sparkle.frag shader during widget tests. The bundled shader was compiled for an older SDK format (version 1) and caused an INVALID_ARGUMENT crash under Flutter 3.44.0 (which expects version 2).

Test plan

Run flutter test test/widget/email_list_screen_test.dart — all tests in the file should pass with no shader-related exception.
Confirm the deleted test no longer appears in the output.
Confirm the remaining search tests (submit query, clear results, navigation, etc.) continue to pass.

Closes #486

🤖 Generated with Claude Code

## Summary - Deleted the stale `'tapping search icon shows search bar'` test from `test/widget/email_list_screen_test.dart`. The `SearchBar` is now permanently mounted in `AppBar.bottom`, so both of the test's assertions (`find.byType(TextField)`, `find.text('Search…')`) were already true before any interaction. The existing test `'SearchBar is always visible in the AppBar'` covers the same intent. - Added `splashFactory: NoSplash.splashFactory` to both `ThemeData` instances in `test/widget/helpers.dart`. This prevents Flutter from trying to load the pre-compiled `ink_sparkle.frag` shader during widget tests. The bundled shader was compiled for an older SDK format (version 1) and caused an `INVALID_ARGUMENT` crash under Flutter 3.44.0 (which expects version 2). ## Test plan - [ ] Run `flutter test test/widget/email_list_screen_test.dart` — all tests in the file should pass with no shader-related exception. - [ ] Confirm the deleted test no longer appears in the output. - [ ] Confirm the remaining search tests (submit query, clear results, navigation, etc.) continue to pass. Closes #486 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: guettli/sharedinbox#489