fix(tests): remove stale search-toggle test and fix ink_sparkle shader crash #489

Merged

guettlibot merged 1 commits from issue-486-fix-stale-test-shader-mismatch into main

2026-06-06 16:19:11 +00:00

Author	SHA1	Message	Date
Thomas SharedInboxandClaude Sonnet 4.6	ecc3aeb21d	fix(tests): remove stale search-toggle test and fix ink_sparkle shader crash The 'tapping search icon shows search bar' test was stale: the SearchBar is now permanently visible in AppBar.bottom, so both its assertions held before any tap. Deleted it; the existing 'SearchBar is always visible in the AppBar' test already covers the same intent. Added NoSplash.splashFactory to the widget-test ThemeData to prevent Flutter from loading the pre-compiled ink_sparkle.frag shader, which was built for an older SDK version and caused an INVALID_ARGUMENT crash on Flutter 3.44.0. Closes #486 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-06 17:30:49 +02:00

Author

SHA1

Message

Date

Thomas SharedInboxandClaude Sonnet 4.6

ecc3aeb21d

fix(tests): remove stale search-toggle test and fix ink_sparkle shader crash

The 'tapping search icon shows search bar' test was stale: the SearchBar is
now permanently visible in AppBar.bottom, so both its assertions held before
any tap. Deleted it; the existing 'SearchBar is always visible in the AppBar'
test already covers the same intent.

Added NoSplash.splashFactory to the widget-test ThemeData to prevent Flutter
from loading the pre-compiled ink_sparkle.frag shader, which was built for an
older SDK version and caused an INVALID_ARGUMENT crash on Flutter 3.44.0.

Closes #486

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-06-06 17:30:49 +02:00