guettli/sharedinbox
1
0
Fork 0
Code Issues 21 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix(test): sync before searching in second searchEmails IMAP test #519

Merged
guettlibot merged 1 commits from issue-506-fix-search-emails-tests into main 2026-06-07 00:49:54 +00:00
Conversation 0 Commits 1 Files Changed 2
+605 -3484
guettlibot commented 2026-06-07 00:49:42 +00:00 (Migrated from codeberg.org)
Copy Link
Copy Source

Summary

  • Adds syncEmails('test', 'INBOX') call before searchEmails in the second backend test (searchEmails returns empty list when no messages match), matching the fix already applied to the first test in commit a67b707
  • Adds a clarifying comment to searchEmails in email_repository_impl.dart noting that results depend on the local FTS5 index being populated via syncEmails

Context

Since PR #503 switched searchEmails from IMAP UID SEARCH to local SQLite FTS5, the backend tests must call syncEmails first to populate the index before searching. The first test was already fixed; this completes the fix for the second test.

Test plan

  • flutter test test/backend/email_repository_imap_test.dart — both searchEmails tests should pass once the IMAP backend is running
  • CI backend test step should no longer fail on these two tests

Closes #506

## Summary - Adds `syncEmails('test', 'INBOX')` call before `searchEmails` in the second backend test (`searchEmails returns empty list when no messages match`), matching the fix already applied to the first test in commit a67b707 - Adds a clarifying comment to `searchEmails` in `email_repository_impl.dart` noting that results depend on the local FTS5 index being populated via `syncEmails` ## Context Since PR #503 switched `searchEmails` from IMAP `UID SEARCH` to local SQLite FTS5, the backend tests must call `syncEmails` first to populate the index before searching. The first test was already fixed; this completes the fix for the second test. ## Test plan - [ ] `flutter test test/backend/email_repository_imap_test.dart` — both `searchEmails` tests should pass once the IMAP backend is running - [ ] CI backend test step should no longer fail on these two tests Closes #506
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
NeedSupervisor
Issue escalated to a human supervisor; agentloop will skip it until cleared.
 State/InProgress
State/Later
State/Planned
automerge
Eligible for automatic merge by CI
 ci-failure
Issue opened by agentloop to track a failing CI workflow; used for deduplication.
 do-not-merge
Plan PR — review only, do not merge.
 loop/code
Add to run the built-in "code" prompt; override at prompts/code.md.
 loop/code-ci-pending
Prompt "code" finished; waiting for the PR's CI to pass before advancing.
 loop/code-done
Prompt "code" finished successfully.
 loop/code-in-process
Agent for the "code" prompt is currently running on this issue.
 loop/merge
Managed by agentloop
 loop/merge-done
Managed by agentloop
 loop/merge-in-process
Managed by agentloop
 loop/plan
Add to run the built-in "plan" prompt; override at prompts/plan.md.
 loop/plan-done
Prompt "plan" finished successfully.
 loop/plan-in-process
Agent for the "plan" prompt is currently running on this issue.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
guettlibot guettli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guettli/sharedinbox#519